From nobody Mon Dec 20 14:20:59 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3D6DD1901F58; Mon, 20 Dec 2021 14:21:03 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHhb30yGkz3Mpd; Mon, 20 Dec 2021 14:21:03 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x72e.google.com with SMTP id d2so9393536qki.12; Mon, 20 Dec 2021 06:21:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=55HpwnMdAw1ff9uYpKUMYAQ3QHIHdmvlkyzrhtMMXBo=; b=QiEhaPcPFXqqt7HaVaSqjL80F77VlFPcTkUDCh9GY0+eELWVE1mEGzu4R9loT+Pk6J S6WLxXt3C61nL2prUJu/5xaKHVp3LWxAq8iaE4BfIrNP7EwkEcwrc99ACT49qVaW+WCw fSXNdot3CuPGptp9S63/UTBPfy+oXC7Bc5BjsWjWiS3luQRfSaESJ6UDWJcWEx85yxUz Pp/mbtiXfEk7zRV7UUuBMQY66wQTU4Q1rD2zhq9tk8ed7/HqYaK5L67QaQLZkHEERWjS 20LtdKH5NMpzs8Xxj6xLU6bO+zNABRUxMr2mClCO51pKFXbl4ELvt/dYoSUhCsM3BZUg EbRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=55HpwnMdAw1ff9uYpKUMYAQ3QHIHdmvlkyzrhtMMXBo=; b=awGWmQLQ/OgtA1b4JL+Mup/RpExP7zAsROsRGTcl2RfwCKAAholG7kbaBgFxCt+UVd VtRfVAWdjnUwX9iTH59i78FcSYeJ8HYFalMc8L57M2eQ7ct8325dWPR0UdVwy/KnPmId NUZDR/OTwWyEm7PD75ZD1LdeuVNIDHRMoHrhdV7PcmxvG1WjOmpditYncFnhFOQTj7Pt hCF9aDpJ9uzqwir98cynfIA5jB2d5y8Q8fjLq1WHuMsSBtLtabSXPgDTxDSuY6y5hkh2 SKXQj0Mip7KKaL0FP8RbPqDX9hBI38P9F6vYlIuG7khKHpmAPFOYkmxGwas5OHfqIjjO 8c/w== X-Gm-Message-State: AOAM530D7OukhrUlxlzG4dg0ZZtikHEf22WT6BD+0rzarCt9gZhbU8JE UfWjCsQXcyyJpQDJ7mZm/rPqE//swZY= X-Google-Smtp-Source: ABdhPJzLIe0dq1Ie0KbRhTcoNNmIGmZi1HBTEM3ghrmUZs9XZexPK/vuJPT8lG2fWhmyPN+ATJ6LkQ== X-Received: by 2002:a05:620a:307:: with SMTP id s7mr9535543qkm.85.1640010062288; Mon, 20 Dec 2021 06:21:02 -0800 (PST) Received: from nuc ([142.126.186.191]) by smtp.gmail.com with ESMTPSA id b5sm10796401qka.51.2021.12.20.06.21.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Dec 2021 06:21:01 -0800 (PST) Sender: Mark Johnston Date: Mon, 20 Dec 2021 09:20:59 -0500 From: Mark Johnston To: Kyle Evans Cc: Wojciech Macek , Marcin Wojtas , Wojciech Macek , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: 4f741801d860 - main - t_setrlimit: Adjust resource limit to 20M Message-ID: References: <202112200529.1BK5T0np047358@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4JHhb30yGkz3Mpd X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Dec 20, 2021 at 01:54:22AM -0600, Kyle Evans wrote: > I found the PR that I was thinking of, that you folks might want to > join if you haven't already: https://bugs.freebsd.org/260303 I've posted an update there. I'm in the middle of a move this week and will be a slower than usual to follow up, but would be happy to have some further discussion of the solution. > I don't think a revert's necessary, just something to consider if this > ends up becoming a non-issue due to other low-level changes. I'd argue for a revert: the original test is valid and was changed only to cope with an incompatibility between the RLIMIT_STACK and stack gap implementations. The WIP I wrote to deal with that does not require such a change to the test. At the moment, the test passes anyway since the stack gap was disabled by default. > Thanks, > > Kyle Evans > > On Mon, Dec 20, 2021 at 1:32 AM Wojciech Macek wrote: > > > > Hi Kyle, > > > > Thanks for the comment, I thought this one is discussed but apparently I was mistaken. > > Adding Marcin to handle this on our side. I'm fine with reverting it anyway or do whatever you decide. > > > > Regards, > > Wojtek > > > > pon., 20 gru 2021 o 07:51 Kyle Evans napisał(a): > >> > >> On Sun, Dec 19, 2021 at 11:29 PM Wojciech Macek wrote: > >> > > >> > The branch main has been updated by wma: > >> > > >> > URL: https://cgit.FreeBSD.org/src/commit/?id=4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > >> > > >> > commit 4f741801d86089a1c5d631ba1e0f1421cdcf7a7e > >> > Author: Dawid Gorecki > >> > AuthorDate: 2021-12-20 05:27:12 +0000 > >> > Commit: Wojciech Macek > >> > CommitDate: 2021-12-20 05:28:20 +0000 > >> > > >> > t_setrlimit: Adjust resource limit to 20M > >> > > >> > With ASLR enabled by default, RLIMIT_STACK test fails due to the fact > >> > that default stack gap can be as big as 15M. Because of that the > >> > resource limit of 4M results in test program receiving SIGSEGV > >> > immediately after exiting the setrlimit syscall. Since the idea of this > >> > test is to check if rlim_cur does not extend past rlim_max, adjusting > >> > the resource limit to 20M should not invalidate the test results. > >> > > >> > >> I can't seem to find the PR at the moment, but isn't this exactly the > >> kind of thing markj@ talked about trying to avoid elsewhere? It seems > >> like this probably should've been involved in the discussion rather > >> than hacked around independently. > >> > >> Thanks, > >> > >> Kyle Evans