From nobody Sun Dec 19 23:06:56 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C615A190E8A7 for ; Sun, 19 Dec 2021 23:07:07 +0000 (UTC) (envelope-from joerg@bec.de) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4JHJJV6grcz3PX7 for ; Sun, 19 Dec 2021 23:07:06 +0000 (UTC) (envelope-from joerg@bec.de) Received: (Authenticated sender: joerg@bec.de) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 63BC160002 for ; Sun, 19 Dec 2021 23:06:59 +0000 (UTC) Date: Mon, 20 Dec 2021 00:06:56 +0100 From: Joerg Sonnenberger To: dev-commits-src-all@freebsd.org Subject: Re: git: 48014c667902 - main - Try to fix syntax of "strht" instruction so that clang is happy. Message-ID: References: <202112191253.1BJCrbLc026202@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4JHJJV6grcz3PX7 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of joerg@bec.de has no SPF policy when checking 217.70.183.195) smtp.mailfrom=joerg@bec.de X-Spamd-Result: default: False [-2.02 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.82)[-0.823]; FREEFALL_USER(0.00)[joerg]; FROM_HAS_DN(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[217.70.183.195:from]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[bec.de]; NEURAL_HAM_SHORT(-1.00)[-0.995]; R_SPF_NA(0.00)[no SPF record]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:29169, ipnet:217.70.176.0/20, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[217.70.183.195:from] X-ThisMailContainsUnwantedMimeParts: N On Sun, Dec 19, 2021 at 01:57:48PM +0100, Hans Petter Selasky wrote: > On 12/19/21 13:53, Hans Petter Selasky wrote: > > The branch main has been updated by hselasky: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=48014c6679024f5f1b8217508915fbcd69c2041b > > > > commit 48014c6679024f5f1b8217508915fbcd69c2041b > > Author: Hans Petter Selasky > > AuthorDate: 2021-12-19 12:51:37 +0000 > > Commit: Hans Petter Selasky > > CommitDate: 2021-12-19 12:52:36 +0000 > > > > Try to fix syntax of "strht" instruction so that clang is happy. > > This fixes compilation of usb(4) after 0ec590d24e415dd36e38648630a0b963412ad87e . > > MFC after: 1 week > > Sponsored by: NVIDIA Networking > > --- > > sys/arm/arm/fusu.S | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sys/arm/arm/fusu.S b/sys/arm/arm/fusu.S > > index 300ccb5f020f..fd366542b283 100644 > > --- a/sys/arm/arm/fusu.S > > +++ b/sys/arm/arm/fusu.S > > @@ -234,7 +234,7 @@ ENTRY(suword16) > > adr r3, .Lfusufault > > str r3, [r2, #PCB_ONFAULT] > > - strht r1, [r0] > > + strht r1, [r0], #0 > > Hi, > > GCC 4.8 understands the former syntax, so maybe a hint for the clang ARM > maintainers. GCC doesn't parse assembler at all. Binutils has all kinds of "convience" hacks in the ARM syntax in additional to the legacy (pre-unified) syntax. Joerg