From nobody Sun Dec 12 13:42:08 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0777918DC846; Wed, 15 Dec 2021 16:39:50 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDgvT3PJjz4jFF; Wed, 15 Dec 2021 16:39:49 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr1-x436.google.com with SMTP id e5so5797046wrc.5; Wed, 15 Dec 2021 08:39:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=wJ3igW7jt16TL0NOha1AQ/FZgLV9gM6tq94PyRkD5RA=; b=VPN8jXt3ibcPnzkPssR8Tq1WWvo+/z8kBdYLr2aD9W90GSssbRYnXDou4VYJoFMgFF OzlJSi4SejyClHZvKAcR8MxWrJvraGEFaDJj2YvkKI9gBP9PWNm9CSWXyZim6Kx+Tmoz ZqvLNK95Pcbauqhjp7Uknd9EHVtdo09IZOhiU7Tcg8Sv/52ygguZIQw70mE/d+VMqpZQ vWQZsFVsEH8Ta+03NKpW3GA5ZQ/pwKhMzoydg15MIF0QWwC6Pn3+rQRAntcCjNonwcP3 NB/U/r/RYs/zrBN76md1D0LpSkxnzXnRWIe1pujOrJhRs174QWwsilyiiXdlqqd7ctd3 MbXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=wJ3igW7jt16TL0NOha1AQ/FZgLV9gM6tq94PyRkD5RA=; b=cpcLiprQCJwmVec4iIiIMLMtufx+IALFoVIIzIx/PlR9+LX6aCURhZRmHMfpMyiPcV mNfruf/yNPeiMYOKljPfYjs/+A64LzcVvbJdXGnR6pCrG/tFwdIzO2Kb3g4dN39GTwBB wmbARHiJQH259euYll1oKxKy2MhT4E1FIgJAH6N6sk6qe4xSnR30x15lxuX8j+aaXWbf LoF/WBNgfyW7phZyY150YZXjLu6Inx8DinsCNtmbH3Tm/2tAiVEiTDRTGS5ZiLBmJu1a e10Xx9NnvwWoozw2vrJJ9HMUR1SPTwNBsglnaX4MUw5Y05BVGycG6qNdBc1jVzzMTCqY qfTQ== X-Gm-Message-State: AOAM5338vDR+ShV1VBemUupO4Y6NtQOBN3xlHi7qJn+Wl+bC26lYkgWp mgDlBrCKkTLUaepJ4y3OlfmxwthBslwUNw== X-Google-Smtp-Source: ABdhPJwwrQ7sl6EquwoUfjh2P54GlTjwcJaOaP+43uygV6n9R+AE3XFz5TYrFo1xidH/7U7Pakrq3w== X-Received: by 2002:adf:fc0d:: with SMTP id i13mr5166094wrr.699.1639586382369; Wed, 15 Dec 2021 08:39:42 -0800 (PST) Received: from v3.localdomain (cpc159423-cmbg20-2-0-cust338.5-4.cable.virginm.net. [86.7.147.83]) by smtp.gmail.com with ESMTPSA id c187sm3901871wme.33.2021.12.15.08.39.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Dec 2021 08:39:41 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sun, 12 Dec 2021 13:42:08 +0000 From: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= To: Gleb Smirnoff Cc: Kristof Provost , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: eb93b99d6986 - main - in_pcb: delay crfree() down into UMA dtor Message-ID: Mail-Followup-To: Gleb Smirnoff , Kristof Provost , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202112051847.1B5Il2GP030287@gitrepo.freebsd.org> <28AE53F1-2B22-444B-B1EC-1600FA741FE2@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4JDgvT3PJjz4jFF X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 1215T0713, Gleb Smirnoff wrote: > On Wed, Dec 15, 2021 at 10:47:42AM +0100, Kristof Provost wrote: > K> > My radical opinion is that per-VNET pcb zones should just be eliminated. > K> > The only thing they serve is imposing maxsockets limit separately for > K> > each VNET. But we already have the maxsocket limit on the socket zone, > K> > which is _global_! > K> > > K> > Anybody to explain me the sense of the per-VNET per-pcb zone limit > K> > set to the same maxsockets value? You can't create a pcb without a > K> > socket, which is guaranteed by the in_pcballoc() prototype. Of course > K> > I understand that pcbs may outlive the socket. But those pcbs that > K> > outlive a socket, are eventually garbage collected as their lifetime > K> > is finite. Anyway jail/VNET was never declared as a resource management > K> > framework anyway! > K> > > K> > K> rctl(8) does appear to support per-jail resource limits, but I’m not sure how complete or functional that is. > > The manual doesn't say anything about network resources. The sources > of in_pcballoc() neither suggest that any per-something resource management > is done that can prevent allocation. True. I'm guessing it should be possible to limit it via 'openfiles' resource, but there's nothing socket-specific in RCTL.