From nobody Wed Dec 15 01:56:56 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8499E18E6C00; Wed, 15 Dec 2021 01:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDJJn19Pxz4TNj; Wed, 15 Dec 2021 01:56:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id DFA2B13836; Wed, 15 Dec 2021 01:56:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BF1uugL032073; Wed, 15 Dec 2021 01:56:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BF1uuGg032072; Wed, 15 Dec 2021 01:56:56 GMT (envelope-from git) Date: Wed, 15 Dec 2021 01:56:56 GMT Message-Id: <202112150156.1BF1uuGg032072@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Konstantin Belousov Subject: git: 9d18bf1daff5 - stable/12 - x86: add a comment providing source for numbers in legacy XSAVE area layout List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/stable/12 X-Git-Reftype: branch X-Git-Commit: 9d18bf1daff5b0feb64411494ce5ceadf3d70b1b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639533417; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ykRGuJ8VlF0PfP+9x//wuAWdqbL+I7kLsgj0cmNqM6w=; b=Iz0WJ3VSgAFxERTgXaqPM/WZTQQcPPjJoubF/Mr8NdYZJ0WZBWn+9EuogYG9iGVlPJZm7f hYtuXi4f3N0/Jv+GZ9VIoCSeH6DFRhjnZAOJi8NuZmiJlkCf6nXfsKL2ghrSbl8EVgNwJO EeolxYE5fxt5CmbLWyiK+ECGz9zLRebkbvsVT7+kCWqgxRi21yiX9hlVdgg5lKzCOZG+qO 1mrUUHQjm48R0NcOeTIB9GrkamS+hJPvc8xOuRA0Hp2ViJumrCdEFYC52Xw/Yarr2eziCf btjUkAx/gefmUAzwdMzGxx4EINZIrpR1AzUf3HzqAW415d+86ND/o9pIdYVbDA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639533417; a=rsa-sha256; cv=none; b=sOLb7D6s5jkazCTNN4eCXvKG+yPal4cwgjskzFRJWHIJOyQ5t8kLzzjyW8XcwB42cackzl oNqtP2QyRr4mbZnlYchIfdqkBShT17oYjIYnEJsMX0z9SaPONnFMHU6Q3IvuuItQc/fds7 j9Ps3IjhG1rtCkLoVvdikSMaPMBirYibMzIB5o8DdW8wKAGJRwBBI1fWMi2k/nZUWIU1QK 5dAMzZjzH9/CzHmNZAQxaFeg/UDJEsSuhDpmEp/np5cge0JtwgiTEaj4ZpyBqHr0sgMy0f dyG2zqZHThSdiKL2x6RZvrVNGk+M021EokR9r5jB58PExhGDqihBwSie94xDhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/12 has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=9d18bf1daff5b0feb64411494ce5ceadf3d70b1b commit 9d18bf1daff5b0feb64411494ce5ceadf3d70b1b Author: Konstantin Belousov AuthorDate: 2021-12-13 23:25:36 +0000 Commit: Konstantin Belousov CommitDate: 2021-12-15 01:56:32 +0000 x86: add a comment providing source for numbers in legacy XSAVE area layout (cherry picked from commit 0e6b06d5c8719597b2ec59e6856b5decbd9e65f6) --- sys/amd64/amd64/fpu.c | 3 ++- sys/i386/i386/npx.c | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sys/amd64/amd64/fpu.c b/sys/amd64/amd64/fpu.c index d17241bf2523..91df1259be46 100644 --- a/sys/amd64/amd64/fpu.c +++ b/sys/amd64/amd64/fpu.c @@ -465,7 +465,8 @@ fpuinitstate(void *arg __unused) /* * Create a table describing the layout of the CPU Extended - * Save Area. + * Save Area. See Intel SDM rev. 075 Vol. 1 13.4.1 "Legacy + * Region of an XSAVE Area" for the source of offsets/sizes. */ if (use_xsave) { xstate_bv = (uint64_t *)((char *)(fpu_initialstate + 1) + diff --git a/sys/i386/i386/npx.c b/sys/i386/i386/npx.c index c64ef4ca895f..abf3ab5bd6df 100644 --- a/sys/i386/i386/npx.c +++ b/sys/i386/i386/npx.c @@ -515,7 +515,10 @@ npxinitstate(void *arg __unused) /* * Create a table describing the layout of the CPU Extended - * Save Area. + * Save Area. See Intel SDM rev. 075 Vol. 1 13.4.1 "Legacy + * Region of an XSAVE Area" for the source of offsets/sizes. + * Note that 32bit XSAVE does not use %xmm8-%xmm15, see + * 10.5.1.2 and 13.5.2 "SSE State". */ if (use_xsave) { xstate_bv = (uint64_t *)((char *)(npx_initialstate + 1) +