From nobody Tue Dec 14 19:09:35 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8759018E30ED for ; Tue, 14 Dec 2021 19:09:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD7H13CgDz4qHx for ; Tue, 14 Dec 2021 19:09:49 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-vk1-xa31.google.com with SMTP id f7so13142484vkf.10 for ; Tue, 14 Dec 2021 11:09:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tYZEq104rf9gmS2NcZ1MT9SxGGpPFVlT8YE66zILRfQ=; b=Dj+TihDfEC4Y7YFVjGNyj2EwoCkoVgvWoHmpj7UlV+Ptyd4Ccpzg69rYGVvJHb+lXx NsA18BsBsW3LRrx6nwisAaJQ8/937pEFnIWdAwhbcIOc5yFctNefWvKy868EZOdztMFv MUHfFBCMWFm1MriJZyOJO/qFmHET1QlONuO06TErKlQ67riczo6vKjFJT2lb4afdgDJ4 0Q65Q1n7+CLx3vmc75jdDZWZ9RLSDHVlVU+1npXmHv47PQ+nbs4LwfS5aY81szepz+12 dfTm6ZpAR80ImOnqnaCVVxOLylr4AqAr2VoMOLH8qnYHGARQOKlIqvKC/lfH3yhiEYOc I0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tYZEq104rf9gmS2NcZ1MT9SxGGpPFVlT8YE66zILRfQ=; b=4S4Fhta9r8QAj8t6+cmyOAPkQSSVsKqzdqOZwFxvvvTRRpf7V17PoWn36+vK/B4hw6 pc7ALjW3Zffo2PHr8qKv+frok+J+Xfm1IM8tIyEvmIdV8joTQkb+QACFAUAaZzVMrQZl j2yuERvaPUHcU9JXO6ycR0eg322LkcllKOECX4BhQqxc5scChT95HR+9huE93HtGLJrH kGAcEepmngBCg67C91/9DZIvC+mg1TteoaAkv9fZV8OpVExMv+QDSkjWe2ZhmTVM0q1G 50sbRNJxjIWd8aJifpDH/5SEQjawVI+/LqAREGXVLUbUNAEJ8BgyIaoYyxgZhbXRISvf MicQ== X-Gm-Message-State: AOAM533qOy0vql8aGm2WAiqXU0A61UZ1Nt9WgA0wi1TwczmHgJTt7EM/ 9bkUEhwuK1jhipuH2usZNhOXQM3axYVU8f0+WguJxg== X-Google-Smtp-Source: ABdhPJwudwD4bblDC5kk/BEMgzp+LaLGZjuUVR5Gzr0nHqpXXBLhB6YM7G6HriPJ9VcADkIB4110zAx68fR9pNlg6Y8= X-Received: by 2002:a1f:14c5:: with SMTP id 188mr1120283vku.5.1639508985971; Tue, 14 Dec 2021 11:09:45 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> <367d9216-53f7-044d-34b9-fae8460bd7bc@FreeBSD.org> In-Reply-To: <367d9216-53f7-044d-34b9-fae8460bd7bc@FreeBSD.org> From: Warner Losh Date: Tue, 14 Dec 2021 12:09:35 -0700 Message-ID: Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default To: John Baldwin Cc: Ed Maste , Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000b8bcfc05d31fee52" X-Rspamd-Queue-Id: 4JD7H13CgDz4qHx X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --000000000000b8bcfc05d31fee52 Content-Type: text/plain; charset="UTF-8" On Tue, Dec 14, 2021 at 11:57 AM John Baldwin wrote: > On 12/14/21 10:42 AM, Ed Maste wrote: > > On Tue, 14 Dec 2021 at 13:27, John Baldwin wrote: > >> > >> This breaks NO_CLEAN=yes builds in I think a lot of object files. > >> ... > >> Perhaps we should be generating those header files in OBJDIR (and use a > move-if-changed > >> scheme to avoid bumping the date if the contents haven't changed) so > that make can handle > >> these changes? > > > > Seems reasonable if that change is straightforward, but we could also > > just add a special case in tools/build/depend-cleanup.sh to handle > > this. depend-cleanup can be fairly liberal, e.g. delete *.def. > > Yes, but the problem isn't deleting *.def. Those are static files whose > content > changes based on -D flags passed on the command line and you need to > delete all > the *.o files that include those .def files. Note that if you switch from > WITHOUT_LLVM_TARGET_ALL to WITH_LLVM_TARGET_ALL or vice versa between > builds > you would also hit this issue. > True that. Hence my desire to move these into a file that changes when the option changes :) If there's some cheap hack I can do to fix this, I'm open to suggestions. I just don't want to spend a day futzing with it since I have other things I'm trying to get done this week.... Warner --000000000000b8bcfc05d31fee52--