From nobody Tue Dec 14 18:57:03 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3FCDA18DF469; Tue, 14 Dec 2021 18:57:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD70K0lKJz4mKv; Tue, 14 Dec 2021 18:57:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 698585831; Tue, 14 Dec 2021 18:57:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <367d9216-53f7-044d-34b9-fae8460bd7bc@FreeBSD.org> Date: Tue, 14 Dec 2021 10:57:03 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: git: 4dbc7835cdfc - main - mips: Turn off LLVM MIPS targets by default Content-Language: en-US To: Ed Maste Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202112101831.1BAIVQbm048153@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639508225; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5+LuMJjo3DWjM1870QG8bD0m8DsXhR6aeY1EZBZ5ckg=; b=Mc1htRpy+2tWmWfgSLSH4kGWV8iThxFesz47/hNgmyZKTYiULianzwZJcB8c6YIyVfuaG/ KgneHak48bal/GsaWqx2W42nyZbRcjlYFzRG8Y+9OXGmUC7jnCv9QfoWuKs6+LVT1+cQKg hGFxgXU29QwnL/RcrGaz/Va2CU4x7rvzflkxFG5d3yE7LH/qJlqw4DUT4l6dNV+yK0v6XZ HhgjSl4Vl74P7gAMKndXzQlciQB02BhxvJ3F7SKetNPnqRlti+ewicFMi+MzxM/ywXq4y8 jaLsqeKjKy2S4fxGa0RuTIqTJotGlNRlOKdoq2bXbNo27+YU8pR8dVP1ueUubw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639508225; a=rsa-sha256; cv=none; b=EJt9SVP9Rt7T8VieL0x9hvco6CUcKvsvmRvlJoc5XuOuSurn9etvaucR3Bh5Dd+JOKRtTt iISjwnmPDD8aqHhS5hZdkCQvy+yqqB54weYfx1R0Eaaci1qx3BnVhNUCjLTVn2QJY/5u8I MV/JYmlUbCI7JUGOidf37WmDrmfEoObFiBMqqeQE5jmaCntK5ExZbuAd5x3noyckm+t2ns uhYwkefsRWG3F205QE/88wXkNw3ugC3ETfGvNeI+UxxHp0JqcOlhFUsv1lCBo7BoJgsW3y lqlHuwJ7IWSzkHijlEun/dOH2YZnhNblDP9rGv8ujP+udYUUmeh4hkHVpp5sIw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 12/14/21 10:42 AM, Ed Maste wrote: > On Tue, 14 Dec 2021 at 13:27, John Baldwin wrote: >> >> This breaks NO_CLEAN=yes builds in I think a lot of object files. >> ... >> Perhaps we should be generating those header files in OBJDIR (and use a move-if-changed >> scheme to avoid bumping the date if the contents haven't changed) so that make can handle >> these changes? > > Seems reasonable if that change is straightforward, but we could also > just add a special case in tools/build/depend-cleanup.sh to handle > this. depend-cleanup can be fairly liberal, e.g. delete *.def. Yes, but the problem isn't deleting *.def. Those are static files whose content changes based on -D flags passed on the command line and you need to delete all the *.o files that include those .def files. Note that if you switch from WITHOUT_LLVM_TARGET_ALL to WITH_LLVM_TARGET_ALL or vice versa between builds you would also hit this issue. -- John Baldwin