From nobody Tue Dec 14 17:12:02 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2F8F618E977F; Tue, 14 Dec 2021 17:12:05 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JD4g81lmYz3n0p; Tue, 14 Dec 2021 17:12:04 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [10.0.1.4] (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 78A0D4983; Tue, 14 Dec 2021 17:12:03 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 14 Dec 2021 09:12:02 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: git: 866036f46c6e - main - bhyve: Support a _VARS.fd file for bootrom Content-Language: en-US To: Rebecca Cran , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202112121508.1BCF8Q8P012270@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202112121508.1BCF8Q8P012270@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639501924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/J6akpQEWLE5t9rmUri8253TkdrMZLFrupVSI/aKQ4=; b=xoVi/wbpWuZjvDtz2wF7ryyCb/3uAF8mry54J8Zwew/k0dTaQYrJ2ZoU72l+IigfvGckFj 38V/Jr9zFyYjJxuNH0gz/xRwJSuHzDgKw/bxiTR0UK8ewXqtWZgP1zDfyXrX+rZssoNRh1 XJij/5vuYffd/8gsaFG6RFxuB2+xw6Ks0HzTh78Y2WM/GTxGxJTLuyywWB94R9PY6zbTEU IYa9Ep9IlK5XPVrxl3jbIjqYpABRXKNZDsOy6U2ParkkOhpN5YMdBDq4aUpb08+Ml+up1/ MWB0eoHV8xyGa2pIPtpJCUa1vPjs4c+YNVTtwAzu878/aRgI3vGGdmd1MEG3Bg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639501924; a=rsa-sha256; cv=none; b=d4C/26pGqiqT/qlL5vGjV99v2KnQayr+BCQuCtANQoDrKFwRIEq0ZtG6tHqpg3OILYZzfB LkX3Mhpqa29GTGyV2/3rbdPeoxTCnU3OpmR5cdGkK1KzVGkaVDyHqWLVraNP8gN2dQuwzb jj1P+eZUib7/u/o5Ai6fTwePrOtNH/bag+/9Yl5/VxWb8UjHqGp9vq0yDtMRRGUYWcF+xQ ygRGEKLn0laySAG2DOZTx8x6+EgFQb97JScjPediTt8LMUs+JtPCAdhb4jLzq8S9EaATc2 OklNhCKmjGLYd/C/3oa97cM2vqZQ4c4JC0aJv8H9syUOb11yADU5DDNRG21Nog== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 12/12/21 7:08 AM, Rebecca Cran wrote: > The branch main has been updated by bcran: > > URL: https://cgit.FreeBSD.org/src/commit/?id=866036f46c6e8884cc7a2aa029408366ede40a23 > > commit 866036f46c6e8884cc7a2aa029408366ede40a23 > Author: Rebecca Cran > AuthorDate: 2021-11-28 16:34:33 +0000 > Commit: Rebecca Cran > CommitDate: 2021-12-12 15:07:27 +0000 > > bhyve: Support a _VARS.fd file for bootrom > > OVMF creates two separate .fd files, a _CODE.fd file containing > the UEFI code, and a _VARS.fd file containing a template of an > empty UEFI variable store. > > OVMF decides to write variables to the memory range just below the > boot rom code if it detects a CFI flash device. So here we add > just the barest facsimile of CFI command handling to bootrom.c > that is needed to placate OVMF. > > Submitted by: D Scott Phillips > Sponsored by: Intel Corporation > Differential Revision: https://reviews.freebsd.org/D19976 > MFC After: 1 week Hmm, how does this work with the configuration stuff? I would expect the vars file to be a separate config file variable (e.g. lpc.vars_file or the like)? Can you document it in bhyve_config.5 and fix it to use a separate variable if that is intended? -- John Baldwin