From nobody Wed Dec 08 10:33:28 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id DF56418D29CC; Wed, 8 Dec 2021 10:33:39 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mx.blih.net (mail.blih.net [212.83.155.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx.blih.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J8D6C1g0lz4tC3; Wed, 8 Dec 2021 10:33:39 +0000 (UTC) (envelope-from manu@bidouilliste.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bidouilliste.com; s=mx; t=1638959611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YoM0j3gCIz+sdd8nJSpcqsLzQdwCAj8YqmWTu42ZgJg=; b=W8CK0Jm97lFh1bXQJZtCDk83ShIBe647+xe+5ptzmRSL/kV45LsMCI8QmrEr+TfoHUW3TT QCvbunR3UeIhrMHMEV+ZjW6ni/lYQH97GBiN3g9R66XT3gSC96yeCpii82Zs7OZ2f6gvmA +UwovSvUun/pQG+cOKRTNWypDfQK5K8= Received: from skull.home.blih.net (lfbn-idf2-1-1163-183.w90-92.abo.wanadoo.fr [90.92.222.183]) by mx.blih.net (OpenSMTPD) with ESMTPSA id 25aefb36 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 8 Dec 2021 10:33:31 +0000 (UTC) Date: Wed, 8 Dec 2021 11:33:28 +0100 From: Emmanuel Vadot To: Wojciech Macek Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: de9c000cedfe - main - sdhci_fsl_fdt: Add support for HS200/HS400 modes Message-Id: <20211208113328.295de39f3c1b976d5c07531f@bidouilliste.com> In-Reply-To: <202112081021.1B8ALYH0041586@gitrepo.freebsd.org> References: <202112081021.1B8ALYH0041586@gitrepo.freebsd.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4J8D6C1g0lz4tC3 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 8 Dec 2021 10:21:34 GMT Wojciech Macek wrote: > The branch main has been updated by wma: > > URL: https://cgit.FreeBSD.org/src/commit/?id=de9c000cedfe77c6da4929178fee571b1fd0cc80 > > commit de9c000cedfe77c6da4929178fee571b1fd0cc80 > Author: Hubert Mazur > AuthorDate: 2021-11-03 09:38:05 +0000 > Commit: Wojciech Macek > CommitDate: 2021-12-08 10:21:02 +0000 > > sdhci_fsl_fdt: Add support for HS200/HS400 modes > > The controller requires some custom logic to perform MMC tuning > and to later switch to HS400 mode. Implement it supplying mmcbr_tune > and sdhci_set_uhs_timing devmethods respectivly. Since the latter > is called unconditionally when the ios is updated we need to keep > track of the tuning state in sc and execute the HS400 switch logic > only when required. > > Two HS200/HS400 related errata were implemented. > 1. In HS400 modes the clock divisors are limited to 4, 8, 12. > Apply it by falling back to the closes, higher divider when needed. > 2. Hardware tuning procedure can sometimes fails. If that is the case > fallback to the software tuning. > > Reviewed by: manu, mw I did not review that one, it's way larger than the other ones so I wanted to have a look later. > Obtained from: Semihalf > Sponsored by: Alstom Group > Differential revision: https://reviews.freebsd.org/D33320 -- Emmanuel Vadot