From nobody Tue Dec 07 10:41:30 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2638618C36A7; Tue, 7 Dec 2021 10:41:31 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J7cKk552Bz4cZw; Tue, 7 Dec 2021 10:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 877371E2DF; Tue, 7 Dec 2021 10:41:30 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1B7AfUHv044383; Tue, 7 Dec 2021 10:41:30 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1B7AfUCR044382; Tue, 7 Dec 2021 10:41:30 GMT (envelope-from git) Date: Tue, 7 Dec 2021 10:41:30 GMT Message-Id: <202112071041.1B7AfUCR044382@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Hans Petter Selasky Subject: git: 83237efcdbc1 - main - kldstat(8): style(9) fixes. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: hselasky X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 83237efcdbc183e14a27a93579e53bb571756d6a Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638873690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZzESvwgqbnAHdZsBswcN8Nj+lbQkx9v0XAegYtd2UPg=; b=v7zFDLLTJGCXwaVve6HQmcc9StC4y38AVNfkmP5SrY/jTtpdwxBNe4VihU7k1S/aum1vtO mCjC3i+fhNACUnBpl8PyY1Fsigzizp1SLEx4SeHuCDLP/YUzQvN4/fef3kty/Li1B59y1p zSKaRquBot5vIV6T3Fro8/TNLtdAdgVOouqDfu9dJ0B0pvDXIxB0niARGRtdpLw0LajJaS Yf7cs3e7qOPiHCrkoHpPib+ik2Jo33tMRLISgnCNqEDxDqOWyrmwO19RVgWfhjhocipQmV JfJX88UC9cF3nuwNaaBaWAFrtAuaGBIKdjFVmGdX4Y8epdAMrciYwG2puZE2ag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638873690; a=rsa-sha256; cv=none; b=IFXRUta22MrGhQ0F9h+0vTPhEeZkzrlHK1PvMT7QxqUuLw+b7iRFO5yXI4L9GqukkDd4T3 1Ea0rny9jrAGFIqQB9TYx43Q9LfMJ1iEJn8u4xU9eVikcfm/s/p5piXkyrZ/mofDlBM5ax 55JYYbmuxY4aHoVuoxAoujjWaS3UfSplbISuCTAAZ7s+Dtk5GOikxR2gbPX0EqIED2eU9T yrwEbzCp1vv3WhHbN9L0wWUbHsGEKq0/FJgc9Idq8eafS1CxxO2PuDWW/xyxuItC6/3YPh TDOFtcbovKjr5TOvmJSqmI53Du/6caykNAAPDtTLyqAlLC3ELwN6KudSIa+97g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by hselasky: URL: https://cgit.FreeBSD.org/src/commit/?id=83237efcdbc183e14a27a93579e53bb571756d6a commit 83237efcdbc183e14a27a93579e53bb571756d6a Author: Hans Petter Selasky AuthorDate: 2021-11-09 21:09:59 +0000 Commit: Hans Petter Selasky CommitDate: 2021-12-07 10:40:22 +0000 kldstat(8): style(9) fixes. No functional change intended. Differential revision: https://reviews.freebsd.org/D32506 Submitted by: christos@ MFC after: 1 week Sponsored by: NVIDIA Networking --- sbin/kldstat/kldstat.c | 107 +++++++++++++++++++++++++------------------------ 1 file changed, 54 insertions(+), 53 deletions(-) diff --git a/sbin/kldstat/kldstat.c b/sbin/kldstat/kldstat.c index 0925223da23a..b8e4fd6e4b5d 100644 --- a/sbin/kldstat/kldstat.c +++ b/sbin/kldstat/kldstat.c @@ -29,18 +29,23 @@ #include __FBSDID("$FreeBSD$"); -#include -#include -#include -#include -#include #include #include #include #include + +#include +#include +#include +#include #include +#include + +#define PTR_WIDTH ((int)(sizeof(void *) * 2 + 2)) -#define POINTER_WIDTH ((int)(sizeof(void *) * 2 + 2)) +static void printmod(int); +static void printfile(int, int, int); +static void usage(void) __dead2; static int showdata = 0; @@ -51,16 +56,16 @@ printmod(int modid) bzero(&stat, sizeof(stat)); stat.version = sizeof(struct module_stat); - if (modstat(modid, &stat) < 0) + if (modstat(modid, &stat) < 0) { warn("can't stat module id %d", modid); - else { - if (showdata) - printf("\t\t%3d %s (%d, %u, 0x%lx)\n", stat.id, - stat.name, stat.data.intval, stat.data.uintval, - stat.data.ulongval); - else - printf("\t\t%3d %s\n", stat.id, stat.name); + return; } + if (showdata) { + printf("\t\t%3d %s (%d, %u, 0x%lx)\n", stat.id, + stat.name, stat.data.intval, stat.data.uintval, + stat.data.ulongval); + } else + printf("\t\t%3d %s\n", stat.id, stat.name); } static void @@ -71,21 +76,19 @@ printfile(int fileid, int verbose, int humanized) char buf[5]; stat.version = sizeof(struct kld_file_stat); - if (kldstat(fileid, &stat) < 0) { + if (kldstat(fileid, &stat) < 0) err(1, "can't stat file id %d", fileid); + if (humanized) { + humanize_number(buf, sizeof(buf), stat.size, + "", HN_AUTOSCALE, HN_DECIMAL | HN_NOSPACE); + + printf("%2d %4d %*p %5s %s", + stat.id, stat.refs, PTR_WIDTH, stat.address, + buf, stat.name); } else { - if (humanized) { - humanize_number(buf, sizeof(buf), stat.size, - "", HN_AUTOSCALE, HN_DECIMAL | HN_NOSPACE); - - printf("%2d %4d %*p %5s %s", - stat.id, stat.refs, POINTER_WIDTH, stat.address, - buf, stat.name); - } else { - printf("%2d %4d %*p %8zx %s", - stat.id, stat.refs, POINTER_WIDTH, stat.address, - stat.size, stat.name); - } + printf("%2d %4d %*p %8zx %s", + stat.id, stat.refs, PTR_WIDTH, stat.address, + stat.size, stat.name); } if (verbose) { @@ -98,27 +101,28 @@ printfile(int fileid, int verbose, int humanized) printf("\n"); } -static void +static void __dead2 usage(void) { - fprintf(stderr, "usage: kldstat [-d] [-h] [-q] [-v] [-i id] [-n filename]\n"); - fprintf(stderr, " kldstat [-d] [-q] [-m modname]\n"); + fprintf(stderr, "usage: %1$s [-dhqv] [-i id] [-n filename]\n" + " %1$s [-dq] [-m modname]\n", getprogname()); exit(1); } int -main(int argc, char** argv) +main(int argc, char *argv[]) { - int c; + struct module_stat stat; int humanized = 0; int verbose = 0; int fileid = 0; int quiet = 0; - char* filename = NULL; - char* modname = NULL; - char* p; + int c, modid; + char *filename = NULL; + char *modname = NULL; + char *p; - while ((c = getopt(argc, argv, "dhi:m:n:qv")) != -1) + while ((c = getopt(argc, argv, "dhi:m:n:qv")) != -1) { switch (c) { case 'd': showdata = 1; @@ -146,6 +150,7 @@ main(int argc, char** argv) default: usage(); } + } argc -= optind; argv += optind; @@ -153,16 +158,12 @@ main(int argc, char** argv) usage(); if (modname != NULL) { - int modid; - struct module_stat stat; - if ((modid = modfind(modname)) < 0) { if (!quiet) warn("can't find module %s", modname); - return 1; - } else if (quiet) { - return 0; - } + return (1); + } else if (quiet) + return (0); stat.version = sizeof(struct module_stat); if (modstat(modid, &stat) < 0) @@ -181,30 +182,30 @@ main(int argc, char** argv) } } - return 0; + return (0); } if (filename != NULL) { if ((fileid = kldfind(filename)) < 0) { if (!quiet) warn("can't find file %s", filename); - return 1; - } else if (quiet) { - return 0; - } + return (1); + } else if (quiet) + return (0); } - if (humanized) - printf("Id Refs Address%*c %5s Name\n", POINTER_WIDTH - 7, + if (humanized) { + printf("Id Refs Address%*c %5s Name\n", PTR_WIDTH - 7, ' ', "Size"); - else - printf("Id Refs Address%*c %8s Name\n", POINTER_WIDTH - 7, + } else { + printf("Id Refs Address%*c %8s Name\n", PTR_WIDTH - 7, ' ', "Size"); + } if (fileid != 0) printfile(fileid, verbose, humanized); else for (fileid = kldnext(0); fileid > 0; fileid = kldnext(fileid)) printfile(fileid, verbose, humanized); - return 0; + return (0); }