From nobody Mon Dec 06 14:58:53 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id E128C18B7A35; Mon, 6 Dec 2021 14:58:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J76593kqPz3wFF; Mon, 6 Dec 2021 14:58:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 601005D92; Mon, 6 Dec 2021 14:58:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1B6EwreP049278; Mon, 6 Dec 2021 14:58:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1B6Ewr0C049277; Mon, 6 Dec 2021 14:58:53 GMT (envelope-from git) Date: Mon, 6 Dec 2021 14:58:53 GMT Message-Id: <202112061458.1B6Ewr0C049277@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Randall Stewart Subject: git: dadbc042500b - main - tcp: rack fails to send out a TLP after a MTU change List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: rrs X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: dadbc042500b57cb2ceb25bc0ec39583142e0c45 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638802733; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zRB/0vvsASQRW96nAWfKKmDAzLQB27eCSwKAAD6DvjY=; b=SbwR7kqznrJDSmSoMjulnd8SeBAYrK22CSTTcaX/6lQiGME0hmc3TcEAJgQmetflOReNfK LDDtX8weUpBUbKrnRYxf7zBslsyhNAerd5dV4KITIdzoBQN/FQNPNLJBnJDnj/Sb98+0CT m4XMYtHNQvh+PJzTAPa6/kt7YzfvziaTD80p4uvMdlv46NDF2Q5+5wk8Wdgd866RjkPud3 Eq58SXTJAyDyH7+3om77RpuY6wCMIlEyUtnZkzEZBr0E5c9Z0BX3ie60F22eGcW/DM8Hjy wzy+gzkcW941MBA4J+4IV0YY5KJZ/ClcClQUSAd1s9VyTRePvvmFrVTbknnOdQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638802733; a=rsa-sha256; cv=none; b=o8iWz5H7KsvcnZSd8PsjsLXrp6ygx6yoUtmxD9rSfuY20h/WXya1TO78y+LQZesI9ZiUC4 Rh5Uwk/h7JLK5MzxoogVKXlNCwK7X/fnreFDktipgarHfMHd7NHAQh5rBLeWxApiCTDjsb FGLISLa+5szMJ/N+YavXTuYNCggSskJWnDfMEirI3/hI0VYaEv+hlUZtN54mHwW0PVdqDt yEf087w1yfz1UfMN/hp2zmta6jUu5fOW/l2FC9sHhzRfN335pwdX+eMU/dskqNRVHGJHry PqzLpe8DUkk7Ee1XpuEut5Jk42auMyHzc3sThvTQ5nFiyJhaovui4TS60K2lHA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by rrs: URL: https://cgit.FreeBSD.org/src/commit/?id=dadbc042500b57cb2ceb25bc0ec39583142e0c45 commit dadbc042500b57cb2ceb25bc0ec39583142e0c45 Author: Randall Stewart AuthorDate: 2021-12-06 14:56:09 +0000 Commit: Randall Stewart CommitDate: 2021-12-06 14:56:09 +0000 tcp: rack fails to send out a TLP after a MTU change When rack sends out a TLP it sets up various state to make sure it avoids the cwnd (its been more than 1 RTT since our last send) and it may at times send new data. If an MTU change as occurred and our cwnd has collapsed we can have a situation where must_retran flag is set and we obey the cwnd thus never sending the TLP and then sitting stuck. This one line fix addresses that problem Reviewed by: Michael Tuexen Sponsored by: Netflix Inc. Differential Revision: https://reviews.freebsd.org/D33231 --- sys/netinet/tcp_stacks/rack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index 7391734a9786..16faa887530f 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -17139,6 +17139,7 @@ again: len = cwin; } if (rack->r_must_retran && + (doing_tlp == 0) && (rsm == NULL)) { /* * Non-Sack and we had a RTO or Sack/non-Sack and a