From nobody Mon Dec 06 06:00:08 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B970C18B1E50; Mon, 6 Dec 2021 06:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J6t7X3Mz8z3m4w; Mon, 6 Dec 2021 06:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 5392726385; Mon, 6 Dec 2021 06:00:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1B66089i030728; Mon, 6 Dec 2021 06:00:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1B6608CX030724; Mon, 6 Dec 2021 06:00:08 GMT (envelope-from git) Date: Mon, 6 Dec 2021 06:00:08 GMT Message-Id: <202112060600.1B6608CX030724@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: 1d92e81fa479 - main - cam/iosched: fix off by one error List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1d92e81fa47925dab1fa3779b8e8e2e35d3c14ce Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638770408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+7YK9LHqx8YDsh9nzgbfVwHq3HJqz9a+DsMr5aR1mU8=; b=sT/xL5fq8s+2HiL8lRc533Bq9LmXbsP+Sz303QHxFnc2qXcOqLeaMA8KK9JYFVcrGnj/vc kV8Xd82jBHof5eXA3aWHoOBAAAIfxVL8IpVhGB6Ktikk3CvE4Ho5Gc6PDXC5W7c8hsJFKq AuvCRydoiDka1NCaQJM0nMAfxdDXfTBT87Ls8hd4j7hU0MxFYfQrR6UaI/dQwxMD9kjFAH XQSzfw9dfp4m/ltBghtAJjFPJ/elw9VZizOolhTOl31O07T2kytE/M3xInjNF4mP57gvAG xenH7ewX3czxbIoc2KxAKLX/Hxxq60qyxfYt+wuw01NC/BC9YvmR79cQENBnEQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638770408; a=rsa-sha256; cv=none; b=YCaytikCP4RJltH5rwxrIFT/yOyL7dA93xXj/tKjmQS42BOtlBEvPPeuKC46dQQTGz/hIf e/TVT7hlR5IFh66AUDHmert7sv9EOwcyOrNCKRxsP6X3in1AJ+GNkGfWrd0Uo4K9cjHNcA g+l7Fr+c0OkIMc3UIiJfBCxDNikO8NGUAgeQUXnlj2ZhA9GZp9FIzjZyoljaj/8gsgf3RT bGIsphQXstGco+yfXWPGqus8PieLiAn5QWbTr7f/wWw5h3q50m4Q8KLp4qvU+QSZBJusY/ eFT2xJ1QEGM1VM39uBGh0Jwk8uagitJKGGhlcgeJOku2/zU+0/vtFY4W9qhXsw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=1d92e81fa47925dab1fa3779b8e8e2e35d3c14ce commit 1d92e81fa47925dab1fa3779b8e8e2e35d3c14ce Author: Warner Losh AuthorDate: 2021-12-06 05:57:50 +0000 Commit: Warner Losh CommitDate: 2021-12-06 06:00:01 +0000 cam/iosched: fix off by one error Set the bucket size to be SBT_1US/50000 + 1 to be the first number > 20us. I had this uncommitted in my three when I pushed 2283206935b8 since kern.cam.iosched.bucket_base_us was reporting 19us. Fixes: 2283206935b8 Sponsored by: Netflix --- sys/cam/cam_iosched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/cam/cam_iosched.c b/sys/cam/cam_iosched.c index 10caefdb02ea..4d584dc160a3 100644 --- a/sys/cam/cam_iosched.c +++ b/sys/cam/cam_iosched.c @@ -112,7 +112,7 @@ SYSCTL_INT(_kern_cam_iosched, OID_AUTO, alpha_bits, CTLFLAG_RW | CTLFLAG_TUN, * of 5.2s which is safeily larger than 1s to help diagnose extreme outliers better. */ #ifndef BUCKET_BASE -#define BUCKET_BASE (SBT_1S / 50000) /* 20us */ +#define BUCKET_BASE ((SBT_1S / 50000) + 1) /* 20us */ #endif static sbintime_t bucket_base = BUCKET_BASE; SYSCTL_SBINTIME_USEC(_kern_cam_iosched, OID_AUTO, bucket_base_us, CTLFLAG_RD,