From nobody Sat Dec 04 18:16:42 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9C0C718CA7E4; Sat, 4 Dec 2021 18:16:47 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (cross.sbone.de [195.201.62.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J5yZR13Mnz506C; Sat, 4 Dec 2021 18:16:46 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 7C07B8D4A129; Sat, 4 Dec 2021 18:16:45 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id B5B1DE708BE; Sat, 4 Dec 2021 18:16:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id ITUOLeeQ8UAh; Sat, 4 Dec 2021 18:16:43 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 48988E708BC; Sat, 4 Dec 2021 18:16:43 +0000 (UTC) Date: Sat, 4 Dec 2021 18:16:42 +0000 (UTC) From: "Bjoern A. Zeeb" To: Gleb Smirnoff cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: ad2a0aec2954 - main - nhop: hash ifnet pointer instead of if_index In-Reply-To: <202112041806.1B4I6HGV058876@gitrepo.freebsd.org> Message-ID: References: <202112041806.1B4I6HGV058876@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 4J5yZR13Mnz506C X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Sat, 4 Dec 2021, Gleb Smirnoff wrote: > The branch main has been updated by glebius: > > URL: https://cgit.FreeBSD.org/src/commit/?id=ad2a0aec295478e750158b8985422f15deee0e54 > > commit ad2a0aec295478e750158b8985422f15deee0e54 > Author: Gleb Smirnoff > AuthorDate: 2021-12-04 18:05:46 +0000 > Commit: Gleb Smirnoff > CommitDate: 2021-12-04 18:05:46 +0000 > > nhop: hash ifnet pointer instead of if_index > > Yet another problem created by VIMAGE/if_vmove/epair design that > relocates ifnet between vnets and changes if_index. Since if_index > changes, nhop hash values also changes, unlink_nhop() isn't able to > find entry in hash and leaks the nhop. Since nhop references ifnet, > the latter is also leaked. As result running network tests leaks > memory on every single test that creates vnet jail. That sounds like something (new) is done in wrong sequence for these cases. Plastering around that sounds wrong as it simply hides the real problem. -- Bjoern A. Zeeb r15:7