From nobody Fri Dec 03 20:20:07 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 12F3318CADD7; Fri, 3 Dec 2021 20:20:29 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J5PMc5cvxz4gfj; Fri, 3 Dec 2021 20:20:28 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (root@eg.sd.rdtc.ru [62.231.161.221] (may be forged)) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id 1B3KKJdP005307 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Dec 2021 20:20:20 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: emaste@FreeBSD.org Received: from [10.58.0.10] (dadvw [10.58.0.10]) by eg.sd.rdtc.ru (8.16.1/8.16.1) with ESMTPS id 1B3KKI8D053621 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sat, 4 Dec 2021 03:20:18 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: git: 0a2bc1aae36b - stable/12 - release: move installworld before installkernel To: Ed Maste , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org References: <202112031520.1B3FK0Yh010104@gitrepo.freebsd.org> From: Eugene Grosbein Message-ID: <0ceb1866-07a1-9ba8-8ea4-104329ca7cb8@grosbein.net> Date: Sat, 4 Dec 2021 03:20:07 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: <202112031520.1B3FK0Yh010104@gitrepo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT autolearn=disabled version=3.4.2 X-Spam-Report: * -0.0 SHORTCIRCUIT No description available. * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 4J5PMc5cvxz4gfj X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-Spam: Yes X-ThisMailContainsUnwantedMimeParts: N 03.12.2021 22:20, Ed Maste wrote: > The branch stable/12 has been updated by emaste: > > URL: https://cgit.FreeBSD.org/src/commit/?id=0a2bc1aae36b44b2c9e16684bc6270b8a82943e2 > > commit 0a2bc1aae36b44b2c9e16684bc6270b8a82943e2 > Author: Ed Maste > AuthorDate: 2021-04-05 17:16:01 +0000 > Commit: Ed Maste > CommitDate: 2021-12-03 15:19:09 +0000 > > release: move installworld before installkernel > > To support -DNO_ROOT work. The top-level installworld target creates a > new METALOG starting with `#mtree 2.0` so it needs to be first, to avoid > overwriting installkernel METALOG entries. > > Reviewed by: gjb > MFC after: 1 month > Sponsored by: The FreeBSD Foundation > Differential Revision: https://reviews.freebsd.org/D29582 The need to run installworld before installkernel makes remote major upgrade less reliable: in case of unexpected reboot in process a system ends up with new binaries that may require new system calls and old kernel. This is bad. Is it possible to enhance install* targets so they do not overwrite what needs to be kept intact to restore ability to install new kernel first?