From nobody Wed Dec 01 18:06:38 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6155C18BEA83; Wed, 1 Dec 2021 18:06:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J46V70khBz3Cwl; Wed, 1 Dec 2021 18:06:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id E5FFA66D1; Wed, 1 Dec 2021 18:06:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1B1I6c7l094463; Wed, 1 Dec 2021 18:06:38 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1B1I6cQM094462; Wed, 1 Dec 2021 18:06:38 GMT (envelope-from git) Date: Wed, 1 Dec 2021 18:06:38 GMT Message-Id: <202112011806.1B1I6cQM094462@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: 94a72c5ac428 - main - amdtemp: Revert related part of "Make CPU children" commit. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 94a72c5ac4285b2940e5d2c7e53d21c84023defc Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638381999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=spnAlEvbmr93XjVwbcmxxtkxvGIm0luLg3vgsE/HKH4=; b=sEhXmzDC0FVgTF3k4DU9lLVqf9V/KohFmRs3klsvpqitJ1/OjnDuZ0IdayNKOVL887/D4v kOXVyjytsxMFA2hI1CsDSKacxxAlIXuFReaDcZhbkm9Cpg3mFNRM6iKDxKVloKVVWHF9yx arqJLdDq9Dmus3Jm33IBT+Q84wMItn4GnTq62wXwCo8PajWNtIeycmw9SecC6gA7hrhWEF 3d6KFYuSXcZvRRwlYpieix4tyVr8+W9L0QD4LuhVJro8wWbXbOPMqKGaU6AMwmJEI4fIbO JZ4pKWg3Vl8NTa1nKqRzkwHxX2aMwwQZW6wqqyelDbVR4DWB1sCZLqWIYfRKew== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638381999; a=rsa-sha256; cv=none; b=xIIWsQte1BnfBS2rhSM9/aeGpU2lOyUSQAKVpjwdJn7rgcoGHAE29LOiKj2h7+mE8hMDzc RO7OkeT2KraBMth4f7A76aaw9TWaoYsHgHC4Z/VauMAvKjk3OVVhzKP5TopXTaYxSQcSnm SGnr8LXtYBWz3LKEAUXf3V1jmxQvXEAA/I9yg31SFxCgW+CfOUU0qdQvSyVZs+hsTUkCPs 3p37XcxaZhpRl9jpYpGQZ32/CX9LaybTOruajyYsl8k7muDFrF8usD7xB5C+vdAfbLXQqt 8hRPkuPsfOF5+zF3xzopbpUxxNjsJsKEUZDtV/OgP2HKrB+yTS1RfG/hnmdNzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=94a72c5ac4285b2940e5d2c7e53d21c84023defc commit 94a72c5ac4285b2940e5d2c7e53d21c84023defc Author: Alexander Motin AuthorDate: 2021-12-01 18:00:17 +0000 Commit: Alexander Motin CommitDate: 2021-12-01 18:04:31 +0000 amdtemp: Revert related part of "Make CPU children" commit. While it still looks like previous code worked by coincidence, this change broke things even more instead of fixing. Reported by: avg@ MFC after: 1 week --- sys/dev/amdtemp/amdtemp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/amdtemp/amdtemp.c b/sys/dev/amdtemp/amdtemp.c index c1d696d070a5..21227a47c513 100644 --- a/sys/dev/amdtemp/amdtemp.c +++ b/sys/dev/amdtemp/amdtemp.c @@ -263,8 +263,7 @@ amdtemp_identify(driver_t *driver, device_t parent) return; if (amdtemp_match(parent, NULL)) { - child = device_add_child(parent, "amdtemp", - device_get_unit(parent)); + child = device_add_child(parent, "amdtemp", -1); if (child == NULL) device_printf(parent, "add amdtemp child failed\n"); }