From nobody Wed Dec 01 06:39:05 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 771FC18AE012; Wed, 1 Dec 2021 06:39:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J3qDs1Hhbz4qNB; Wed, 1 Dec 2021 06:39:09 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from [192.168.0.88] (unknown [195.64.148.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: avg/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 6B0B6D06B; Wed, 1 Dec 2021 06:39:08 +0000 (UTC) (envelope-from avg@FreeBSD.org) Message-ID: <3c211281-ce4a-3d99-ab45-4d8a6fbdbe55@FreeBSD.org> Date: Wed, 1 Dec 2021 08:39:05 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.3.0 Subject: Re: git: d3a8f98acbf5 - main - Make CPU children explicitly share parent unit numbers. Content-Language: en-US To: Alexander Motin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202109250332.18P3W9UM008783@gitrepo.freebsd.org> From: Andriy Gapon In-Reply-To: <202109250332.18P3W9UM008783@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1638340749; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZrRJfVFc5uuDmziJTrSjvJsQGfBJZbZGycFW6WvHZ64=; b=mNfhas3N9ADTn1ce3UYazntJruvcZiGrTIf1bqDbRhyXw/lrjLn1MDqhLnTkH8q5kEO6U7 xPktUqlZbBlllKwVmsXBhx9xGEeGO3smZS4wDQKo+HGqSnyW5WyHfffiJcUWRdxIolzjLk VM7OmJWF4q12iRFUuGmc2UxX6cKQReiGcCzqXmMImxuOia5KAeDvfq/PAadOGiQ5M2xhkI pTgrscmpFLJtVZi+Vo4OhLFaAi0udY5lC3U8gIVvCbnaiaDzIGeAIDlpunDrxaNwDC0EXq 6sck2NS9QYEZadcAYhc4zSUrqJzDfueMaEiYQkAdBPlIox35zdrJZR13syQfXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1638340749; a=rsa-sha256; cv=none; b=MZ+v+d7Cn7fSelZRhfZE4ZgxCQA/NcRoSKfZx8keGxP+gx9p45Ju9rvquWfEhlJPUeBH4T P+OXS6a8ANRYccjPP3NoUMA0xPiH4xkQYj3Z5AACVlHE6nW9YKQWwyNZh3Iyg6D8aZit0M R/K9kTZRhAsobn3HZinDICkLeihtD/GSRSNQzQQ2uQFBilSdh054wndOgjQMVs8ujIVcXD xYWhFIXubukYv3lwFH5zFu2l/7K6KqFR+Z4GV9ARQ3vmEE+XGFArFRjIngTTHQfw9sDgyY JaKVmS9MMZD1orD5ulqcnaeAW+zif5euGHfV5Qa0+fMWlbpF6ApUSPjtugukcQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On 25/09/2021 06:32, Alexander Motin wrote: > The branch main has been updated by mav: > > URL: https://cgit.FreeBSD.org/src/commit/?id=d3a8f98acbf51e728411f10c5f179a30b9ca683c > > commit d3a8f98acbf51e728411f10c5f179a30b9ca683c > Author: Alexander Motin > AuthorDate: 2021-09-25 03:25:46 +0000 > Commit: Alexander Motin > CommitDate: 2021-09-25 03:31:51 +0000 > > Make CPU children explicitly share parent unit numbers. > > Before this device unit number match was coincidental and broke if I > disabled some CPU device(s). Aside of cosmetics, for some drivers > (may be considered broken) it caused talking to wrong CPUs. > --- > sys/dev/acpica/acpi_perf.c | 3 ++- > sys/dev/acpica/acpi_throttle.c | 3 ++- > sys/dev/amdtemp/amdtemp.c | 3 ++- It seems that the amdtemp part of this change broke creation of dev.cpu.0.temperature sysctl node on my (old hardware) system. I have 4 cores and amdtemp attaches under hostb4: cpu0 pnpinfo _HID=none _UID=0 _CID=none at handle=\_PR_.P001 acpi_perf0 acpi_throttle0 hwpstate0 cpufreq0 cpu1 pnpinfo _HID=none _UID=0 _CID=none at handle=\_PR_.P002 acpi_perf1 hwpstate1 cpu2 pnpinfo _HID=none _UID=0 _CID=none at handle=\_PR_.P003 acpi_perf2 hwpstate2 cpu3 pnpinfo _HID=none _UID=0 _CID=none at handle=\_PR_.P004 acpi_perf3 hwpstate3 ... pcib0 pnpinfo _HID=PNP0A03 _UID=0 _CID=none at handle=\_SB_.PCI0 pci0 ... hostb4 pnpinfo vendor=0x1022 device=0x1203 subvendor=0x0000 subdevice=0x0000 class=0x060000 at slot=24 function=3 dbsf=pci0:0:24:3 amdtemp4 As you can see amdtemp attaches in a different sub-tree from cpus and its parent's unit number does not have any relation to any processor. -- Andriy Gapon