From nobody Thu Jan 30 05:57:44 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Yk7bX2VNsz5mhFD; Thu, 30 Jan 2025 05:57:44 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Yk7bX20v9z4F7l; Thu, 30 Jan 2025 05:57:44 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738216664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KO4g6y9/FCOkuS7oLxSM1FoafcMXkjnlldYAsZ3NGzQ=; b=yRl3K407koE4g61/4Kz23vjQysyKRdN5ge/XXDAVsY5cfei6h/Qg80aJsP61Pv/WBAW8AQ g/rv9cQwmJD9uJ10mWHwcv15MWZOJ1pGSQyTLg+RXV+485K/oJFuYiYnk65kVqKRuwJmS8 bcx+eiQixeyAd9o16AJDIDl9RYoeGPfZrwYxhWtzsbsTN2ndFy75uPwhkEqlsjjweEsH5v SblNTLWMWWFSqcUkl9goa7VOVfh0/yP//13RQP+i3ypDxb0yE5z0UPIHDGJvJBGVD/YMrc r7BkCpCiJsiIxwiEFMUkz4u4IbHwPzB4LY4iJxqis6MNKNOXELdjriYyEhzM7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1738216664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KO4g6y9/FCOkuS7oLxSM1FoafcMXkjnlldYAsZ3NGzQ=; b=bMj+qLJN0x74mbD5JnSbcHGcVmy5uITr3MMXsDBFPV1TU3mww3FAeonQoS6/hQCgLjitlx wePPCubkegrdALyYydgg0xnGYUBGbBPFRmUaJj9FJcokRHjspIBwKMTujV77CNT+LpwlFW j0q8ee1SKPiVY2OanZ/mzYPLNvLczXZ/taruiEzYYyO3KNzXni+cfp5qZ2BkK4h4jvzw0V 0t//I/djxz3GyoLfcp86YAQSA09nG80GREK8q1c3IZq9HbSVKhKOLZDroTIeiWlL6g8cwf J2td4kSvl2jrWuPQgv/iRxAodgFfpbbWWUFKg9hTVHXbn44T8jCeTzxzdKuDig== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1738216664; a=rsa-sha256; cv=none; b=LmDZKspFLDTDa/SvCUcq6uG21IE/tu0FqweT8wEePDbS/JTi4jm43cpiI017veoWi2TDOn E4MLFTVpfOxhLwqEHac0NwkqzLBRj2iDaMXPgWLIjlm2N932RidaPpFiWhJQlfMCCWaQg9 nUWww1ZaiTyGRJQHbvWlg2bA8jZFa0fhnaQ3XoVUP8hhPlF5U3V9Lrhms7fD4uOJ6rcGA6 gAW95jIxVE/4pB7Ww+TK1f0vQk11Q66RXLX6KrQrzepc8ihZAnrh1j0brWyo9KG9iA7dkj FrPxyR8M83D7xE6/w7g6CAWZ31pjg/3Ue2K8GBg8CHe4HRy3wAP/Qn4Dz7wcyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: by freefall.freebsd.org (Postfix, from userid 1033) id 2DD454D38; Thu, 30 Jan 2025 05:57:44 +0000 (UTC) Date: Thu, 30 Jan 2025 05:57:44 +0000 From: Alexey Dokuchaev To: Ryan Steinmetz Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4ca613c4414b - main - irc/eggdrop: Fix build, bump PORTREVISION Message-ID: References: <202501291814.50TIEUIr089656@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202501291814.50TIEUIr089656@gitrepo.freebsd.org> On Wed, Jan 29, 2025 at 06:14:30PM +0000, Ryan Steinmetz wrote: > commit 4ca613c4414b2dfaa9de5336b6da5a74aa73f5d4 > > irc/eggdrop: Fix build, bump PORTREVISION > > PR: 283584 > ... > post-patch: > - @${REINPLACE_CMD} -e 's|tcl.h|tcl${TCL_VER}/tcl.h|g' ${WRKSRC}/src/mod/python.mod/pycmds.c > + @${SED} -i '' -e '25d' ${WRKSRC}/src/mod/python.mod/pycmds.c There are several issues with this commit. It doesn't explain what was the problem and how removing 25th line fixes it. Wasn't there a better anchor than the line number? Also, why use ${SED} -i '' instead of canonical ${REINPLACE_CMD}? Last, if it's a *build* fix, why bump port revision? ./danfe