Re: git: 6c458c3785df - main - lang/quickjs-ng: add a new port quickjs-ng

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Tue, 28 Jan 2025 21:29:44 UTC
On 2025-01-28T22:03:36.000+01:00, Sergey A. Osokin <osa@FreeBSD.org>
wrote:

> The branch main has been updated by osa:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=6c458c3785dfc12064350c2e0aee9105105a5fd4
> 
> commit 6c458c3785dfc12064350c2e0aee9105105a5fd4
> 
> Author:     Sergey A. Osokin <osa@FreeBSD.org>
> 
> AuthorDate: 2025-01-28 21:00:55 +0000
> 
> Commit:     Sergey A. Osokin <osa@FreeBSD.org>
> 
> CommitDate: 2025-01-28 21:03:22 +0000
> 
>     lang/quickjs-ng: add a new port quickjs-ng
> 
>     
> 
>     QuickJS, the Next Generation: a mighty JavaScript engine
> 
> ---
> 
>  lang/quickjs-ng/Makefile  | 31 +++++++++++++++++++++++++++++++
> 
>  lang/quickjs-ng/distinfo  |  3 +++
> 
>  lang/quickjs-ng/pkg-descr |  6 ++++++
> 
>  lang/quickjs-ng/pkg-plist | 17 +++++++++++++++++
> 
>  4 files changed, 57 insertions(+)
> 
> diff --git a/lang/quickjs-ng/Makefile b/lang/quickjs-ng/Makefile
> 
> new file mode 100644
> 
> index 000000000000..0141051cbfb4
> 
> --- /dev/null
> 
> +++ b/lang/quickjs-ng/Makefile
> 
> @@ -0,0 +1,31 @@
> 
> +PORTNAME=    quickjs
> 
> +PORTVERSION=    0.8.0
> 
> +DISTVERSIONPREFIX=    v
> 
> +CATEGORIES=    lang devel
> 
> +PKGNAMESUFFIX=    -ng
> 
> +
> 
> +MAINTAINER=    osa@FreeBSD.org
> 
> +COMMENT=    Embeddable Javascript interpreter in C (NG fork)
> 
> +WWW=        https://quickjs-ng.github.io/quickjs/
> 
> +
> 
> +LICENSE=    MIT
> 
> +LICENSE_FILE=    ${WRKSRC}/LICENSE
> 
> +
> 
> +USES=        compiler:c11 cmake:testing,noninja cmake cpe tar:xz
> 
> +USE_LDCONFIG=    yes
> 
> +
> 
> +USE_GITHUB=    yes
> 
> +GH_ACCOUNT=    quickjs-ng
> 
> +
> 
> +CPE_VENDOR=    ${PORTNAME}_project
> 
> +
> 
> +CMAKE_ON=    BUILD_SHARED_LIBS
> 
> +CMAKE_TESTING_TARGET=    run-test262
> 
> +
> 
> +CONFLICTS=    quickjs
> 
> +
> 
> +PLIST_SUB=    PORTVERSION=${PORTVERSION}
> 
> +
> 
> +OPTIONS_DEFINE=    DOCS
> 
> +
> 
> +.include <bsd.port.mk> [http://bsd.port.mk>];
> 
> diff --git a/lang/quickjs-ng/distinfo b/lang/quickjs-ng/distinfo
> 
> new file mode 100644
> 
> index 000000000000..529e2ff37c39
> 
> --- /dev/null
> 
> +++ b/lang/quickjs-ng/distinfo
> 
> @@ -0,0 +1,3 @@
> 
> +TIMESTAMP = 1738086355
> 
> +SHA256 (quickjs-ng-quickjs-v0.8.0_GH0.tar.gz) = 7e60e1e0dcd07d25664331308a2f4aee2a88d60d85896e828d25df7c3d40204e
> 
> +SIZE (quickjs-ng-quickjs-v0.8.0_GH0.tar.gz) = 815932
> 
> diff --git a/lang/quickjs-ng/pkg-descr b/lang/quickjs-ng/pkg-descr
> 
> new file mode 100644
> 
> index 000000000000..1dffbd6788dc
> 
> --- /dev/null
> 
> +++ b/lang/quickjs-ng/pkg-descr
> 
> @@ -0,0 +1,6 @@
> 
> +QuickJS is a small and embeddable JavaScript engine. It aims to support
> 
> +the latest ECMAScript specification.
> 
> +
> 
> +This project is a fork of the original QuickJS project by Fabrice
> 
> +Bellard and Charlie Gordon, after it went dormant, with the intent of
> 
> +reigniting its development.
> 
> diff --git a/lang/quickjs-ng/pkg-plist b/lang/quickjs-ng/pkg-plist
> 
> new file mode 100644
> 
> index 000000000000..ea563aa94294
> 
> --- /dev/null
> 
> +++ b/lang/quickjs-ng/pkg-plist
> 
> @@ -0,0 +1,17 @@
> 
> +bin/qjs
> 
> +bin/qjsc
> 
> +include/quickjs.h
> 
> +lib/cmake/quickjs/qjsConfig-%%CMAKE_BUILD_TYPE%%.cmake
> 
> +lib/cmake/quickjs/qjsConfig.cmake
> 
> +lib/libqjs.so [http://libqjs.so]
> 
> +lib/libqjs.so.0 [http://libqjs.so.0]
> 
> +lib/libqjs.so [http://libqjs.so].%%PORTVERSION%%
> 
> +%%PORTDOCS%%%%DOCSDIR%%/LICENSE
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/fib.c
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/fib_module.js
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/hello.js
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/hello_module.js
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/pi_bigint.js
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/point.c
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/test_fib.js
> 
> +%%PORTDOCS%%%%DOCSDIR%%/examples/test_point.js

Hi,

Please review the USE_GITHUB section in Porters Handbook and follow
the examples (use of variables and ordering)

USES contains multiple entries of cmake

USES contains tar:xz (incorrect)

Please sort USES alphabetically

Fails to build when CPUTYPE is set to znver3 , znver4, haswell to
menton a few

Best regards,

Daniel