Re: git: e94a554e5542 - main - net/libproxy: bump consumers

Le Tue, Jan 21, 2025 at 02:03:18AM -0500, Charlie Li a écrit :
> Mathieu Arnold wrote:
> > Le Mon, Jan 20, 2025 at 09:39:58AM -0500, Charlie Li a écrit :
> > > LIBPROXY is not enabled by default in any of the gecko@ ports.
> > 
> > I don't see how this is relevant.
> > On shared library change, you bump a port if it has a dependency to the
> > library in question, wether that dependency is optional or not has
> > nothing to do with it.
> > 
> It is absolutely relevant when the resulting package content does not change
> because it never linked to the bumped library in the first place. If the
> option with the bumped library was enabled by default, the generated package
> content would change, thus PORTREVISION bump in such case. I don't remember
> any previous cases where PORTREVISIONs were bumped when the package contents
> don't change on a default disabled option.

Well, for people who enabled the optionm the resulting package
definitively is linked with the library, and is broken.

The ports tree is not only for people using the official packages, you
need to account for every users, thus bump ports depending on a library,
wether it is a default dependency or not.

-- 
Mathieu Arnold