Re: git: 560772623792 - main - net/freerdp3: adjust missed reference to www/webkit2-gtk
- Reply: Vladimir Druzenko : "Re: git: 560772623792 - main - net/freerdp3: adjust missed reference to www/webkit2-gtk"
- In reply to: Vladimir Druzenko : "Re: git: 560772623792 - main - net/freerdp3: adjust missed reference to www/webkit2-gtk"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 21 Jan 2025 14:44:26 UTC
Vladimir Druzenko wrote: > 21.01.2025 17:09, Charlie Li пишет: >> Vladimir Druzenko wrote: >>> 21.01.2025 16:43, Charlie Li пишет: >>>> -WEBKIT_LIB_DEPENDS_= libsoup-2.4.so:devel/libsoup \ >>>> +WEBKIT_LIB_DEPENDS= libsoup-2.4.so:devel/libsoup \ >>> >>> This is not a typo. Please revert this line back. >>> >> Is there a reason for the trailing underscore? It causes tooling and >> regexes that look for *_DEPENDS to miss lines like this, so ports like >> this get missed when dependencies need their consumers bumped. >> > We can rename it to _WEBKIT_LIB_DEPENDS for example. And > WEBENGINE_LIB_DEPENDS_ to _WEBENGINE_LIB_DEPENDS too. > > Option AAD require WITH_WEBVIEW - one of the option from WEBKIT or > WEBENGINE (can't use IMPLIES). And they conflict with each other. > The preceding underscore should work better. I don't want to mess up your logic further by doing it wrong myself so you can have at it. -- Charlie Li ...nope, still don't have an exit line.