From nobody Tue Jan 21 14:23:30 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YcqFX15nrz5l8wB for ; Tue, 21 Jan 2025 14:23:44 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4YcqFT50wRz43jM; Tue, 21 Jan 2025 14:23:40 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=dec.sakura.ne.jp header.s=s2405 header.b=RFWgqV1+; spf=pass (mx1.freebsd.org: domain of junchoon@dec.sakura.ne.jp designates 153.125.133.21 as permitted sender) smtp.mailfrom=junchoon@dec.sakura.ne.jp; dmarc=pass (policy=none) header.from=dec.sakura.ne.jp Received: from kalamity.joker.local (124-18-43-234.area1a.commufa.jp [124.18.43.234]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 50LENVwc033648; Tue, 21 Jan 2025 23:23:31 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dec.sakura.ne.jp; s=s2405; t=1737469411; bh=KUvr9aNlTwBceSyxNj+4KnWpCsMNLTrmZ0NNAsPB/kQ=; h=Date:From:To:Cc:Subject; b=RFWgqV1+Sv1Iji1P/UtINqsH/wDidHCKHbEvVKZ2+oWRQPunxgerga+nE8kHUramz GT0KrcmjMkNEZxEyJYCEEXtyl/BvTis8zRBKldxKzDieFd+yPjfJcZ+cDVEwZrTjPt 4pUzteF7akgXT21b6HbbJIQGkTqknT2MtYBTlots= Date: Tue, 21 Jan 2025 23:23:30 +0900 From: Tomoaki AOKI To: Charlie Li , Vladimir Druzenko Cc: dev-commits-ports-main@freebsd.org Subject: Re: git: 560772623792 - main - net/freerdp3: adjust missed reference to www/webkit2-gtk Message-Id: <20250121232330.e421a4d4dd7d6f095580b9c8@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.2) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-0.67 / 15.00]; RBL_SENDERSCORE_REPUT_9(-1.00)[153.125.133.21:from]; FAKE_REPLY(1.00)[]; SUSPICIOUS_URL_IN_SUSPICIOUS_MESSAGE(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999]; NEURAL_HAM_LONG(-0.99)[-0.992]; NEURAL_HAM_SHORT(-0.98)[-0.983]; MV_CASE(0.50)[]; URIBL_RED(0.50)[dec.sakura.ne.jp:dkim,dec.sakura.ne.jp:mid,dec.sakura.ne.jp:email]; ONCE_RECEIVED(0.20)[]; MIME_GOOD(-0.10)[text/plain]; BAD_REP_POLICIES(0.10)[]; HAS_ANON_DOMAIN(0.10)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_DKIM_ALLOW(0.00)[dec.sakura.ne.jp:s=s2405]; DMARC_POLICY_ALLOW(0.00)[dec.sakura.ne.jp,none]; RCVD_TLS_LAST(0.00)[]; HAS_ORG_HEADER(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[dec.sakura.ne.jp:+]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(0.00)[+ip4:153.125.133.16/28]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; TO_DN_SOME(0.00)[] X-Spamd-Bar: / X-Rspamd-Queue-Id: 4YcqFT50wRz43jM Hi. > Vladimir Druzenko wrote: >> 21.01.2025 16:43, Charlie Li пишет: >>> -WEBKIT_LIB_DEPENDS_= libsoup-2.4.so:devel/libsoup \ >>> +WEBKIT_LIB_DEPENDS= libsoup-2.4.so:devel/libsoup \ >> >> This is not a typo. Please revert this line back. >> > Is there a reason for the trailing underscore? It causes tooling and > regexes that look for *_DEPENDS to miss lines like this, so ports like > this get missed when dependencies need their consumers bumped. Found logics using it in line 216 through line 229 of net/freerdp3/Makefile as below. Possibly I'm overlooking something, but something like "WEBENGINE_USE_GNOME= " are not implemented, while "*_USES=" and "*_*DEPENDS" are implemented. Vladimir, is this the reason you've used variable with trailing underscore? ===== Quote ===== .if ${PORT_OPTIONS:MAAD} . if ${PORT_OPTIONS:MWEBENGINE} USES+= ${WEBENGINE_USES_} USE_QT+= ${WEBENGINE_USE_QT} . elif ${PORT_OPTIONS:MWEBKIT} LIB_DEPENDS+= ${WEBKIT_LIB_DEPENDS_} USES+= ${WEBKIT_USES_} USE_GNOME+= ${WEBKIT_USE_GNOME} . else CMAKE_OFF+= WITH_WEBVIEW . endif .else CMAKE_OFF+= WITH_WEBVIEW .endif ===== End quote ===== Regards. -- Charlie Li ...nope, still don't have an exit line. -- Tomoaki AOKI