Re: git: 98582ae673d8 - main - mail/opensmtpd-table-sqlite: new port

On Jan 21 2025, 06:51 +0000, Mathieu Arnold <mat@freebsd.org> wrote:
>Le Mon, Jan 20, 2025 at 01:19:38PM +0000, Pietro Cerutti a écrit :
>> > That gets rid of patching and USES= autoreconf and you probably also
>> > want USES= localbase:ldflags instead of localbase . Looking at Porters
>> > Handbook you should likely also make use of PKGNAMEPREFIX instead of
>> > having opensmtpd- in PORTNAME.
>>
>> I don't see the point of using PKGNAMEPREFIX.
>
>I don't think it is up to you, the porter's handbook makes it explicit
>so the choice wether using PORTNAME or PORTNAME and PKGNAMEPREFIX is
>made for you.
>PORTNAME has to be set to the software's name.

I don't see it as clear cut. Can you point me to the paragraph in the 
handbook that mandates a particular choice? At the end of the day, I 
don't see a practical difference, and historically some degree of 
freedom was left to developers. It is very annoying that you guys get 
down to these minutiae.

As a counter-example, www/nginx-naxsi uses PORTMAME=nginx and 
PKGNAMESUFFIX=-naxsi. I guess your reading of the porters handbook would 
mandate PORTNAME=naxsi and PKGNAMEPREFIX=nginx-.

>Looking at <https://github.com/opensmtpd/table-sqlite>, it refers to
>"TABLE_SQLITE(5)", "table_sqlite", or "SQLITE TABLE CONFIG FILE". So the
>software name is "table sqlite".

Of course, I'm sure you'll agree, the reason for this is that everything 
you mention is in the context of opensmtpd already.

> So, what the porter's handbook tells you to do is 
> `PORTNAME=table-sqlite` and `PKGNAMEPREFIX=opensmtpd-`.

Again, I don't see it.

This is the last thing I'll say on the subject, I have other things to 
fill my free time with. Feel free to change the port if you think *your* 
free time is best spent that way.

-- 
Pietro Cerutti
I have pledged to give 10% of income to effective charities
and invite you to join me - https://givingwhatwecan.org