Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files
Date: Sun, 19 Jan 2025 15:24:12 UTC
On 2025-01-05T18:54:50.000+01:00, Daniel Engberg <daniel.engberg.lists@pyret.net> wrote: > On 2025-01-05T18:47:02.000+01:00, Daniel Engberg > > <daniel.engberg.lists@pyret.net> wrote: > >> On 2025-01-05T16:38:28.000+01:00, Dirk Meyer <dinoex@FreeBSD.org> >> >> wrote: >> >>> The branch main has been updated by dinoex: >>> >>> URL: >>> >>> https://cgit.FreeBSD.org/ports/commit/?id=942e8b555262a6e684ef69e96e0036e065fb8211 >>> >>> commit 942e8b555262a6e684ef69e96e0036e065fb8211 >>> >>> Author: Dirk Meyer <dinoex@FreeBSD.org> >>> >>> AuthorDate: 2025-01-05 15:38:11 +0000 >>> >>> Commit: Dirk Meyer <dinoex@FreeBSD.org> >>> >>> CommitDate: 2025-01-05 15:38:11 +0000 >>> >>> graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files >>> >>> --- >>> >>> graphics/Makefile | 1 + >>> >>> graphics/pcdtojpeg/Makefile | 33 ++++++ >>> >>> graphics/pcdtojpeg/distinfo | 3 + >>> >>> graphics/pcdtojpeg/pkg-descr | 3 + >>> >>> graphics/pcdtojpeg/pkg-plist | 238 >>> >>> +++++++++++++++++++++++++++++++++++++++++++ >>> >>> 5 files changed, 278 insertions(+) >> >> Hi, >> >> Unfortunately this appears to be broken in multiple ways. >> >> Resulting binary doesn't work (14.2-RELEASE on amd64): >> >> pcdtojpeg BlownJohn.pcd BlownJohn-pcd-stock.jpeg >> >> Segmentation fault (core dumped) >> >> pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg >> >> Segmentation fault (core dumped) >> >> pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg >> >> Segmentation fault (core dumped) >> >> pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg >> >> Warning: Could not open 64Base IPE file >> >> while trying to process ICE file >> >> "/home/diizzy/patches-upstream/IPE/BlownJohn/64BASE/INFO.IC" >> >> Segmentation fault (core dumped) >> >> While documentation is provided a note about this during install >> >> would >> >> be helpful. >> >> Image source: >> >> https://sembiance.com/fileFormatSamples/image/pcd/ >> >> CXXFLAGS are dropped due to misspelling >> >> https://cgit.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=942e8b555262a6e684ef69e96e0036e065fb8211#n23 >> >> We likely avoid doing exercises with tar in post-install >> sections? >> >> Please sort USES and make it a separate sections. >> >> I'm not sure if the claims on the page are still valid as >> >> ImageMagick7 >> >> appears to work fine as long as you set colorspace to sRGB during >> >> conversion. >> >> Best regards, >> >> Daniel > > Hi, > > Might also add that ffmpeg also seems to convert without any issues > > however the image is rotated 90 degrees. > > Best regards, > > Daniel Hi, Please respond otherwise this will likely be backed out as it doesn't work. Best regards, Daniel