From nobody Sun Jan 05 17:47:02 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YR4Wb55yNz5k1yw for ; Sun, 05 Jan 2025 17:47:07 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-1909.mail.infomaniak.ch (smtp-1909.mail.infomaniak.ch [IPv6:2001:1600:7:10::1909]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4YR4WZ6M4gz4G97 for ; Sun, 5 Jan 2025 17:47:06 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-4-0001.mail.infomaniak.ch (smtp-4-0001.mail.infomaniak.ch [10.7.10.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4YR4WV5Hm7zHRp; Sun, 5 Jan 2025 18:47:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1736099222; bh=qj1Mhmx8K/kcVeLtHLz9FIDHlomSuiwtMD7QJKanetg=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=h2URd4fvBWcvzWxOb6VtYsVoazQNnT6nJltoySff8rOVVkhba5RFfFBZrlgyp8RE9 4K6+gbu4bp7MRbJpeQgclYdl9tcnrHUVOr0Z7tYfrpXon2R2RudLlGKHk3ZRZPmhud oZ80NJJKxBB0dqP5d4kSFYabwuo/rIjR4gtQvwCCF8nBZTSCbKQYjZ66e8FLuK/nFy /6QkKDlOQHgKLhpbJPOjv1X1bAoLtxTeZOkZ58EdM77yy9NaYtxncPp7hXHIzsUY2K s7oC5TlPXGUWYV/LL1YB0v2FuhG+syteOl2jIM9E/cS5tgl5O7EbMfmNpGsE1lDXw9 k2fSTum4VOTXg== Received: from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4YR4WV2ks0zgtr; Sun, 5 Jan 2025 18:47:02 +0100 (CET) Message-ID: <5833df103504c8d1ced63548aacee4cc@mail.infomaniak.com> Date: Sun, 05 Jan 2025 18:47:02 +0100 Subject: Re: git: 942e8b555262 - main - graphics/pcdtojpeg: Converts PCD (Kodak Photo CD) image files From: Daniel Engberg Reply-To: Daniel Engberg To: Dirk Meyer Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1736099222_28ebcbf2e5b9e8e20eb212e68398cd1a_=_" X-WS-User-Origin: eyJpdiI6InZNRzB0aFVDblh2cCt1b2M4ayswMVE9PSIsInZhbHVlIjoiK3YxZWI0RE8wUjJCeElaQ2ZoRXZvQT09IiwibWFjIjoiNDk2ZWZlODZhNTNhZjVkZDgxZGFkZjgxZmVkZTM3MDYwNzA1NGQ1ODZhNjBmZDM3MmNhMTg5NzM4NzQ0ZmU5MyIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6IlZENWZMcTFDWW9oQ2ZpbUw5Y3dqK3c9PSIsInZhbHVlIjoiZ0tVSWl3RlRSOVA2U29wYVRndkxvZz09IiwibWFjIjoiZDAxY2FmYzU5N2Y3NDE0NTE4MzhkNmM3MzI5Nzg0NmM1NDNmZmYwM2VkNzJhMGM5ZThiYzQ1ZjU4YTUxNWNmZCIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.819) References: <202501051538.505FcMKp033044@gitrepo.freebsd.org> In-Reply-To: <202501051538.505FcMKp033044@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Rspamd-Queue-Id: 4YR4WZ6M4gz4G97 X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] --_=_swift_1736099222_28ebcbf2e5b9e8e20eb212e68398cd1a_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2025-01-05T16:38:28.000+01:00, Dirk Meyer wrote:= >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0dinoex: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org= /ports/commit/?id=3D942e8b555262a6e684ef69e96e0036e065fb8211 >=C2=A0 >= =C2=A0commit=C2=A0942e8b555262a6e684ef69e96e0036e065fb8211 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Dirk=C2=A0Meyer=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02025-01-05=C2=A015:38:11= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Dirk= =C2=A0Meyer=C2=A0 >=C2=A0 >=C2=A0CommitDate:=C2= =A02025-01-05=C2=A015:38:11=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0graphics/pcdtojpeg:=C2=A0Converts=C2=A0PCD=C2=A0(Kodak=C2=A0Pho= to=C2=A0CD)=C2=A0image=C2=A0files >=C2=A0 >=C2=A0--- >=C2=A0 >= =C2=A0=C2=A0graphics/Makefile=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A0=C2=A01=C2=A0+ >=C2=A0 >= =C2=A0=C2=A0graphics/pcdtojpeg/Makefile=C2=A0=C2=A0|=C2=A0=C2=A033=C2=A0+++= +++ >=C2=A0 >=C2=A0=C2=A0graphics/pcdtojpeg/distinfo=C2=A0=C2=A0|=C2= =A0=C2=A0=C2=A03=C2=A0+ >=C2=A0 >=C2=A0=C2=A0graphics/pcdtojpeg/pkg-des= cr=C2=A0|=C2=A0=C2=A0=C2=A03=C2=A0+ >=C2=A0 >=C2=A0=C2=A0graphics/pcdto= jpeg/pkg-plist=C2=A0|=C2=A0238=C2=A0+++++++++++++++++++++++++++++++++++++++= ++++ >=C2=A0 >=C2=A0=C2=A05=C2=A0files=C2=A0changed,=C2=A0278=C2=A0inse= rtions(+) Hi, Unfortunately this appears to be broken in multiple= ways. Resulting binary doesn't work (14.2-RELEASE on amd64): pcd= tojpeg BlownJohn.pcd BlownJohn-pcd-stock.jpeg Segmentation fault (core= dumped) pcdtojpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg S= egmentation fault (core dumped) pcdtojpeg -r 3 BlownJohn.pcd BlownJohn= -pcdtojpeg-5.jpg Segmentation fault (core dumped) pcdtojpeg -r 5 = BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg Warning: Could not open 64Base= IPE file while trying to process ICE file "/home/diizzy/patches-ups= tream/IPE/BlownJohn/64BASE/INFO.IC" Segmentation fault (core dumped)= While documentation is provided a note about this during install woul= d be helpful. Image source: https://sembiance.com/fileFormatSam= ples/image/pcd/ CXXFLAGS are dropped due to misspelling https://c= git.freebsd.org/ports/tree/graphics/pcdtojpeg/Makefile?id=3D942e8b555262a6e= 684ef69e96e0036e065fb8211#n23 We likely avoid doing exercises with tar= in post-install sections? Please sort USES and make it a separate sec= tions. I'm not sure if the claims on the page are still valid as Image= Magick7 appears to work fine as long as you set colorspace to sRGB during= conversion. Best regards, Daniel --_=_swift_1736099222_28ebcbf2e5b9e8e20eb212e68398cd1a_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2025-01-05T16:38:28.000+01:00, Dirk Meyer &= lt;dinoex@FreeBSD.org> wrote:
The branch main has been updated by dinoex:
=


=
AuthorDate: 2025-01-05 15:38:11 +0000
Commit:     Dirk Meyer =
<dinoex@=
FreeBSD.org>
CommitDate: 2025-01-05 15:38:11 +0000
=


    graphics/pcdtojpeg: Converts PCD (Kodak Photo=
 CD) image files
---
 graphics/Makefile        =
    |   1 +
 graphics/pcdtojpeg/Makefile  |  33 ++++++
 graphics/pcdtojpeg/distinfo  |   3 +
 graphics/pcdto=
jpeg/pkg-descr |   3 +
 graphics/pcdtojpeg/pkg-plist | 238 ++=
+++++++++++++++++++++++++++++++++++++++++
 5 files changed, 2=
78 insertions(+)

Hi,

Unfortunat= ely this appears to be broken in multiple ways.
<= br>
Resulting binary doesn't work (14.2-RELEASE on am= d64):

pcdtojpeg BlownJ= ohn.pcd BlownJohn-pcd-stock.jpeg
Segmentation fau= lt (core dumped)

pcdto= jpeg -r 4 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg
Segmentation fault (core dumped)

pcdtojpeg -r 3 BlownJohn.pcd BlownJohn-pcdtojpeg-5.jpg
Segmentation fault (core dumped)
pcdtojpeg -r 5 BlownJohn.pcd BlownJohn-pcdtojp= eg-5.jpg
Warning: Could not open 64Base IPE file<= br>
while trying to process ICE file "/home/diizzy/pa= tches-upstream/IPE/BlownJohn/64BASE/INFO.IC"
Segm= entation fault (core dumped)
While documentation = is provided a note about this during install would be helpful.

Image source:

CXXFLAGS are dropped due to misspelling

<= div style=3D"font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; f= ont-size: 14px">We likely avoid doing exercises with tar in post-install se= ctions?

Please sort US= ES and make it a separate sections.

I'm not sure if the claims on the page are still valid as Ima= geMagick7 appears to work fine as long as you set colorspace to sRGB during= conversion.

Best rega= rds,
Daniel
--_=_swift_1736099222_28ebcbf2e5b9e8e20eb212e68398cd1a_=_--