From nobody Mon Sep 30 16:02:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XHQpR65xGz5XHlw for ; Mon, 30 Sep 2024 16:03:11 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XHQpR5J5tz4cDh for ; Mon, 30 Sep 2024 16:03:11 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727712191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=41kKAmRQUBjaFiYrF81HrfGn4xLcQ9YLCPubZwWAZIA=; b=Yn3XYUVCo/z/O/2sXoRylDdBUnBX9x5mm9KyfhGuxoTAImbdG+/Dhb0Rtqa2RAjPzl/Q9p CH+I5X8ITNxD0iIMhbu7XaYeOL8SuP5O1oAAPcXZeeLp110bo13jyyYfJdZucQj9L/0avP RmzZR+Sl27dm9x7U7btZ4RAeifI4Y49OWRRHI10rm/ban5hOQjDOvmxbrk+XQI1NOyTYzh tLY6toPVbft71Baw9rgt4Z/LQUzuG9tidRoqbwsg9LzVZW7331YmqRJMMC3n7u2yxyuAMx FCxSk8lpb+XijZXfKEcSadUR323cA6EdPip6rnpHlwdqjZdo+fFre0+WmhlhSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1727712191; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=41kKAmRQUBjaFiYrF81HrfGn4xLcQ9YLCPubZwWAZIA=; b=ktiwbFhbGAyPLNVZjFZalZE8BCxMbW9FQA/I807zX7PVsBWtdFiTVWIFO/TY3DI2vJn+T2 mFibIHM0Mg8U8fGW4KiPlHQ49qPf8uZNKMuQm7mJNYzUqH5JFScC2CAnRZhI7+BRaWq9Pk DX7T9KVXtXAt+5afthpJk1Tgifj2CBwP8ckLc6lXNP+JZUYMQvTq+MljEIZDGgWAawOhWj j4ZgLxWEx6WFJYMOxr/ytINUzRQlnrwCKMmzkvC1GgpfmlvLidvOKbxwL/ASX6CnHn+XaV xFIES2v5WwdDOf50sfSf13RbjcFCmvt9A+jvL/EftTlI1G7S/tSb226MwKahWQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1727712191; a=rsa-sha256; cv=none; b=G4PitBq3drsJoAL2QUYxa8a1oNnxrrlqWlpL2xcL9rQtarTX32XlABazNvxk3A3YmrjjvV 3ekLqP5WmsQTsW32tgoKYDYVrZIh+Z+/UA0tuVUoVzBK3PekcYdbEMggGyY5tUjz/GQaJq 66VyeK0FPok+UpnTj/0/FyyWuaXk2lD6l6QJGrr+HL9hRwh267MdYri35c9D/Mo5mI2Mbd OoucrLu7Z58EqVkg3crihHvuOkzxcMOqAvKJVlAvybDBaHL1M6Zyb2KOe4a1SDdruRtXmq OvhBw600yVCkxHpDG9a4a5A4yeuwdez474+iosWoVsKGxvK1Il4QNUrRMxiM2w== Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XHQpR4nB1zNHP for ; Mon, 30 Sep 2024 16:03:11 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5c5bca6603aso5365875a12.1 for ; Mon, 30 Sep 2024 09:03:11 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWcFO4fBEMhT8XxSGKK4N5FaJjNku/sUaJACsC1dHdL7fr4lowncGIxNMNsdVSYwxJnE8tCch35wLWfqDlS9nQqrwSNSC30@freebsd.org X-Gm-Message-State: AOJu0Yxb1mZebeWfKBlnzk7G4IV+HxhOjtYd2q3WkG0kcHJ7P1I7fgq5 duprcDEeNbaO+O7rjgDFquRjyc6tYaR53n/xNQxJu1EQPunO6yTR9aAiudz1LNb0CPnitvwpjM7 P7ybFFa7iXhk7/JedEBwA9Fv5KCH/vHUTv45FgA== X-Google-Smtp-Source: AGHT+IEsdzoPIvn/AGq4HkJz4WUvBowTzEjdOXExOUqgkjvn9mQ13KZBfcjKE4/m5ePCPw+xpE17Ulp0xzTCx8kSmVw= X-Received: by 2002:a05:6402:34d2:b0:5c8:821b:b7a9 with SMTP id 4fb4d7f45d1cf-5c8824cc66cmr9210269a12.6.1727712190526; Mon, 30 Sep 2024 09:03:10 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202409180619.48I6J0G7032519@gitrepo.freebsd.org> In-Reply-To: From: Po-Chuan Hsieh Date: Tue, 1 Oct 2024 00:02:34 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: c41e1ace8e98 - main - ftp/curl: Add LIBUV option To: Adam Weinberger Cc: ports-committers , dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000641d150623585731" --000000000000641d150623585731 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 29, 2024 at 3:36=E2=80=AFAM Po-Chuan Hsieh wrote: > On Thu, Sep 19, 2024 at 11:10=E2=80=AFAM Adam Weinberger wrote: > >> On Wed, Sep 18, 2024 at 2:19=E2=80=AFAM Po-Chuan Hsieh >> wrote: >> >>> The branch main has been updated by sunpoet: >>> >>> URL: >>> https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa0= 461aa098182e0 >>> >>> commit c41e1ace8e986493e3fc0b22fa0461aa098182e0 >>> Author: Po-Chuan Hsieh >>> AuthorDate: 2024-09-18 05:55:59 +0000 >>> Commit: Po-Chuan Hsieh >>> CommitDate: 2024-09-18 06:13:08 +0000 >>> >>> ftp/curl: Add LIBUV option >>> --- >>> ftp/curl/Makefile | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile >>> index 0eebfd2224dd..8bacab43595b 100644 >>> --- a/ftp/curl/Makefile >>> +++ b/ftp/curl/Makefile >>> @@ -41,7 +41,7 @@ CPE_VENDOR=3D haxx >>> >>> SHEBANG_FILES=3D */*.pl >>> >>> -OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >>> EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD >>> +OPTIONS_DEFINE=3D ALTSVC BROTLI COOKIES CURL_DEBUG DEBUG DOCS >>> EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD >>> OPTIONS_GROUP=3D PROTOCOL >>> OPTIONS_RADIO=3D SSL >>> OPTIONS_SINGLE=3D GSSAPI RESOLV >>> @@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D libssh >>> LIBSSH_LIB_DEPENDS=3D libssh.so:security/libssh >>> LIBSSH2_CONFIGURE_WITH=3D libssh2 >>> LIBSSH2_LIB_DEPENDS=3D libssh2.so:security/libssh2 >>> +LIBUV_CONFIGURE_WITH=3D libuv >>> +LIBUV_LIB_DEPENDS=3D libuv.so:devel/libuv >>> MQTT_CONFIGURE_ENABLE=3D mqtt >>> NTLM_CONFIGURE_ENABLE=3D ntlm >>> OPENSSL_CONFIGURE_ON=3D --with-ca-fallback >>> >> >> Hi, Po-Chuan! >> >> There's no description for this new LIBUV option, so I was unclear what >> libuv did for Curl. In upstream's configure.ac, it has this: >> >> dnl ********************************************************************= ** >> dnl libuv is only ever used for debug purposes >> dnl ********************************************************************= ** >> >> ... >> >> if test X"$want_libuv" !=3D Xno; then >> if test x$want_debug !=3D xyes; then >> AC_MSG_ERROR([Using libuv without debug support enabled is useless]) >> fi >> >> So, the LIBUV option *must* be used with the DEBUG option. If linking >> against libuv is going to be important for end-users, we probably want >> LIBUV_IMPLIES=3DDEBUG. >> >> # Adam >> > > Hello Adam, > > Thanks for taking care of this option. > I have added the missing LIBUV_DESC earlier. > It is not useful for normal users since it is for testing. Therefore I di= d > not enable it by default. > I'll add "LIBUV_IMPLIES=3DDEBUG" later. > Thanks. > > Best regards, > sunpoet > Committed in ports 8e83a22df5a95829c7213650a90e3b26d79d39d4. Thanks. --000000000000641d150623585731 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Sep 29, 2024 at 3:36=E2=80=AFAM P= o-Chuan Hsieh <sunpoet@freebsd.or= g> wrote:
On Thu, Sep 19, 2024 at 11:10=E2=80=AFAM Adam Weinber= ger <adamw@adamw.org> wrote:
On Wed, Sep 18, 2024 at 2= :19=E2=80=AFAM Po-Chuan Hsieh <sunpoet@freebsd.org> wrote:
=
The branch main has been updated by sunpoet:

URL: = https://cgit.FreeBSD.org/ports/commit/?id=3Dc41e1ace8e986493e3fc0b22fa0461a= a098182e0

commit c41e1ace8e986493e3fc0b22fa0461aa098182e0
Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
AuthorDate: 2024-09-18 05:55:59 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org>
CommitDate: 2024-09-18 06:13:08 +0000

=C2=A0 =C2=A0 ftp/curl: Add LIBUV option
---
=C2=A0ftp/curl/Makefile | 4 +++-
=C2=A01 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ftp/curl/Makefile b/ftp/curl/Makefile
index 0eebfd2224dd..8bacab43595b 100644
--- a/ftp/curl/Makefile
+++ b/ftp/curl/Makefile
@@ -41,7 +41,7 @@ CPE_VENDOR=3D=C2=A0 =C2=A0haxx

=C2=A0SHEBANG_FILES=3D */*.pl

-OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 NTLM PROXY PSL STATIC TLS_SRP ZSTD
+OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ALTSVC BROTLI COOKIES CURL_DE= BUG DEBUG DOCS EXAMPLES IDN IPV6 LIBUV NTLM PROXY PSL STATIC TLS_SRP ZSTD =C2=A0OPTIONS_GROUP=3D PROTOCOL
=C2=A0OPTIONS_RADIO=3D SSL
=C2=A0OPTIONS_SINGLE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 GSSAPI RESOLV
@@ -123,6 +123,8 @@ LIBSSH_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 libssh
=C2=A0LIBSSH_LIB_DEPENDS=3D=C2=A0 =C2=A0 libssh.so:security/libssh
=C2=A0LIBSSH2_CONFIGURE_WITH=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 libssh2
=C2=A0LIBSSH2_LIB_DEPENDS=3D=C2=A0 =C2=A0libssh2.so:security/libssh2
+LIBUV_CONFIGURE_WITH=3D=C2=A0 libuv
+LIBUV_LIB_DEPENDS=3D=C2=A0 =C2=A0 =C2=A0libuv.so:devel/libuv
=C2=A0MQTT_CONFIGURE_ENABLE=3D mqtt
=C2=A0NTLM_CONFIGURE_ENABLE=3D ntlm
=C2=A0OPENSSL_CONFIGURE_ON=3D=C2=A0 --with-ca-fallback

Hi, Po-Chuan!

There's no description = for this new LIBUV option, so I was unclear what libuv did for Curl. In ups= tream's configure.ac, it has this:

dnl ******= ****************************************************************
dnl lib= uv is only ever used for debug purposes
dnl ****************************= ******************************************

...

if= test X"$want_libuv" !=3D Xno; then
=C2=A0 if test x$want_debu= g !=3D xyes; then
=C2=A0 =C2=A0 AC_MSG_ERROR([Using libuv without debug = support enabled is useless])
=C2=A0 fi

So, t= he LIBUV option *must* be used with the DEBUG option. If linking against li= buv is going to be important for end-users, we probably want LIBUV_IMPLIES= =3DDEBUG.

# Adam
=

Hello Adam,

Thanks for taking = care of this option.
I have added the missing LIBUV_DESC earlier.=
It is not useful for normal users since it is for testing. T= herefore I did not enable it by default.
I'll add "LIBUV_IMPLIES=3DDEBUG" later.<= /span>
Thanks.

Best regards,
sunpoet

Committed in ports=C2= =A08e83a22df5a95829c7213650a90e3b26d79d39d4.
Thanks.=C2=A0
<= /div> --000000000000641d150623585731--