From nobody Thu Sep 19 12:50:26 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8b3Z2C31z5WWdP; Thu, 19 Sep 2024 12:50:50 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8b3Z1m5tz4ndp; Thu, 19 Sep 2024 12:50:50 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726750250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MSuaLPurMovbSCeUpHvSdvrgT/zq2MBU0berWsu3quU=; b=sfUt/HIk1N5OJdGdqmBuObZBzz8FzSqB7Ex7GKYYykoXG9KI/zOjNaCyYmez7Q0Z3sPSjY /3rXjx/CLzzAWXadaAGWwqOoZ6aSs0aFVhOZ3SrTFIeNWv2W6WF50ELT6OCYasW+9gPtpk T4/XEu5v1F9SbgCExWxIu/UfaRcZR6qQ2w3uzE2bzBU+YEsWYlNu67Zj3khi3AfnVvb4fg PVEHGVfUzYYoXgVgZ6sJvJGIiE9jHLbS2ZbsZPedI/f22F7qAUJg6GhCareukVN/OniK6U nafZKh2/LRUAxOjAmQOrUQC25mk4+Xpmvf4VmAi7jVPyr74yN8wXeWCIYlZHAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726750250; a=rsa-sha256; cv=none; b=HZmHMdDTBYzSvBAwZkxP2cNPt/x9aBe4s1RarUsVucW6wYAEZh7XzOXsi9nPaZmCYTyP+f a/I0YFy22cptUoxMnOdCCfUoHjHyroto/BCWIk/NZpv3QZyJNDdkPlmt/tBx+srQhemUD9 1RbE3X4N8StKydUGETHN6i1P3YUHpNUeuHsqQu/xPtshJDiLu9faxbsw7sN99kul0m6Rdw mBO2mMgSlwMa4g4vVSzptZvSe2IaWJrelmcWd8kJvHt9Oc4weZLbBqkfTH83RPv3BDZA5S sLlFofOmWKJmqf6LXRxTGx5XN/L6q2fqeLZRotPW9YVvUXY4/YPtzaNOrKkgJA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726750250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MSuaLPurMovbSCeUpHvSdvrgT/zq2MBU0berWsu3quU=; b=fle33HrlO3fqhH17NaSQzEefLVuUF8gjlQh1GonyfISHYos73n3OxNssNPRNr+zZ83JEJz b6QvHqI8DkSYcGseTcf2G2pfpsBWDNSWrg8hi68gp55VW8sOrpK/i5KWDM3Ev4zy6x8EPk Hc2YNYsG5RZBRGKeVE883vr8Djl61KF3SeYZxHkQ7B+/XOACyp2J3j2KhIqIagLespnsPF YAyJLhoWzVrz4LZ4KCOQ+FiZ1QfYpsB6ag44W35A11qanorL3xAULzad1aWetKmFKiJBeh 9piXTcQNR/HBhV8NnY6WObglRd0y7WJn+XYYfrWajbARWRgsck7oZ3XSGFec5Q== Received: from relay.mat.cc (eqx1.mat.cc [79.143.244.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R10" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4X8b3Z0hHcz10Sd; Thu, 19 Sep 2024 12:50:50 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [193.1.168.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 6FCED20E6B; Thu, 19 Sep 2024 14:50:46 +0200 (CEST) Date: Thu, 19 Sep 2024 14:50:26 +0200 From: Mathieu Arnold To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 06790548d500 - main - Mk/bsd.sites.mk: don't add GH to MASTER_SITES when USE_GITHUB=nodefault Message-ID: <3vukih75nbcwsoimkbm6c2apwfg6pggytz3vmghxairyaxnhe3@5dnyba45gxps> References: <202409191246.48JCkuU8064953@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sb56tbrkzsudtz2c" Content-Disposition: inline In-Reply-To: <202409191246.48JCkuU8064953@gitrepo.freebsd.org> --sb56tbrkzsudtz2c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Sorry about the mess, I redid the commit with correct attribution and PR number. On Thu, Sep 19, 2024 at 12:46:56PM GMT, Mathieu Arnold wrote: > The branch main has been updated by mat: >=20 > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D06790548d50075cc2e2cfff4= fe0811a561402cec >=20 > commit 06790548d50075cc2e2cfff4fe0811a561402cec > Author: Mathieu Arnold > AuthorDate: 2024-09-19 12:26:24 +0000 > Commit: Mathieu Arnold > CommitDate: 2024-09-19 12:46:35 +0000 >=20 > Mk/bsd.sites.mk: don't add GH to MASTER_SITES when USE_GITHUB=3Dnodef= ault > =20 > When using USE_GITHUB=3Dnodefault, we don't need to add GH to > MASTER_SITES, as the github urls that are needed will be added later. > =20 > Adding GH here means we'll add a generic GitHub URL to the fetch list, > in the form of github.com///.../ which will > not work. When used with USE_GITLAB the framework will add this bogus > URL before the correct gitlab url. It does not prevent the distfile to > be fetched from gitlab, but it makes everyone try and fetch from a bo= gus > url before trying the correct url. > --- > Mk/bsd.sites.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Mk/bsd.sites.mk b/Mk/bsd.sites.mk > index e34fbb846144..5fffe2e64865 100644 > --- a/Mk/bsd.sites.mk > +++ b/Mk/bsd.sites.mk > @@ -294,7 +294,7 @@ GH_SUBDIR+=3D ${GH_TUPLE:C@^([^:]*):([^:]*):([^:]*)((= :[^:/]*)?)((/.*)?)@\6\4@:M/*: > MASTER_SITE_GITHUB+=3D https://codeload.github.com/%SUBDIR% > MASTER_SITE_GITHUB_CLOUD+=3D https://cloud.github.com/downloads/%SUBDIR% > =20 > -. if !defined(MASTER_SITES) || !${MASTER_SITES:MGH} && !${MASTER_SITE= S:MGHC} && !${USE_GITHUB:Mnodefault} > +. if ( !defined(MASTER_SITES) || !${MASTER_SITES:MGH} && !${MASTER_SI= TES:MGHC} ) && !${USE_GITHUB:Mnodefault} > MASTER_SITES+=3D GH > . endif > GH_ACCOUNT_DEFAULT=3D ${PORTNAME} --=20 Mathieu Arnold --sb56tbrkzsudtz2c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmbsHhJfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb68Rgv/Y9RkeAd2OuQKdKmJ3qE0wxTimYcXfGaRPww+JkjYfkxwbYQhXAPefgAI Dm/uJthoPiaUWRKy1qqHNGV1rjLgm6FQYcG8fm5RiSkHytvoamXSvOWftYyjwiJi jY2n3Z01+LvhMBpX+kS4UVIVTsIl+kjlHmhcsnUiyc7fY6lrhTFnQm/AmdCrYcZ/ 8Fj5oS1VXhFCIm+Z/CrAl9bNrKRBjQK5E0GxAGijvazfHnXJf0KBRlPGgmgBW/IR Lc7jebqYnojdFYYWlAkIpKrgttp4mPMdOc2E8e9W96MywCIyYWEUsN9YD+dwkWaA nQskS0w6a+j3d41sMRBM3VHulxIJDEscJ+hiV0/KdW/03Dax60UC6JYi/DXkS9zA VxlODZye3JuecMr8aD/YC4jlpDT4fNVoJZoTFB1XKC4a5RF31ZEXjvxbx8Q0eOEi 882+F0Vyg04ZW9qlpwwByegqemXXzuHuTD69s+v2V0SyeXV2O+edjb+F7A9ooJ5B OH1AVHxv =dDm9 -----END PGP SIGNATURE----- --sb56tbrkzsudtz2c--