Re: git: 6b2b6fc90d27 - main - www/nghttp2: Update to 1.63.0

On Wed, Sep 11, 2024 at 3:06 PM Daniel Engberg
<daniel.engberg.lists@pyret.net> wrote:
>
> On 2024-09-09T11:34:49.000+02:00, Jason E. Hale <jhale@freebsd.org> wrote:
>
> On Sun, Sep 8, 2024 at 8:27 PM Daniel Engberg
> <daniel.engberg.lists@pyret.net> wrote:
>
>
>  On 2024-09-08T20:42:46.000+02:00, Po-Chuan Hsieh <sunpoet@FreeBSD.org> wrote:
>
>
>  The branch main has been updated by sunpoet:
>
>  URL: https://cgit.FreeBSD.org/ports/commit/?id=6b2b6fc90d270c590a53a6c84ca1df897bf95e7c
>
>  commit 6b2b6fc90d270c590a53a6c84ca1df897bf95e7c
>  Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>  AuthorDate: 2024-09-08 18:17:14 +0000
>  Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
>  CommitDate: 2024-09-08 18:37:04 +0000
>
>      www/nghttp2: Update to 1.63.0
>
>
>
>
>  Hi,
>
>  Both USES= compiler:c++20-lang and USE_CXXSTD= c++20 can be removed as no c++ code is compiled.
>
>  Best regards,
>  Daniel
>
>
> All of the .cc files in ${WRKSRC}/src beg to differ.
>
> - Jason
>
> Hi,
>
> They're not compiled for the library at least according to the build log(s). :-)
>
> CMake build:
> https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h00m21s/logs/libnghttp2-1.63.0.log
>
> Autotools:
> https://pdr2.bofh.network/data/141-diizzy/2024-09-11_14h03m47s/logs/libnghttp2-1.63.0.log
>
> Best regards,
> Daniel

True, but this commit wasn't for the library, so in that context, your
critique seemed strange to me.

- Jason