From nobody Wed Sep 11 11:25:13 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X3dXk0GKJz5WSSx; Wed, 11 Sep 2024 11:25:26 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X3dXj2TkXz4ch9; Wed, 11 Sep 2024 11:25:25 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vs1-f43.google.com with SMTP id ada2fe7eead31-49bd40d77e5so2002554137.0; Wed, 11 Sep 2024 04:25:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726053924; x=1726658724; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wqB0xKMLL4Bpt2+aTQHY5INcPGTdIc+DMRm1PHgMy5Y=; b=nN6TxShQISknTv0f+WW+L5RE7nPz6DW8ZM3ub6ZG4e9PHUFMhSsKDIynHuyrBJ0Qx9 S5BW+JeWj1fFQ3EsKbrginVLKwYAHpeBCMLBfsCqltEg6fM1TwN9gRTxMj1R6Zva/uSU Ns75RqTEaAprPEJKjcQL6ilU8YbjXS2cZ8Z8EVfKXZsQatEiahXvMNOL+zxxzo6u3+od AD2nEkAsz2gWTxQLhVZawQ9GyNgKFgdIOwUuBCCfz6tqWuEw32yJct835nDVDLu/mWSy Hgh64HpF/Jx9WwWIqQ/icXWOmS+sI3BHxVUIV5vSBxsMmgTiJ+e5dF2QWKm+hN00iNk6 ZdSA== X-Forwarded-Encrypted: i=1; AJvYcCV7YS/Ly8WxLACGuCqfgpJQ84sSDrw009reS5jC4HTiso97T/KPATC/1ob4S8H3CsjGmeOZtS7ZX5TwR0qCqXw9vA==@freebsd.org, AJvYcCVOyj+i6MY6Uw2CZqhAME7WbDIQxyhrvNPWmAXIyFxulBDuLU054S0Gpn36Va5KJ54JDvkqw86oynovoqsC9pilHo1p4wwNeg==@freebsd.org, AJvYcCWBY2I0GlrnPFIPuTg63imtsCqhBP2QKa0VLYsZBuE184UqXL3EO7UHT83KAmebTQ1IyfiCIq+KQhLgZGXxag8b9EGujfM=@freebsd.org X-Gm-Message-State: AOJu0Yw1eey/Xa8bTpLdeQFJpA7YioMMuclv2kCho6y0EdcjeqJ3h+0T TtHxZLAzlmNbKlzoqjBvkd2KtWGzglLI296g1VHZDitcPNfMSC9yx5rOzoMnAdCzAo3aibFjdda RBxxDe6OnDYIJqkz+O4KP309Q5ijPVA== X-Google-Smtp-Source: AGHT+IFb6iAVPBg8Y0RJ23VjtjfMiFDBVWBmoBx+sv/pXQeUn9mrUHMqxWltW2RaXDfk3Ve6tSFB9616lHprSltqg6Y= X-Received: by 2002:a05:6102:510b:b0:492:876e:6d15 with SMTP id ada2fe7eead31-49bde1957fbmr19288459137.8.1726053924062; Wed, 11 Sep 2024 04:25:24 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202409110621.48B6LPQZ065287@gitrepo.freebsd.org> In-Reply-To: From: "Jason E. Hale" Date: Wed, 11 Sep 2024 07:25:13 -0400 Message-ID: Subject: Re: git: a53a752a3565 - main - www/rubygem-json-jwt115: Remove expired port To: Alexey Dokuchaev Cc: Matthias Fechner , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4X3dXj2TkXz4ch9 On Wed, Sep 11, 2024 at 2:24=E2=80=AFAM Alexey Dokuchaev wrote: > > On Wed, Sep 11, 2024 at 06:21:25AM +0000, Matthias Fechner wrote: > > commit a53a752a35654ecd756ca11c46c0d56944bb0cfc > > > > www/rubygem-json-jwt115: Remove expired port > > > > www/rubygem-json-jwt115 > > I keep seeing this silly useless extra line with nothing else but the > portname added to the commit log, what's the purpose of it? If this > is due to some broken port removal script, can someone please fix it? > > ./danfe This is definitely from Tools/scripts/rmport, which seems to be more focused on the bulk removal of expired ports rather than on the removal of individual non-expired ports for other reasons. This port, for example, didn't have EXPIRATION_DATE set, but the generated commit message suggests that it was expired, which is a problem in and of itself. The rmport script just assumes the port is expired and doesn't do any checks to verify whether that is actually the case for the main commit message. The generated MOVED entry is slightly more bespoke, which leads me to believe that the MOVED entry in this case was manually edited. I don't use rmport for individual ports (or really ever because it requires me to edit it to even use it due to my git remotes settings not matching up to what it expects, but if these extra lines in commit messages bother you that much, here's your starting point to make the change you want to see. It would be wise to consult with our esteemed Grim Reaper (rene@) before committing any changes, though. - Jason