Re: git: f71ee5b13c08 - main - Uses/electronfix.mk: Replace .error with .warning to unbreak make describe
- Reply: Gleb Popov : "Re: git: f71ee5b13c08 - main - Uses/electronfix.mk: Replace .error with .warning to unbreak make describe"
- In reply to: Gleb Popov : "git: f71ee5b13c08 - main - Uses/electronfix.mk: Replace .error with .warning to unbreak make describe"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 04 Sep 2024 09:34:30 UTC
On Wed, Sep 04, 2024 at 09:03:29AM GMT, Gleb Popov wrote: > The branch main has been updated by arrowd: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=f71ee5b13c081f8924986ba52a32396c87138f99 > > commit f71ee5b13c081f8924986ba52a32396c87138f99 > Author: Gleb Popov <arrowd@FreeBSD.org> > AuthorDate: 2024-09-04 09:02:03 +0000 > Commit: Gleb Popov <arrowd@FreeBSD.org> > CommitDate: 2024-09-04 09:03:08 +0000 > > Uses/electronfix.mk: Replace .error with .warning to unbreak make describe > > Reported by: Tomoaki AOKI <junchoon@dec.sakura.ne.jp> > --- > Mk/Uses/electronfix.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Mk/Uses/electronfix.mk b/Mk/Uses/electronfix.mk > index f5e33da516cb..534321ae56ca 100644 > --- a/Mk/Uses/electronfix.mk > +++ b/Mk/Uses/electronfix.mk > @@ -24,7 +24,7 @@ _INCLUDE_USES_ELECTRONFIX_MK= yes > _ELECTRON_MAKEFILE_VERSION= ${.CURDIR}/../../devel/electron${electronfix_ARGS}/Makefile.version > > . if !exists(${_ELECTRON_MAKEFILE_VERSION}) > -. error Unknown Electron version in USES=electronfix:${electronfix_ARGS} > +. warning Unknown Electron version in USES=electronfix:${electronfix_ARGS} > . endif > > BUILD_DEPENDS+= electron${electronfix_ARGS}:devel/electron${electronfix_ARGS} This makes little sense, the .error was there to stop whatever was being done because it's wrong, now it only warns and then goes further and breaks INDEX. Put back the .error and fix the port(s) that are wrong. -- Mathieu Arnold