From nobody Tue Oct 29 12:59:16 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xd9Lv39X2z5bRQf; Tue, 29 Oct 2024 12:59:19 +0000 (UTC) (envelope-from SRS0=bjOz=RZ=klop.ws=ronald-lists@realworks.nl) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [194.109.157.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xd9Lv0zZwz465d; Tue, 29 Oct 2024 12:59:19 +0000 (UTC) (envelope-from SRS0=bjOz=RZ=klop.ws=ronald-lists@realworks.nl) Authentication-Results: mx1.freebsd.org; none Date: Tue, 29 Oct 2024 13:59:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1730206757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i8+w6E5mfQKfC0mqbWSsuuAZTMGnloxMfM39IA/MsOU=; b=ai0HRimto/EvfDaeP9cgx3bbAOO2xf998PuR7OIAAlNs8hPh2qgsHZMVUKKpwaP758W2rj IpqdhF9BsmlhKFVni4ygWuGpdpjqlsf1/I9bf9jU3SiH4VESaAiGhVDEM1SweOA1cQxSGu XyB4Yo/B/xzoU27EgE8OKGUJwjh60TsOtwndM3zzzf+oWbXUj7HHfdublPUL5aXbj6Qj37 g2s3uRsr7blEfoTGAUTDwcxwDwZ3WWZqUzcGN8iv1OC4enU6BM7AtmiLK0lpBNFLhb63fa a5XyOxGSOIRcanKSyVytF4ru8YupiRLBOe3YMru8qctY5bUQX8wO5qvajMZBEA== From: Ronald Klop To: Gleb Popov Cc: dev-commits-ports-main@freebsd.org, dev-commits-ports-all@freebsd.org, Ronald Klop , ports-committers@freebsd.org Message-ID: <295785305.2951.1730206756944@localhost> In-Reply-To: References: <202410290752.49T7qQ8l003743@gitrepo.freebsd.org> Subject: Re: git: abe39441c2c5 - main - databases/mongodb50: stick to <= llvm18 on FreeBSD 15 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_2950_902152429.1730206756772" X-Mailer: Realworks (725.75) Importance: Normal X-Priority: 3 (Normal) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL] X-Rspamd-Queue-Id: 4Xd9Lv0zZwz465d X-Spamd-Bar: ---- ------=_Part_2950_902152429.1730206756772 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Van: Gleb Popov Datum: dinsdag, 29 oktober 2024 13:39 Aan: Ronald Klop CC: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Onderwerp: Re: git: abe39441c2c5 - main - databases/mongodb50: stick to <= llvm18 on FreeBSD 15 > > On Tue, Oct 29, 2024 at 10:52AM Ronald Klop wrote: > > > > +.if ${OPSYS} == FreeBSD && (${OSREL:R} >= 15 && ${OSVERSION} >= 1500026) > > Checking for both OSREL and OSVERSION seems strange to me. Or am I > missing something? I agree. Just based my code on examples in the ports tree. Incidentally I'm currently testing a similar fix for mongodb60 in which I already removed the OSREL clause. Regards, Ronald. ------=_Part_2950_902152429.1730206756772 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit  

Van: Gleb Popov <arrowd@freebsd.org>
Datum: dinsdag, 29 oktober 2024 13:39
Aan: Ronald Klop <ronald@freebsd.org>
CC: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Onderwerp: Re: git: abe39441c2c5 - main - databases/mongodb50: stick to <= llvm18 on FreeBSD 15

On Tue, Oct 29, 2024 at 10:52AM Ronald Klop <ronald@freebsd.org> wrote:
>
> +.if ${OPSYS} == FreeBSD && (${OSREL:R} >= 15 && ${OSVERSION} >= 1500026)

Checking for  both OSREL and OSVERSION seems strange to me. Or am I
missing something?


I agree. Just based my code on examples in the ports tree.
Incidentally I'm currently testing a similar fix for mongodb60 in which I already removed the OSREL clause.

Regards,
Ronald.
  ------=_Part_2950_902152429.1730206756772--