From nobody Thu Oct 17 19:32:01 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XTydZ0jvtz5ZP9j; Thu, 17 Oct 2024 19:32:02 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XTydZ0K0Dz4dZ4; Thu, 17 Oct 2024 19:32:02 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729193522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7VwHQczDF2x1zNkWD6Agfl1s+5HywFkeayE/e+Jax0M=; b=PjmCP5+buIBFGQxuVLihpdDiVPTn1N8dwDaKs6aiJGnUeMutzvzTBx8teAsmaZdVOlkojf L7zDAuRIakHIxLCas6Y6X8TrjYIldKu41lKC0K0gsI2o2Xwyca5WJhk3aKosnfR84rzmUX fyCyK4SYczDP3Fiat8fpSCv9JqOwFuUW1l5aoKrKIYxwKTMskTtK1cbVqRCH+nK4juR4kY xG0e6qPQIxjluOQRCnR99H0BoEmPGQ0n3LVsvuI5Sp6uSpPim+p6n3IyMG/bQDjBW8pCia 4DWRZGWwlFXeitM9HX5eY5DWlrgsc5badk8A6PJYiC898pN5DGJV4dZtmusdeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1729193522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7VwHQczDF2x1zNkWD6Agfl1s+5HywFkeayE/e+Jax0M=; b=JwtEIf143W+cxGImt5XnhwQJE6KIQil0zVJb01+6JZd2X+8tgM+ukND2FhmmPxPzDDTove N/LRLFNwaeS+38WUyAV+EHohRKbWZLpLuNzlkmF5IXcT3C5xQTSYT7mUdpMZ7UBIKAyfaK qMwqCGjmYP9NxfANsiy8SofmVKVroSgW407fg3Q8kfZuGzXnPGugXSJHJ3oovU4XgRw9hr CbhUiUDZlVo2vHNUqBGwsuU3hTqcpJMMZj7ow4jmcoQThqNujqVXg+SocLHFd3MuAvwaoV Vt7jSKi6XuLfiuU4e99Fe0pOAa37daMccaKhx+9ysczbWF/1dfKmxkS6a0jNRg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1729193522; a=rsa-sha256; cv=none; b=FLkcsxhMedGeuT7kV9+P4eIWEM4uiIVVFE5H3v968JjoXVMyknzUlnvvvhAO8vXibjGJfF 5vhzaZX7MqX8HsUKHsCAHfmGXQEmSsccpWj6QBLzBAvZIz63n5e4KbBgCOW+7IlceegF6/ hL5MtWpV6FjWT7YnXMucD33FJkeg2wekvKa9BeD6HJ1oWEz85MiZycL98gmLq5ExMDXLUI 2FmnIlRjkU2el0MNSfl0OwvrkNdb1nCc/9lUx9nBEk+n28K0g5fr8slOqMxLMRPaYtDiOy MAeX3dDw+IDXOvl04sCQO+JpnjotFfuLePbP00BoKW6rotlxieH0iX3X8jCoOA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XTydY72zwz12m0; Thu, 17 Oct 2024 19:32:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 49HJW1N6042552; Thu, 17 Oct 2024 19:32:01 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 49HJW1nA042549; Thu, 17 Oct 2024 19:32:01 GMT (envelope-from git) Date: Thu, 17 Oct 2024 19:32:01 GMT Message-Id: <202410171932.49HJW1nA042549@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Chris Rees Subject: git: 38dbaaa03aa5 - main - audio/oss: Build fix for clang 19 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: crees X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 38dbaaa03aa58861e78dafb674e3e2ed5b7eda7c Auto-Submitted: auto-generated The branch main has been updated by crees: URL: https://cgit.FreeBSD.org/ports/commit/?id=38dbaaa03aa58861e78dafb674e3e2ed5b7eda7c commit 38dbaaa03aa58861e78dafb674e3e2ed5b7eda7c Author: Chris Rees AuthorDate: 2024-10-17 19:29:33 +0000 Commit: Chris Rees CommitDate: 2024-10-17 19:31:52 +0000 audio/oss: Build fix for clang 19 PR: ports/282164 Thanks to: dim --- .../patch-kernel_framework_sndstat_oss__sndstat.c | 26 ++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c b/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c new file mode 100644 index 000000000000..bafb1f61a2f3 --- /dev/null +++ b/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c @@ -0,0 +1,26 @@ +Thanks to dim@ + +Clang 19 has become more strict about erroneous redeclarations, which +results in an error building audio/oss: + + oss_sndstat.c:114:17: error: redeclaration of 'version' with a different type: 'char[]' vs 'const char[]' + 114 | extern char version[]; + | ^ + /usr/include/sys/systm.h:54:19: note: previous declaration is here + 54 | extern const char version[]; /* system version */ + | ^ + +Since version[] has been a const char for quite a while now, adjust the +redeclaration in oss_sndstat.c. Note that it also might be deleted +entirely, since the file already includes . + +--- kernel/framework/sndstat/oss_sndstat.c.orig 2024-10-17 19:27:09 UTC ++++ kernel/framework/sndstat/oss_sndstat.c +@@ -111,7 +111,6 @@ init_status (void) + #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__) + { + #if defined(__FreeBSD__) +- extern char version[]; + #endif + + put_status ("Kernel: ");