From nobody Tue Oct 08 09:32:57 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XN9mj1JhKz5ZCtp; Tue, 08 Oct 2024 09:33:09 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XN9mj0mXLz4KtZ; Tue, 8 Oct 2024 09:33:09 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728379989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aT/itRlKcly4XBLJDq0YZxVQUOhr/yWoL5jTA7jFJHU=; b=WW4RM44Zylu6NT+yzeTVk3Jcy23JWlD4SD4hxmmMGM8lhAFjtcWf6fG59PeZnf4lARSHYh T+EL0pLm+OBmhVR+7oypQiJnJk+3MjG948w00Un08D0jo2gmrTorW+QxqXj9VIqjcdVoud aJ3LMFnGQ5usuykw4BMqMIcfRrcB9kGeE37xa1Tb3XLQnzVpbTzD03l3ZB9JhfCWUsDvAw KrKq/cbsXr8eomo7z8Q3FmJ4QTzsM0aHe1f4ZoLPL4Rz6SB480JMNk3Y2L8OclMb3sQB9v n55ExYd7QMzXfNtOKh8eVopigTLcpB1r0/F2X2+XH3JhrYKwRd9yVVS4wZwMXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728379989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aT/itRlKcly4XBLJDq0YZxVQUOhr/yWoL5jTA7jFJHU=; b=jWNfJU9WlwBCljLOWDztMiTfXY+B3+iR+NTjAW7/8HJLqtl3G3X4geNmaST1hemukNtS15 WTPVJoCP7DS5rIgUWij50K+GKnGganDsr60vtY8WuKRStoDB/ZarqcepsnJdIeqmx/TTjl 4Phwm811Nz8EHqYO7Aer7NSzqyqWH4H/k/Q+8UMYA7mqapAUMj4d/pjVcRuwPSWD7MsxTc Prqvixc8npkRmWIK9rlXgXjCPIS1euX6LBN1ksS9kNHBjXrgtHMluMI91jHUeMW/Ll/uL9 ExY8otaEedxd+cNVoWjfBMIZTGUznMC/rXfQx6H/99mrWIoiHbVxxpwoFmmapg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728379989; a=rsa-sha256; cv=none; b=tLHoSr6xUuVAdicw9Zak5meKmHQGICkMQZ84hDP1EQpzx1pfUoFbibAEoDQ8d7y5QGqAh2 z16LC2c4DpHpvs5tpagrPelFw+kSOTT/44dh71eN1r4XJnl+JOmGeF/37gTernNjqh3n8O XNqTw8v3NOtNZupfiyJv1IIV3NdHyR1L3sDvM1wGX1nd7qef6uKXJQnD6dSaLzvZNANgwy 40fzVTMPd+ryJRjsfh8kv6FULheTRVjx4KD/2fjE8DgdbgSfdOH9d0frK/8PxWiIdSi8Vz uGweEUcUsaT0os4LBf0oLriX5koJ2dXKuUOsOSxN8aPbyhZi7ULZacJ4ypFCrw== Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XN9mj0FHyzJQ4; Tue, 8 Oct 2024 09:33:09 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6cb21f041c8so6103506d6.3; Tue, 08 Oct 2024 02:33:09 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVkW+h05/mY1GC3w7z6I42HCx0TAdOrgc0kL7TrOntqbTQPkchvn0EqMbyQOdzMF+RgCD6JzGSVVlHMtCc+aep9poTVajk=@freebsd.org, AJvYcCW/2l0BAjQWPaIOP4sTGGDENjoq2qnUeMkA6QyP++RF7wwXZEaWauwrAA6IxvPQxZ3BeZfUF3PdSvEteXv8TpE+F/NFe0hUIw==@freebsd.org X-Gm-Message-State: AOJu0YxHWgv7SxmlCUjSp+vEo/G2+Gi8hqAcwcl2D3Y8YLc4WwUHeAo0 DConJ3wxhJu1JyzY37DfwrupEvLNW3I424kLRpbxLfJjTWXNfHFC1MGnwumd4dSei3b85NZygN/ kaYfNbK6VC6nTFOe+jvUBFSWb+Wc= X-Google-Smtp-Source: AGHT+IEe83uThCbc3eINkTNMplUZJnVoIAY6QOl225E74ffIcQCfZVCbIYKb1G95GRd+kJ/z5IqBbii+WiCToa5gmpQ= X-Received: by 2002:ac8:58c4:0:b0:454:e956:651e with SMTP id d75a77b69052e-45d9bacc396mr104093571cf.12.1728379988440; Tue, 08 Oct 2024 02:33:08 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 References: <202410080924.4989O2DW090082@gitrepo.freebsd.org> In-Reply-To: <202410080924.4989O2DW090082@gitrepo.freebsd.org> From: Nuno Teixeira Date: Tue, 8 Oct 2024 10:32:57 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 57dc9c86c152 - main - devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to 1.16.0" To: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000003f88f40623f3d3dc" --0000000000003f88f40623f3d3dc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We will need to ask upstream to fix OpenMP detection on FreeBSD like macports did: https://github.com/Rdatatable/data.table/issues/6409 A quick fix is: ``` --- configure.orig 2024-10-08 08:42:43 UTC +++ configure @@ -144,7 +144,17 @@ detect_openmp () { fi # uname=3DDarwin - # No support for OpenMP available + + if [ "$(uname)" =3D "FreeBSD" ]; then + + export PKG_CFLAGS=3D"${PKG_CFLAGS}" + export PKG_LIBS=3D"${PKG_LIBS}" + export R_OPENMP_ENABLED=3D1 + return + + fi # uname=3DFreeBSD + + # No support for OpenMP available export R_OPENMP_ENABLED=3D0 } ``` But I don't have enough skills to evaluate the correct FreeBSD support. Thanks Nuno Teixeira escreveu (ter=C3=A7a, 8/10/2024 =C3=A0(= s) 10:24): > The branch main has been updated by eduardo: > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3D57dc9c86c152a5abc0a367d49cbf2= 65a18b738d8 > > commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8 > Author: Nuno Teixeira > AuthorDate: 2024-10-08 09:16:24 +0000 > Commit: Nuno Teixeira > CommitDate: 2024-10-08 09:23:19 +0000 > > devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to > 1.16.0" > > OpenMP detection broken. > > See also: > https://github.com/Rdatatable/data.table/issues/6559 > > https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3= d32177ed9836352 > > This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771. > --- > devel/R-cran-data.table/Makefile | 4 +--- > devel/R-cran-data.table/distinfo | 6 +++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/devel/R-cran-data.table/Makefile > b/devel/R-cran-data.table/Makefile > index 34a8aa0ea207..100dbe683927 100644 > --- a/devel/R-cran-data.table/Makefile > +++ b/devel/R-cran-data.table/Makefile > @@ -1,5 +1,5 @@ > PORTNAME=3D data.table > -DISTVERSION=3D 1.16.0 > +DISTVERSION=3D 1.15.4 > CATEGORIES=3D devel > DISTNAME=3D ${PORTNAME}_${DISTVERSION} > > @@ -12,8 +12,6 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE > > USES=3D cran:auto-plist,compiles pkgconfig > > -TESTING_UNSAFE=3D > https://github.com/Rdatatable/data.table/issues/6559 > - > NO_ARCH_IGNORE=3D data_table.so > > OPTIONS_DEFINE=3D OPENMP > diff --git a/devel/R-cran-data.table/distinfo > b/devel/R-cran-data.table/distinfo > index dfc347728df6..497612d9aa61 100644 > --- a/devel/R-cran-data.table/distinfo > +++ b/devel/R-cran-data.table/distinfo > @@ -1,3 +1,3 @@ > -TIMESTAMP =3D 1728300398 > -SHA256 (data.table_1.16.0.tar.gz) =3D > 58f8aec50099de80d84faa50295c17295d465f669be79b46c3c7ca18c56ef9cd > -SIZE (data.table_1.16.0.tar.gz) =3D 5302544 > +TIMESTAMP =3D 1711960872 > +SHA256 (data.table_1.15.4.tar.gz) =3D > ab8065ff946d59ecaaf5eaf91a975495c07c30caad97a71205c72e41a740cb53 > +SIZE (data.table_1.15.4.tar.gz) =3D 5387593 > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --0000000000003f88f40623f3d3dc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
We will need to ask upstream to fix OpenMP detection = on FreeBSD like macports did:


A quick fix is:

= ```
--- configure.orig =C2=A0 =C2=A0 =C2=A02024-10-08 08:42:43 UT= C
+++ configure
@@ -144,7 +144,17 @@ detect_openmp () {

=C2=A0= =C2=A0fi # uname=3DDarwin

- =C2=A0# No support for OpenMP available=
+
+ =C2=A0if [ "$(uname)" =3D "FreeBSD" ]; then<= br>+
+ =C2=A0 =C2=A0export PKG_CFLAGS=3D"${PKG_CFLAGS}"
+ = =C2=A0 =C2=A0export PKG_LIBS=3D"${PKG_LIBS}"
+ =C2=A0 =C2=A0ex= port R_OPENMP_ENABLED=3D1
+ =C2=A0 =C2=A0return
+
+ =C2=A0fi # una= me=3DFreeBSD
+
+ # No support for OpenMP available
=C2=A0 =C2=A0ex= port R_OPENMP_ENABLED=3D0
=C2=A0}
```

But I = don't have enough skills to evaluate the correct FreeBSD support.
Thanks

Nuno Teixeira <eduardo@freebsd.org> escreveu (ter=C3=A7a, 8/10/2024 =C3= =A0(s) 10:24):
T= he branch main has been updated by eduardo:

URL: https://cgi= t.FreeBSD.org/ports/commit/?id=3D57dc9c86c152a5abc0a367d49cbf265a18b738d8

commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8
Author:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-10-08 09:16:24 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-10-08 09:23:19 +0000

=C2=A0 =C2=A0 devel/R-cran-data.table: Revert "devel/R-cran-data.table= : Update to 1.16.0"

=C2=A0 =C2=A0 OpenMP detection broken.

=C2=A0 =C2=A0 See also:
=C2=A0 =C2=A0 https://github.com/Rdatatable/data= .table/issues/6559
=C2=A0 =C2=A0 https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3= d32177ed9836352

=C2=A0 =C2=A0 This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771.=
---
=C2=A0devel/R-cran-data.table/Makefile | 4 +---
=C2=A0devel/R-cran-data.table/distinfo | 6 +++---
=C2=A02 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/devel/R-cran-data.table/Makefile b/devel/R-cran-data.table/Mak= efile
index 34a8aa0ea207..100dbe683927 100644
--- a/devel/R-cran-data.table/Makefile
+++ b/devel/R-cran-data.table/Makefile
@@ -1,5 +1,5 @@
=C2=A0PORTNAME=3D=C2=A0 =C2=A0 =C2=A0 data.table
-DISTVERSION=3D=C2=A0 =C2=A01.16.0
+DISTVERSION=3D=C2=A0 =C2=A01.15.4
=C2=A0CATEGORIES=3D=C2=A0 =C2=A0 devel
=C2=A0DISTNAME=3D=C2=A0 =C2=A0 =C2=A0 ${PORTNAME}_${DISTVERSION}

@@ -12,8 +12,6 @@ LICENSE_FILE=3D ${WRKSRC}/LICENSE

=C2=A0USES=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 cran:auto-plist,compiles pk= gconfig

-TESTING_UNSAFE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 ht= tps://github.com/Rdatatable/data.table/issues/6559
-
=C2=A0NO_ARCH_IGNORE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 data_table.so

=C2=A0OPTIONS_DEFINE=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 OPENMP
diff --git a/devel/R-cran-data.table/distinfo b/devel/R-cran-data.table/dis= tinfo
index dfc347728df6..497612d9aa61 100644
--- a/devel/R-cran-data.table/distinfo
+++ b/devel/R-cran-data.table/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP =3D 1728300398
-SHA256 (data.table_1.16.0.tar.gz) =3D 58f8aec50099de80d84faa50295c17295d46= 5f669be79b46c3c7ca18c56ef9cd
-SIZE (data.table_1.16.0.tar.gz) =3D 5302544
+TIMESTAMP =3D 1711960872
+SHA256 (data.table_1.15.4.tar.gz) =3D ab8065ff946d59ecaaf5eaf91a975495c07c= 30caad97a71205c72e41a740cb53
+SIZE (data.table_1.15.4.tar.gz) =3D 5387593


--
Nuno Teixeira
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--0000000000003f88f40623f3d3dc--