Re: git: 57dc9c86c152 - main - devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to 1.16.0"

From: Nuno Teixeira <eduardo_at_freebsd.org>
Date: Tue, 08 Oct 2024 09:32:57 UTC
We will need to ask upstream to fix OpenMP detection on FreeBSD like
macports did:

https://github.com/Rdatatable/data.table/issues/6409

A quick fix is:

```
--- configure.orig      2024-10-08 08:42:43 UTC
+++ configure
@@ -144,7 +144,17 @@ detect_openmp () {

   fi # uname=Darwin

-  # No support for OpenMP available
+
+  if [ "$(uname)" = "FreeBSD" ]; then
+
+    export PKG_CFLAGS="${PKG_CFLAGS}"
+    export PKG_LIBS="${PKG_LIBS}"
+    export R_OPENMP_ENABLED=1
+    return
+
+  fi # uname=FreeBSD
+
+ # No support for OpenMP available
   export R_OPENMP_ENABLED=0
 }
```

But I don't have enough skills to evaluate the correct FreeBSD support.

Thanks

Nuno Teixeira <eduardo@freebsd.org> escreveu (terça, 8/10/2024 à(s) 10:24):

> The branch main has been updated by eduardo:
>
> URL:
> https://cgit.FreeBSD.org/ports/commit/?id=57dc9c86c152a5abc0a367d49cbf265a18b738d8
>
> commit 57dc9c86c152a5abc0a367d49cbf265a18b738d8
> Author:     Nuno Teixeira <eduardo@FreeBSD.org>
> AuthorDate: 2024-10-08 09:16:24 +0000
> Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
> CommitDate: 2024-10-08 09:23:19 +0000
>
>     devel/R-cran-data.table: Revert "devel/R-cran-data.table: Update to
> 1.16.0"
>
>     OpenMP detection broken.
>
>     See also:
>     https://github.com/Rdatatable/data.table/issues/6559
>
> https://github.com/Rdatatable/data.table/commit/096b20f1f1b9788787a826ba3d32177ed9836352
>
>     This reverts commit 5f823f135151a2a77b54ef0533c4c932e41ca771.
> ---
>  devel/R-cran-data.table/Makefile | 4 +---
>  devel/R-cran-data.table/distinfo | 6 +++---
>  2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/devel/R-cran-data.table/Makefile
> b/devel/R-cran-data.table/Makefile
> index 34a8aa0ea207..100dbe683927 100644
> --- a/devel/R-cran-data.table/Makefile
> +++ b/devel/R-cran-data.table/Makefile
> @@ -1,5 +1,5 @@
>  PORTNAME=      data.table
> -DISTVERSION=   1.16.0
> +DISTVERSION=   1.15.4
>  CATEGORIES=    devel
>  DISTNAME=      ${PORTNAME}_${DISTVERSION}
>
> @@ -12,8 +12,6 @@ LICENSE_FILE= ${WRKSRC}/LICENSE
>
>  USES=          cran:auto-plist,compiles pkgconfig
>
> -TESTING_UNSAFE=
> https://github.com/Rdatatable/data.table/issues/6559
> -
>  NO_ARCH_IGNORE=        data_table.so
>
>  OPTIONS_DEFINE=                OPENMP
> diff --git a/devel/R-cran-data.table/distinfo
> b/devel/R-cran-data.table/distinfo
> index dfc347728df6..497612d9aa61 100644
> --- a/devel/R-cran-data.table/distinfo
> +++ b/devel/R-cran-data.table/distinfo
> @@ -1,3 +1,3 @@
> -TIMESTAMP = 1728300398
> -SHA256 (data.table_1.16.0.tar.gz) =
> 58f8aec50099de80d84faa50295c17295d465f669be79b46c3c7ca18c56ef9cd
> -SIZE (data.table_1.16.0.tar.gz) = 5302544
> +TIMESTAMP = 1711960872
> +SHA256 (data.table_1.15.4.tar.gz) =
> ab8065ff946d59ecaaf5eaf91a975495c07c30caad97a71205c72e41a740cb53
> +SIZE (data.table_1.15.4.tar.gz) = 5387593
>


-- 
Nuno Teixeira
FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org