From nobody Mon Oct 07 16:29:22 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XMl3Z25Fdz5YNvx; Mon, 07 Oct 2024 16:29:30 +0000 (UTC) (envelope-from yuri@freebsd.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4XMl3Y6llWz4YQ0; Mon, 7 Oct 2024 16:29:29 +0000 (UTC) (envelope-from yuri@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.5.3] (c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 497GTNB3062645 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Mon, 7 Oct 2024 09:29:23 -0700 (PDT) (envelope-from yuri@freebsd.org) X-Authentication-Warning: shell1.rawbw.com: Host c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116] claimed to be [192.168.5.3] Content-Type: multipart/alternative; boundary="------------TkuLchqQiMRkH0EQucq7v0fy" Message-ID: <6f18c22a-a4c9-4370-a730-652d2eb05918@freebsd.org> Date: Mon, 7 Oct 2024 09:29:22 -0700 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 72a99dd00b86 - main - misc/onnxruntime: New port: Cross-platform, high performance ML inferencing & training accelerator To: Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org References: <202410070855.4978tknf062709@gitrepo.freebsd.org> Content-Language: en-US From: Yuri Victorovich In-Reply-To: X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7961, ipnet:198.144.192.0/23, country:US] X-Rspamd-Queue-Id: 4XMl3Y6llWz4YQ0 X-Spamd-Bar: ---- This is a multi-part message in MIME format. --------------TkuLchqQiMRkH0EQucq7v0fy Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Gleb, On 10/7/24 03:35, Gleb Popov wrote: > I don't think this is worth committing then. Especially given the > amount of ports you're already maintaining. > I believe that a few quality ports is better than many broken ones. Some important software depends on onnxruntime that would be desirable to have in the ports tree. Also one user specifically asked about onnxruntime this weekend. Missing symbols probably don't prevent some uses or all important uses. The upstream likely distributes static libs instead of shared libs for this reason, because static libs hide missing symbol problems and allow partial use. While somewhat problematic, it is a good stepping stone for a stable port in the future once they fix issues. > Can you please give attention to > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280689 and > https://lists.freebsd.org/archives/dev-commits-ports-main/2024-October/124108.html > instead of piling up new ports of questionable usefulness? I will look into/fix these soon. Thanks, Yuri --------------TkuLchqQiMRkH0EQucq7v0fy Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Hi Gleb,


On 10/7/24 03:35, Gleb Popov wrote:
I don't think this is worth committing then. Especially given the
amount of ports you're already maintaining.
I believe that a few quality ports is better than many broken ones.

Some important software depends on onnxruntime that would

be desirable to have in the ports tree. Also one user

specifically asked about onnxruntime this weekend.

Missing symbols probably don't prevent some uses or

all important uses.

The upstream likely distributes static libs instead of

shared libs for this reason, because static libs hide

missing symbol problems and allow partial use.

While somewhat problematic, it is a good stepping stone

for a stable port in the future once they fix issues.


Can you please give attention to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280689 and
https://lists.freebsd.org/archives/dev-commits-ports-main/2024-October/124108.html
instead of piling up new ports of questionable usefulness?


I will look into/fix these soon.



Thanks,

Yuri


--------------TkuLchqQiMRkH0EQucq7v0fy--