From nobody Fri Oct 04 12:40:19 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XKp6k5QWMz5Xj1t; Fri, 04 Oct 2024 12:40:30 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XKp6k4sMxz4jcJ; Fri, 4 Oct 2024 12:40:30 +0000 (UTC) (envelope-from gahr@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728045630; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2btWsfzCeqg/xI9bYLB0r3JsDXM0pDt/mGPY5FY7th4=; b=pqdJoUt9yernFaTMJHoUJl8T4AHTADsXdMabji1EBHlJ8HbMvwOL4O3EKSGoca5mH6hLF6 GoaM6E9w8Q8Kz7R7qz0b2+2f/Wo88t+zFCwzLMGd0x62mjdlXHVPIW2J9RlSRp8zBvBl2j D7k5VevXOI11gD+mBaMypjSMbWssJ6Gp5EpC1WdB9iYcuZIOWwymfOan8ioJuyJH5RA+d4 hX7IWQpY/BPgOXp4U3WxmNBxL7EbUrSgntfox2sFmU6MS1Jr6PENYLlj6ngq5EK/NV5nyH wAfVPcIws0ROB6VZPUR4Zhcnmrrvc7e46Ys580kHW00Z4aAbXnFGFsa6gOhmLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1728045630; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2btWsfzCeqg/xI9bYLB0r3JsDXM0pDt/mGPY5FY7th4=; b=xg6Mi4bLf9ybF+bhB7E9pkxW0u1dcUwdcUgTJVYWph6cE1aysJl/S/P4UxHvZnH0OY/9h7 K5ZolC5SwYRxXzxg4Uw9ZRRZQy4Xec7hWjCJsfh3f+4h1aA+wVIvexEHwSJPsD80KtOcuX HQXW0ex5N9EqNcipCC2W9jbNTLCfUMswnKxq73As/8CDxl/HqEnpcnz3sXJpLOBTJVef96 W3K9LuAI2IkU732Mgv9tTXqOUQPex+e1Cr1XiOSXQOu1SgKL9VFreR0uxC4M74atRJeAwm qcJNsKc45GuVSVI7E4WzNUdH6KsiWucS6j3Yf5hRPGTxjMf+rdQrRHn/qnqy6w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1728045630; a=rsa-sha256; cv=none; b=p8w9jmWN3vnhcV8CY9Fhss3NpQkUmClAIIQz0Gi4hyLHcapExIbzeVqoEqE6wgJ+UQZ7IC zocq3Acd0w2osLnHeF7fi9sQjYiEjR4nyFLubmPZ06F5mVBhTzfpbaomkafD7lNu5V4Lwh XaKxPOHTJA5hZlFPljhsUm0ao/Gp1+aI89nvbOMi46Lxul/3yJ3BTc/chI4z9PTZZ/mkQT 5Eky+ZYhVmsSn+CvAYKn3VuR5o4YDFNR/e4DzgbYmalsM+vFbkEKkq10rmUdZJMes78DJb RAeseK4pK7Vq6gCbKZ/GA8Tc1H/0/ruwmTuoXAAkVwNUlsuUcN8g578/u74NEw== Received: from ptrcrt.ch (ptrcrt.ch [IPv6:2a02:2770:8:0:21a:4aff:fe7e:c6be]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: gahr/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4XKp6j5SrpzL0w; Fri, 4 Oct 2024 12:40:29 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Date: Fri, 4 Oct 2024 12:40:19 +0000 From: Pietro Cerutti To: Daniel Engberg Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port Message-ID: <5qanx7v222zl6gawtepv7poftvheldluxoseone2ebevxv3bne@2a7yhel63ul2> Reply-To: Pietro Cerutti References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> <3pymyapuzdf23wt634calkpkcfjjjq3fg5zjmdfpszwmfexsvm@t7l3bncj2x75> <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <1c5e55cb722998c9eff8345c43853aee@mail.infomaniak.com> User-Agent: NeoMutt/20241002 On Oct 04 2024, 03:34 +0000, Daniel Engberg wrote: >>>=A0=A0do-test=A0section=A0can=A0be=A0replaced=A0with=A0USES=3D=A0cmake:t= esting >>>=A0=A0 >>>=A0=A0https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 >>=A0 >>=A0I=A0wasn't=A0able=A0to=A0do=A0it=A0with=A0cmake:testing.=A0Were=A0you? > >Upstream uses from what I can tell an rather old approach for test >target, > >https://github.com/rpm-software-management/createrepo_c/blob/master/CMakeL= ists.txt#L160 > >The "EXCLUDE FROM ALL" part is what causes the issue Thanks, I'll remove that. >>>=A0=A0It=A0also=A0seems=A0to=A0look=A0for=A0Doxygen=A0by=A0default >>>=A0=A0 >>>=A0=A0which=A0you=A0probably=A0want=A0to=A0disable=A0to=A0avoid=A0potent= ial=A0plist >>>=A0=A0issues. >>=A0 >>=A0Well,=A0they=A0don't=A0provide=A0a=A0way=A0to=A0turn=A0off=A0docs,=A0b= ut=A0I=A0don't=A0see=A0an=A0 >>=A0 >>=A0issue=A0with=A0it=A0building=A0docs=A0if=A0it=A0finds=A0doxygen.=A0We= =A0won't=A0be >>=A0installing=A0 >>=A0 >>=A0them=A0anyway. > >https://cmake.org/cmake/help/latest/variable/CMAKE_DISABLE_FIND_PACKAGE_Pa= ckageName.html >works :-) I don't think this is at all necessary. But sure, I can set it (to=20 CMAKE_ON, not to CMAKE_OFF like in your patch). >Patch: > >https://projects.pyret.net/files/freebsd-patches/createrepo_c-improve.patch I have taken a couple of suggestions, thanks. --=20 Pietro Cerutti I have pledged to give 10% of income to effective charities and invite you to join me - https://givingwhatwecan.org