From nobody Tue Oct 01 17:04:42 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XJ47137RRz5Y5x9 for ; Tue, 01 Oct 2024 17:04:45 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-1908.mail.infomaniak.ch (smtp-1908.mail.infomaniak.ch [185.125.25.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XJ47110gBz4Pqy for ; Tue, 1 Oct 2024 17:04:44 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4XJ46y67j1zgRr; Tue, 1 Oct 2024 19:04:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pyret.net; s=20231006; t=1727802282; bh=y6YgJMeFH5GyqgwujznkUnQ0rzrs0jGhJCawrq3o2Dw=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=gOxuG53TgQYJkVx71+0YVDafRb1ooQcqwQrKUbmRJYHH7yG8hwZJi/LfszLUGwDtI DVGIr+je98/IY5ID/mFopqF/KrCwSfnvYjWB6hBFaO0CUj2psBOmms98svXM5L50HT k1ZrTiKn0Bxx87vnIOsXdLHyK5E0QS1e+pfPQOa5hFxnZjD8pxiA5Yb9oJhkrMjVVd H7IuLWdnndhNcHIEcs6rKfNiO5VULdb/0Nn7qh3CVX07zrGhImjqtMQqMSJjMmAK0j NloPve8O1CHRhRYiuHkkKYUts1Gokr/KfXpaD1WOlrxjiKxGDtqzSjSlwy1vn/Jpx4 vytJtKrggBk/g== Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4XJ46y3Gp6zdsc; Tue, 1 Oct 2024 19:04:42 +0200 (CEST) Message-ID: <7d47230ac2447012cb48fb81b3120d40@mail.infomaniak.com> Date: Tue, 01 Oct 2024 19:04:42 +0200 Subject: Re: git: 2ba4ed91621e - main - sysutils/createrepo_c: new port From: Daniel Engberg Reply-To: Daniel Engberg To: Pietro Cerutti Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="_=_swift_1727802282_7b6907553263645c83df95f63c1d630d_=_" X-WS-User-Origin: eyJpdiI6Im1PZWJNUVhpckxRWmZmSm9sK2t1V3c9PSIsInZhbHVlIjoiZ0tOQUJLTCsrUFRveWVYNlBrQjFJUT09IiwibWFjIjoiMjcxNjgzOWQ5YmMyN2Y2Y2JlYjFkMzVkMzBhZGIwZjlhMmM5MWFjMTdhY2MxM2ZhMGQzZGVlMTVkNzY0MzQ3YyIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6InJuUWFCM0g3SEduS2h6eVJwNG9ZcUE9PSIsInZhbHVlIjoiZGlLVkFpaUpxRG00RTkwNDFjTkQrUT09IiwibWFjIjoiNmI0NDZiNzNiNjg3YjNhZjBmNDBmYmE4MWJiNjc0ZTg4YzczNWE5ZjZlOGUyZjk5NWIyY2RhNmU1OWY4OGEzZiIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.757) References: <202410011223.491CNu6S051590@gitrepo.freebsd.org> In-Reply-To: <202410011223.491CNu6S051590@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:185.125.24.0/22, country:CH] X-Rspamd-Queue-Id: 4XJ47110gBz4Pqy X-Spamd-Bar: ---- --_=_swift_1727802282_7b6907553263645c83df95f63c1d630d_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-10-01T14:23:56.000+02:00, Pietro Cerutti wrote= : >=C2=A0The=C2=A0branch=C2=A0main=C2=A0has=C2=A0been=C2=A0updated= =C2=A0by=C2=A0gahr: >=C2=A0 >=C2=A0URL:=C2=A0https://cgit.FreeBSD.org/p= orts/commit/?id=3D2ba4ed91621e5f7054224acda61afed58cb380b1 >=C2=A0 >= =C2=A0commit=C2=A02ba4ed91621e5f7054224acda61afed58cb380b1 >=C2=A0 >= =C2=A0Author:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Pietro=C2=A0Cerutti=C2=A0 >=C2=A0 >=C2=A0AuthorDate:=C2=A02024-10-01=C2=A012:22:30= =C2=A0+0000 >=C2=A0 >=C2=A0Commit:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0Pietro= =C2=A0Cerutti=C2=A0 >=C2=A0 >=C2=A0CommitDate:=C2= =A02024-10-01=C2=A012:23:54=C2=A0+0000 >=C2=A0 >=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0sysutils/createrepo_c:=C2=A0new=C2=A0port >=C2=A0 >=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0crea= terepo_c=C2=A0is=C2=A0a=C2=A0C=C2=A0implementation=C2=A0of=C2=A0the=C2= =A0createrepo=C2=A0tool,=C2=A0which=C2=A0generates >=C2=A0 >=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0metadata=C2=A0for=C2=A0RPM=C2=A0package=C2=A0reposi= tories.=C2=A0It=C2=A0is=C2=A0optimized=C2=A0for=C2=A0performance=C2=A0and= >=C2=A0 >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0provides=C2=A0new=C2=A0features= =C2=A0compared=C2=A0to=C2=A0the=C2=A0original=C2=A0createrepo=C2=A0written= =C2=A0in=C2=A0Python. .... Hi, Please review Porters Handboo= k, there are several "guidelines" to make the tree more consistent and re= ducing overall workload. PORTVERSION --> DISTVERSION https://docs= .freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github= ...and stray(?) comment? Correct maintainer? There's no referenc= e and from what I can tell no submitted PR in Bugzilla. libxml2 depe= ndency should use the GNOME helper https://docs.freebsd.org/en/books/p= orters-handbook/book/#using-gnome https://docs.freebsd.org/en/books/po= rters-handbook/book/#gnome-components sqlite3 dependency should also u= se a helper https://docs.freebsd.org/en/books/porters-handbook/book/#u= sing-databases-uses CMAKE_ARGS can be replaced with CMAKE_OFF=3D ENABL= E_PYTHON https://docs.freebsd.org/en/books/porters-handbook/book/#usin= g-cmake do-test section can be replaced with USES=3D cmake:testing = https://cgit.freebsd.org/ports/tree/Mk/Uses/cmake.mk#n20 You also s= eem to have submitted changes upstream (great initiative, please add a no= te about in the commit msg next time), these can probably apply these usi= ng this method to clean up the Makefile further. https://cgit.freebs= d.org/ports/tree/irc/irssi/Makefile?id=3Def1857fc1c757152f595dd87121d260f6e= 3fb25d#n7 Poudriere also lists quite a few warnings about dependencies= and the REINPLACE_CMD commands. It also seems to look for Doxygen by def= ault which you probably want to disable to avoid potential plist issues.= https://pdr2.bofh.network/data/141-diizzy/2024-10-01_11h36m29s/logs/c= reaterepo_c-1.1.4.log Best regards, Daniel --_=_swift_1727802282_7b6907553263645c83df95f63c1d630d_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
On 2024-10-01T14:23:56.000+02:00, Pietro Cerut= ti <gahr@FreeBSD.org> wrote:


Th=
e branch main has been updated by gahr:

URL: <=
a href=3D"https://cgit.FreeBSD.org/ports/commit/?id=3D2ba4ed91621e5f7054224=
acda61afed58cb380b1" class=3D"defaultMailLink" rel=3D"noopener noreferrer" =
data-ik=3D"ik-secure" target=3D"_blank">https://cgit.FreeBSD.org/ports/comm=
it/?id=3D2ba4ed91621e5f7054224acda61afed58cb380b1

commit 2ba4ed91621e5f7054224acda61afed58cb380b1
Autho=
r:     Pietro Cerutti <gahr@FreeBSD.org>
AuthorDate: 2024-10-01 =
12:22:30 +0000
Commit:     Pietro Cerutti <gahr@FreeBSD.org>
=

CommitDate: 2024-10-01 12:23:54 +0000

    sysutils/createrepo_c: new port
    
   =
 createrepo_c is a C implementation of the createrepo tool, which generates=

    metadata for RPM package repositories. It is optimized f=
or performance and
    provides new features compared to the =
original createrepo written in Python.
....

Hi= ,

Please review Porter= s Handbook, there are several "guidelines" to make the tree more consistent= and reducing overall workload.

PORTVERSION --> DISTVERSION

Correct maintainer? Th= ere's no reference and from what I can tell no submitted PR in Bugzilla.

libxml2 dependency shoul= d use the GNOME helper

https://docs.= freebsd.org/en/books/porters-handbook/book/#using-databases-uses

CMAKE_ARGS can be replaced w= ith CMAKE_OFF=3D ENABLE_PYTHON

do-test section can be replaced with USES= =3D cmake:testing

You a= lso seem to have submitted changes upstream (great initiative, please add a= note about in the commit msg next time), these can probably apply these us= ing this method to clean up the Makefile further.
https://cgit.freebsd.org/ports/tree/irc/= irssi/Makefile?id=3Def1857fc1c757152f595dd87121d260f6e3fb25d#n7

Poudriere also lists quite a = few warnings about dependencies and the REINPLACE_CMD commands. It also see= ms to look for Doxygen by default which you probably want to disable to avo= id potential plist issues.

Bes= t regards,
Daniel
--_=_swift_1727802282_7b6907553263645c83df95f63c1d630d_=_--