From nobody Wed Nov 20 08:49:54 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XtZmy5YRBz5dSrK; Wed, 20 Nov 2024 08:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XtZmy4nBvz4YVy; Wed, 20 Nov 2024 08:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732092594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c8SXWsFmL9QcksouPSFbHARJTbMv7UW7iSokJB07+cY=; b=VMaRAG2ukne83KxYLPkYlmtkeFqZW7aId36XAYSLOR/qrZA3w7BwOqlIpYAM1hAMVfCBc/ 3Vlyf4t5ImYRxC6SXfFQuh5hmHj4KcZrDu+uNKuZdRuImPBODjP/oLf69LMKEwg0jtylOc KY/alk40PblxmZbYs8lbp21TPl7IzfLd/MT0e4FG6ufM0+NYev640ORFnkTODSAiS3Rgpu a/OcY9EZitkltjP9OXdNwgWff+A76cj+UnCKkStMTa2pNY9qIkSrwkvlMPmFzaRHriso0c JLBrJyTico18nNwf/+z9/yneV+OxciY9V6AEks+b5O+fTV7AYJZR/L6vz6d3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732092594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=c8SXWsFmL9QcksouPSFbHARJTbMv7UW7iSokJB07+cY=; b=PpnBvpzsLS82Ai0hNayCe6BerZl1R/o0K3PK2Qhc4yfTR0GWkLlquMKZNWVJAqU506BGf4 UKsuthPU+y0oabcErZu0mT3I/PLgU2vaYvOhDzGsUNLD6pTYcDcUvK5mzo2p2smjiGBGn5 qHooHFbPzCgevNCGMCjx8G/2DSxMzVce3K4EVoFuXbCPu23+r4A/tUcltJRpa8qSpM+D1U NZdjY3qjDQNfpKpYbOdpL0c9o9ENRQ9M2nFZh0yw6G7A+vkHuV98aiZBGlPrdeDZIgPJew Q6wd2JTvzclaOqQP+RRiv9F2Bey2c50yRsmekVU6gdbeXNW377bpp/ZrLKjn1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732092594; a=rsa-sha256; cv=none; b=aqqeaiJtEsjRDYVYo9IaYwW1XUWmgxSIGkV2kupa1tMGCzNWwz1WZ6sxigkcLE4j3K2lS/ I+vWGPqiTOQd4LV7Xu9ib/l1zOu/9yNQLhqm65glfMLw9mfQMt8YhzeWoAm0pEFarCqflk Qq6J34zhbG9Ox5CW/VkE1SpT85L75VCKZf9pd47NCkfV+2BZmm1+hZPTrlrwm89iG7TU45 RmFnpNwMi5ACKZoIgciUi+dzkk8xDHxiQptmBgWvbqW4LLTETVYkNDx74CdWhDnk6vOx9O 6MpusIWyVwbEQmxUTgpAc1aTfSmSaTZOlbs+4YC+KqxzL0Yv42wgD/Uph3tp3g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XtZmy3q7Wzmcq; Wed, 20 Nov 2024 08:49:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AK8nsKQ074767; Wed, 20 Nov 2024 08:49:54 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AK8nsQS074764; Wed, 20 Nov 2024 08:49:54 GMT (envelope-from git) Date: Wed, 20 Nov 2024 08:49:54 GMT Message-Id: <202411200849.4AK8nsQS074764@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Dimitry Andric Subject: git: b47d453f0aac - main - math/givaro: fix build with clang 19 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: b47d453f0aac2e1b349475f9e7fd44fde0a35d76 Auto-Submitted: auto-generated The branch main has been updated by dim: URL: https://cgit.FreeBSD.org/ports/commit/?id=b47d453f0aac2e1b349475f9e7fd44fde0a35d76 commit b47d453f0aac2e1b349475f9e7fd44fde0a35d76 Author: Dimitry Andric AuthorDate: 2024-11-18 10:12:37 +0000 Commit: Dimitry Andric CommitDate: 2024-11-20 08:49:11 +0000 math/givaro: fix build with clang 19 Clang 19 has become more strict about errors in member functions, which results in errors building math/givaro: ./givaro/givaro/givaro/random-integer.h:94:51: error: no viable overloaded '=' 94 | const_cast(_ring)=R._ring; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ ./givaro/givaro/givaro/random-integer.h:94:51: note: type 'Integer_Domain' (aka 'ZRing') is incomplete 94 | const_cast(_ring)=R._ring; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ In file included from givintprime.C:19: In file included from ./givaro/givintprime.h:24: In file included from ./givaro/givaro/givinteger.h:25: ../../../src/kernel/ring/givaro/zring.h:123:13: warning: misleading indentation; statement is not part of the previous 'while' [-Wmisleading-indentation] 123 | return a; } | ^ ../../../src/kernel/ring/givaro/zring.h:121:11: note: previous statement is here 121 | { while (isZero(init(a, g()))) | ^ The `const_cast` line has been removed by upstream as part of https://github.com/linbox-team/givaro/commit/b0cf33e1, but that commit is rather large. It is enough to only delete the line. Also fix a failure that occurs when running "make test": ../src/kernel/recint/rfiddling.h:170:29: error: no member named 'Low' in 'rint' This is because the expression `max.Low.Value` should actually be `max.Value.Low`. PR: 282830 Approved by: pi (maintainer) MFH: 2024Q4 --- math/givaro/files/patch-src_kernel_integer_random-integer.h | 10 ++++++++++ math/givaro/files/patch-src_kernel_recint_rfiddling.h | 11 +++++++++++ 2 files changed, 21 insertions(+) diff --git a/math/givaro/files/patch-src_kernel_integer_random-integer.h b/math/givaro/files/patch-src_kernel_integer_random-integer.h new file mode 100644 index 000000000000..901ddd8ea8e3 --- /dev/null +++ b/math/givaro/files/patch-src_kernel_integer_random-integer.h @@ -0,0 +1,10 @@ +--- src/kernel/integer/random-integer.h.orig 2021-12-14 10:00:03 UTC ++++ src/kernel/integer/random-integer.h +@@ -91,7 +91,6 @@ namespace Givaro + if (this != &R) { + _bits = R._bits; + _integer = R._integer; +- const_cast(_ring)=R._ring; + } + return *this; + } diff --git a/math/givaro/files/patch-src_kernel_recint_rfiddling.h b/math/givaro/files/patch-src_kernel_recint_rfiddling.h new file mode 100644 index 000000000000..5591e9e210bf --- /dev/null +++ b/math/givaro/files/patch-src_kernel_recint_rfiddling.h @@ -0,0 +1,11 @@ +--- src/kernel/recint/rfiddling.h.orig 2021-12-14 10:00:03 UTC ++++ src/kernel/recint/rfiddling.h +@@ -167,7 +167,7 @@ namespace RecInt + template + inline rint rint::maxFFLAS() { + rint max; +- set_highest_bit(max.Low.Value); ++ set_highest_bit(max.Value.Low); + return max; + } +