From nobody Wed Nov 06 13:00:54 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xk5196dWsz5cYt7 for ; Wed, 06 Nov 2024 13:01:01 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xk5193qnSz42yc; Wed, 6 Nov 2024 13:01:01 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (124-18-43-234.area1a.commufa.jp [124.18.43.234]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 4A6D0sm0019143; Wed, 6 Nov 2024 22:00:58 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dec.sakura.ne.jp; s=s2405; t=1730898058; bh=vqHLo3/rdVmSozEPMDbR9WRO9fAx88ms2haUMXZjgTk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=NpQHtvw/L3V0ukaz3eQHOuz46lyeMKb5XDtUtxWydwWCK8ZQOJBBkhT0juBBq3eE+ 9+6Eycb2UMG+VR3FQ3EthwnRYrbDCeTuaKWZoC5XV1U0CPON07NEdGos+jEFWYrb6T gXj/IRNNH8lBLkfMGoykrLhy6nyIlqvVa/xrAYn0= Date: Wed, 6 Nov 2024 22:00:54 +0900 From: Tomoaki AOKI To: Robert Clausecker Cc: Robert Clausecker , "Sergey A. Osokin" , Antoine Brodin , dev-commits-ports-main@freebsd.org Subject: Re: git: 96de6ae007dd - main - graphics/xpdf4: add Qt5/Qt6 flavors Message-Id: <20241106220054.9a433b2cae0bb4e9ecd541eb@dec.sakura.ne.jp> In-Reply-To: References: <20241106213659.853a129a56dfb9585529aaa3@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.1) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-Rspamd-Queue-Id: 4Xk5193qnSz42yc X-Spamd-Bar: ---- On Wed, 6 Nov 2024 13:42:39 +0100 Robert Clausecker wrote: > Greetings, > > Am Wed, Nov 06, 2024 at 09:36:59PM +0900 schrieb Tomoaki AOKI: > > Hi. > > At least, lines 7-9 of the graphics/xpdf4/Makefile does nothing, > > as line 26 and 27 overrides it. > > > > Not tested, but does this help? > > > > --- a/graphics/xpdf4/Makefile > > +++ b/graphics/xpdf4/Makefile > > @@ -4,9 +4,6 @@ > > PORTEPOCH= 1 > > CATEGORIES= graphics print > > MASTER_SITES= https://dl.xpdfreader.com/ > > -.if !defined(MASTERDIR) > > -PKGNAMESUFFIX= 4 > > -.endif > > > > MAINTAINER= cy@FreeBSD.org > > COMMENT= Display PDF files and convert them to other formats > > @@ -23,8 +20,8 @@ > > > > FLAVORS= qt5 qt6 > > FLAVOR?= ${FLAVORS:[1]} > > -qt5_PKGNAMESUFFIX= > > +qt5_PKGNAMESUFFIX= 4 > > -qt6_PKGNAMESUFFIX= -qt6 > > +qt6_PKGNAMESUFFIX= 4-qt6 > > qt5_CONFLICTS_INSTALL= ${PORTNAME}-qt6 > > qt6_CONFLICTS_INSTALL= ${PORTNAME} > > Why is graphics/xpdf a master port and not just a slave port, depending > on graphics/xpdf3 or graphicss/xpdf4 depending on what the user has > configured? > > Yours, > Robert Clausecker > > -- > () ascii ribbon campaign - for an encoding-agnostic world > /\ - against html email - against proprietary attachments Hi. I don't know why graphics/xpdf is a master port, as I'm neither the maintainer nor submitter of the commit. Just noticed PKGNAMESUFFIX is overridden. And if conditional using MASTERDIR is actually needed, it should be around qt?_PKGNAMESUFFIX lines. Regards. -- Tomoaki AOKI