From nobody Mon Nov 04 09:31:24 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhmSF1Czpz5bp4h; Mon, 04 Nov 2024 09:31:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhmSF0lBdz44hg; Mon, 4 Nov 2024 09:31:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730712685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rm4uN5OuL9unruc/u69os8ypE43gVdTPYIuDzwWrNQk=; b=Yb8chkobeqh2jkNvO4k26TG99fCmgjz0h7e1SmEfcNaxSBhzfth3dHnN2xO0mwct1p8r/l D9YE4mOvy9udjygU0qlZqrFwtiI+O2kcK9Kl8u6vm0YlocVj7GakJ94xR8Vd+45fqA6PBd ed1cDIDL/B6WFTOeet86WxTZqd8G7RzzwAxYiqhZs2J3gflRmv+5wsJMVZNPmqr628/42Y JED2Yw4k8TbOap4wgW0trvH/zzixDpyoJS3njmxc7vdWnRMAuu57C96jevJWsab6I8Rw0P 4A+4I4MmqlpBSqb33Zj2dwECJJ8TZc3/D/1XnTKLsSWlAsf2x0foYAdatS1zfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730712685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rm4uN5OuL9unruc/u69os8ypE43gVdTPYIuDzwWrNQk=; b=cyjMaKRxpT/UMoNBS051J9jbg1hri9WLVboo40EhAcRpXccJFfEAhlDZFvcyooqbRSj+CH rgy+hv9lhUM0InOVoZp1L6GEfwf7zJinsc2fstrQCM5f8cFj7UW9fk7fqe5PUxa/ELV9Ka kMURW52ZEPzTsB1HoDo++tgvWfweKbTlVTzkFbov6/sAcI+u4KwcSOAjbLrtfw8zuMt/ka dDKFGIRTBUUuZxbgYtfPmW81NYiSs6l8lSPZGb1ejTPqh03OOIpnW5RwjutfqLaQDRtjyD UHgn4Dyr3B8pfXDr7tsca/gn4MO5s/xOMybRWAuEf/miJqPzq8Rjv9vXr5HKrA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730712685; a=rsa-sha256; cv=none; b=XOBeTFLUD1c4sckYa8FOOckssypu2v+8EhSDPlFKgj3roKQBRdidIn2QkL83suDn/i2CR2 YEl5b34P2jBIRFidZb+HDIkGx0pRXDexDnfAq3+TnJwPOgXT1uGsCVwiWzdxnDCWVMMhQX 7oAfOMhIYtr9QEHP8PDokW/mk46fiCG1ImBgvUgixoNb0qGzmPKP6H2/xtfQiIfKJValnC G08d+b7MaWqTe7n0ZpGz2s7KgBeNHVgJ1J+5rY3azPOnoNdWNGtxtadsexSf/Qc7FdQ6+Y +rGaUzlF3cMTbivDLwMGW2XUs0Pn1utE6i5AqlIfQu4oggKV8SgU2q6vQlhrww== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhmSF0LZtzSDv; Mon, 4 Nov 2024 09:31:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A49VOZq058821; Mon, 4 Nov 2024 09:31:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A49VOfx058818; Mon, 4 Nov 2024 09:31:24 GMT (envelope-from git) Date: Mon, 4 Nov 2024 09:31:24 GMT Message-Id: <202411040931.4A49VOfx058818@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Don Lewis Subject: git: e9090c817e49 - main - editors/openoffice-*: Fix build error with clang 19 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: truckman X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e9090c817e496dd0e45b88b57bff0063385e8ad8 Auto-Submitted: auto-generated The branch main has been updated by truckman: URL: https://cgit.FreeBSD.org/ports/commit/?id=e9090c817e496dd0e45b88b57bff0063385e8ad8 commit e9090c817e496dd0e45b88b57bff0063385e8ad8 Author: Don Lewis AuthorDate: 2024-11-04 09:15:33 +0000 Commit: Don Lewis CommitDate: 2024-11-04 09:31:14 +0000 editors/openoffice-*: Fix build error with clang 19 Fix this build error: In file included from /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.15/main/writerfilter/source/ooxml/OOXMLFactory.cxx:28: In file included from /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.15/main/writerfilter/source/ooxml/OOXMLFactory.hxx:39: In file included from /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.15/main/writerfilter/source/ooxml/OOXMLFastContextHandler.hxx:38: /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.15/main/writerfilter/source/ooxml/RefAndPointer.hxx:104:18: error: no member named 'getHandler' in 'RefAndPointer'; did you mean 'mpHandler'? 104 | set(rSrc.getHandler()); | ^~~~~~~~~~ | mpHandler /wrkdirs/usr/ports/editors/openoffice-4/work/aoo-4.1.15/main/writerfilter/source/ooxml/RefAndPointer.hxx:39:26: note: 'mpHandler' declared here 39 | mutable ChildClass * mpHandler; | ^ when building with: FreeBSD clang version 19.1.2 (https://github.com/llvm/llvm-project.git llvmorg-19.1.2-0-g7ba7d8e2f7b6) It appears that clang 19 does more sanity checks of unused class methods than gcc, old versions of Microsoft Visual C++ used by the AOO project, and older versions of clang. The assign method in the RefAndPointer class has been broken since forever and appears to be unused, so comment it out. This is only a build fix and does not affect the generated code with older compilers, so there is no PORTREVISION bump. Reported by: pkg-fallout --- ...tch-writerfilter_source_ooxml_RefAndPointer.hxx | 24 ++++++++++++++++++++++ ...tch-writerfilter_source_ooxml_RefAndPointer.hxx | 24 ++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/editors/openoffice-4/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx b/editors/openoffice-4/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx new file mode 100644 index 000000000000..ca7a35f3d1e8 --- /dev/null +++ b/editors/openoffice-4/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx @@ -0,0 +1,24 @@ +--- writerfilter/source/ooxml/RefAndPointer.hxx.orig 2021-04-02 12:58:23 UTC ++++ writerfilter/source/ooxml/RefAndPointer.hxx +@@ -98,13 +98,14 @@ class RefAndPointer (public) + ChildClass * getPointer() const { return mpHandler; } + const uno::Reference getRef() const { return mRef; } + +- RefAndPointer & operator= +- (const RefAndPointer & rSrc) +- { +- set(rSrc.getHandler()); +- +- return *this; +- } ++// ...RefAndPointer.hxx:104:18: error: no member named 'getHandler' in 'RefAndPointer'; did you mean 'mpHandler'? ++// RefAndPointer & operator= ++// (const RefAndPointer & rSrc) ++// { ++// set(rSrc.getHandler()); ++// ++// return *this; ++// } + + bool is() { return getRef().is(); } + diff --git a/editors/openoffice-devel/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx b/editors/openoffice-devel/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx new file mode 100644 index 000000000000..4222cbefefbe --- /dev/null +++ b/editors/openoffice-devel/files/patch-writerfilter_source_ooxml_RefAndPointer.hxx @@ -0,0 +1,24 @@ +--- writerfilter/source/ooxml/RefAndPointer.hxx.orig 2019-09-17 22:55:25 UTC ++++ writerfilter/source/ooxml/RefAndPointer.hxx +@@ -75,13 +75,14 @@ class RefAndPointer (public) + ChildClass * getPointer() const { return mpHandler; } + const uno::Reference getRef() const { return mRef; } + +- RefAndPointer & operator= +- (const RefAndPointer & rSrc) +- { +- set(rSrc.getHandler()); +- +- return *this; +- } ++// ...RefAndPointer.hxx:104:18: error: no member named 'getHandler' in 'RefAndPointer'; did you mean 'mpHandler'? ++// RefAndPointer & operator= ++// (const RefAndPointer & rSrc) ++// { ++// set(rSrc.getHandler()); ++// ++// return *this; ++// } + + bool is() { return getRef().is(); } +