From nobody Sun May 19 09:47:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vhwpw4Dd0z5L8dl; Sun, 19 May 2024 09:47:36 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vhwpw38zQz3x91; Sun, 19 May 2024 09:47:36 +0000 (UTC) (envelope-from mandree@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716112056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DYNXqXJcNykHH3e/CNiZ+ylmZ056+7vYGIG0Uk6Z+rE=; b=mgGCuJ3iuWtf7F1wcSY2Dj+5B6rt9x+2ypsDQlUaeZaa9vsYm53D2wfgxF48QjymUE+Cx1 8zF/sAMdElVMBSBRipZiXPrD2P80BTJhCKY960mMZBRpPJyyIqgGkKBoDQaTP81GlUdKAT RrhRanFob4IPj0FEsRpv+4rJ1yzkCvFOPNSKyc5vkfjN8f8X52XPF6ReFvj0ySVkMt4T+Z yKSaW1SfL/Y6qVnIYpPuARDIVzDa/s2J4eVDNAJ/IObge7sSTYp45NMa7/4v5amze1Q5IW Wc1qwGbAZmAHDLVQ1dSp5AgGROfBRdMGe0ZLPfni7H6Fqx9bfjJGc6Ci+jnxuQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1716112056; a=rsa-sha256; cv=none; b=i5mInepuHDZ+UODK3XI4qRYLptLM0wZaY/qvuf27Afg5BjacwgTGYw2LtIoFXdrRt2bz1a FJpXapH3e50teGuGD78AviZ8pKEHFVnYEDrTbkAeI/uB1Lu8KsVnS1ZHnIPmXq9iC/ChiB YNMp8Mnua6nYKBP2x86y1FtuGakoW5LcyhXyhghHOjb3KtvhOoHHhqkAovGi1KiSMijoxR N5AYwUaeBxqnAHhHGaigLxNQIvbsELvl32IMDEhn2fhz78MRLoqgJ7C9P8tbOv8bXUBuT5 H7KpyyEyRznds1BKwmSKf9LFwCEcJeydxZS+Ts4U+yWWdYofOZhNuk7R4AIQ9Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1716112056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DYNXqXJcNykHH3e/CNiZ+ylmZ056+7vYGIG0Uk6Z+rE=; b=fCYhNRGtJ0CDfZcd3sQTGSSsq6qmYoOq6ELaNMmBxvMXuGRuHQg1wnRn/vp+eaPnSFXkiu pVCBvUhgM2LAyHNTmpOc0QvNTjUe5u/UT8RHC7jbMVffXuRLwzLhXbzWAoiJmz2PBXUs/u Zj0x5lj5IYsCRlaequ1NI2DJXCp0LYNI+VHI8CyUosVQ2LANmoDyKjKvtYqy0LIKxxtpca 0qN1nxqJ2TPrIb3vL1dhbQQvmgqCIf9v/b9H2c5GxEVhAOrQ6fqwsi58w4EoQ1xfq+8qmj nyGZMrQlW+AKZcZq4SgSGZmpMrzKV9vh/qskYzkFO0d5w9sCXd8TYcVfwo3smg== Received: from mandree.no-ip.org (pd9e07b18.dip0.t-ipconnect.de [217.224.123.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: mandree/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vhwpw1rKVz1NMl; Sun, 19 May 2024 09:47:36 +0000 (UTC) (envelope-from mandree@FreeBSD.org) Received: from [127.0.0.1] (localhost [127.0.0.1]) by ryzen.an3e.de (Postfix) with ESMTP id E44EE1C31D01; Sun, 19 May 2024 11:47:34 +0200 (CEST) Content-Type: multipart/mixed; boundary="------------KHI8j6dCcRlgC1uwyl0Tne0v" Message-ID: Date: Sun, 19 May 2024 11:47:34 +0200 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Matthias Andree Subject: Re: git: 7a7408cd7731 - main - security/botan3: Broken on aarch64, amd64 and 13 To: Yuri Victorovich , Dima Panov Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202405181859.44IIxP06073124@gitrepo.freebsd.org> Content-Language: en-US Organization: FreeBSD.org In-Reply-To: <202405181859.44IIxP06073124@gitrepo.freebsd.org> This is a multi-part message in MIME format. --------------KHI8j6dCcRlgC1uwyl0Tne0v Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Am 18.05.24 um 20:59 schrieb Yuri Victorovich: > The branch main has been updated by yuri: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=7a7408cd7731d6e05ccbc6e895ca84600eb26bfe > > commit 7a7408cd7731d6e05ccbc6e895ca84600eb26bfe > Author: Yuri Victorovich > AuthorDate: 2024-05-18 18:58:46 +0000 > Commit: Yuri Victorovich > CommitDate: 2024-05-18 18:58:46 +0000 > > security/botan3: Broken on aarch64, amd64 and 13 > > Reported by: fallout > --- > security/botan3/Makefile | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/security/botan3/Makefile b/security/botan3/Makefile > index 8ddf75dfbc36..64282de2bc4b 100644 > --- a/security/botan3/Makefile > +++ b/security/botan3/Makefile > @@ -12,7 +12,9 @@ WWW= https://botan.randombit.net/ > LICENSE= BSD2CLAUSE > LICENSE_FILE= ${WRKSRC}/license.txt > > -BROKEN_armv6= include/arm_neon.h:28:2: error: "NEON support not enabled" > +BROKEN_amd64= clang crashes, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279136 > +BROKEN_aarch64= clang crashes, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279136 > +BROKEN_FreeBSD_13= compilation fails: no member named 'find' in namespace 'std::ranges' > > LIB_DEPENDS= libboost_filesystem.so:devel/boost-libs > Dima, Yuri, Update: LLVM15 compiles this nicely on FreeBSD 14 amd64, yet * I get a "pathfix" warning at the end that pathfix won't fix (we'd need to patch the configure.py or other stuff instead) and * I find that the build hardcodes the /usr/local/llvm15/bin/c++ path so that it does not use ccache... so when using ccache, we would have to wrap it. --compiler-cache=... to the rescue. Finally, we might want to resolve the conflict with Botan2, which seems to be ONLY around the manual page, so Botan2 may want to rename its to botan2(1). I am attaching a patch, which isn't complete, I didn't test LLVM14, I didn't test ARM64 (can't for lack of a system), I didn't hack FreeBSD 13, and didn't remove the BROKEN line. In case it doesn't make it here, see https://people.freebsd.org/~mandree/botan3-wip.patch ldd doesn't show we depend on boot::filesystem - is it safe to remove the LIB_DEPENDS? I've commented it out. ------- Hi Yuri, what's become of the LLVM version constraining lines that Dima commented out in 21d88aba74501? Have you tried pinning LLVM to versions 14-15 by enabling those commented lines again? Alternatively, could/should we use GCC with libc++? (Look at graphics/rawtherapee for how it's done, albeit with older C++ standards than C++20.) Also, for std::ranges::find if our C++ doesn't cut it, we might consider adding Boost as a dependency and use boost::ranges::find if it's usable for what Botan3 tries to do with it (I haven't looked): Regards, Matthias -- Matthias Andree FreeBSD ports committer --------------KHI8j6dCcRlgC1uwyl0Tne0v Content-Type: text/x-patch; charset=UTF-8; name="botan3-wip.patch" Content-Disposition: attachment; filename="botan3-wip.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NlY3VyaXR5L2JvdGFuMy9NYWtlZmlsZSBiL3NlY3VyaXR5L2JvdGFu My9NYWtlZmlsZQppbmRleCA2NDI4MmRlMmJjNGIuLjkyMjVjYjc0NjU1YiAxMDA2NDQKLS0t IGEvc2VjdXJpdHkvYm90YW4zL01ha2VmaWxlCisrKyBiL3NlY3VyaXR5L2JvdGFuMy9NYWtl ZmlsZQpAQCAtMTYsNyArMTYsNyBAQCBCUk9LRU5fYW1kNjQ9CWNsYW5nIGNyYXNoZXMsIHNl ZSBodHRwczovL2J1Z3MuZnJlZWJzZC5vcmcvYnVnemlsbGEvc2hvd19idWcuY2dpPwogQlJP S0VOX2FhcmNoNjQ9CWNsYW5nIGNyYXNoZXMsIHNlZSBodHRwczovL2J1Z3MuZnJlZWJzZC5v cmcvYnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTI3OTEzNgogQlJPS0VOX0ZyZWVCU0RfMTM9 CWNvbXBpbGF0aW9uIGZhaWxzOiBubyBtZW1iZXIgbmFtZWQgJ2ZpbmQnIGluIG5hbWVzcGFj ZSAnc3RkOjpyYW5nZXMnCiAKLUxJQl9ERVBFTkRTPQlsaWJib29zdF9maWxlc3lzdGVtLnNv OmRldmVsL2Jvb3N0LWxpYnMKKyMgTElCX0RFUEVORFM9CWxpYmJvb3N0X2ZpbGVzeXN0ZW0u c286ZGV2ZWwvYm9vc3QtbGlicwogCiBVU0VTPQkJY29tcGlsZXI6YysrMjAtbGFuZyBjcGUg Z21ha2Ugc2hlYmFuZ2ZpeCB0YXI6eHoKIENQRV9WRU5ET1I9CSR7UE9SVE5BTUV9X3Byb2pl Y3QKQEAgLTI3LDYgKzI3LDcgQEAgU0hFQkFOR19HTE9CPQkqLnB5CiBIQVNfQ09ORklHVVJF PQkJeWVzCiBDT05GSUdVUkVfU0NSSVBUPQljb25maWd1cmUucHkKIENPTkZJR1VSRV9BUkdT PQkJLS1jYz0ke0NIT1NFTl9DT01QSUxFUl9UWVBFfSBcCisJCQkkeyIke0NDQUNIRV9CSU59 IiAhPSAiIjo/LS1jb21waWxlci1jYWNoZT0ke0NDQUNIRV9CSU59On0gXAogCQkJLS1wcmVm aXg9JHtQUkVGSVg6UX0gXAogCQkJLS13aXRoLWJvb3N0IFwKIAkJCS0td2l0aC1iemlwMiBc CkBAIC04NCw5ICs4NSw5IEBAIFBMSVNUX1NVQis9CUhBU19QUk9DRVNTT1JfUk5HPSIiCiBQ TElTVF9TVUIrPQlIQVNfUFJPQ0VTU09SX1JORz0iQGNvbW1lbnQgIgogLmVuZGlmCiAKLSMu aWYgJHtPUFNZU30gPT0gRnJlZUJTRCAmJiAoICR7T1NWRVJTSU9OfSA+PSAxNDAwMDkxIHx8 ICggJHtPU1ZFUlNJT059ID49IDEzMDI1MDUgJiYgJHtPU1ZFUlNJT059IDwgMTQwMDAwMCAp IHx8ICR7T1NWRVJTSU9OfSA8IDEzMDAwMDAgKQotI1VTRVMrPQlsbHZtOm1heD0xNSxtaW49 MTQKLSMuZW5kaWYKKy5pZiAke09QU1lTfSA9PSBGcmVlQlNEICYmICggJHtPU1ZFUlNJT059 ID49IDE0MDAwOTEgfHwgKCAke09TVkVSU0lPTn0gPj0gMTMwMjUwNSAmJiAke09TVkVSU0lP Tn0gPCAxNDAwMDAwICkgfHwgJHtPU1ZFUlNJT059IDwgMTMwMDAwMCApCitVU0VTKz0JbGx2 bTptYXg9MTUsbWluPTE0CisuZW5kaWYKIAogcG9zdC1wYXRjaDoKIAlAJHtSRUlOUExBQ0Vf Q01EfSAtZSAnc3xeb3B0aW1pemF0aW9uX2ZsYWdzIC4qfG9wdGltaXphdGlvbl9mbGFncyAi JHtDWFhGTEFHU30ifCcgXAo= --------------KHI8j6dCcRlgC1uwyl0Tne0v--