From nobody Sun May 05 15:45:10 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VXTQ93R0gz5K9VL; Sun, 05 May 2024 15:45:21 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Received: from shell1.rawbw.com (shell1.rawbw.com [198.144.192.42]) by mx1.freebsd.org (Postfix) with ESMTP id 4VXTQ90Z9Tz4tGr; Sun, 5 May 2024 15:45:21 +0000 (UTC) (envelope-from yuri@FreeBSD.org) Authentication-Results: mx1.freebsd.org; none Received: from [192.168.5.3] (c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116]) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 445FjEDQ064169 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Sun, 5 May 2024 08:45:14 -0700 (PDT) (envelope-from yuri@FreeBSD.org) X-Authentication-Warning: shell1.rawbw.com: Host c-98-42-44-116.hsd1.ca.comcast.net [98.42.44.116] claimed to be [192.168.5.3] Message-ID: <24173111-6ae2-43ad-b007-9529cae4d11d@FreeBSD.org> Date: Sun, 5 May 2024 08:45:10 -0700 List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4251c2a2ddb5 - main - net/torsocks: Fix USE_LDCONFIG Content-Language: en-US To: Baptiste Daroussin , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202405050830.4458UqAj096937@gitrepo.freebsd.org> From: Yuri Victorovich In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7961, ipnet:198.144.192.0/23, country:US] X-Rspamd-Queue-Id: 4VXTQ90Z9Tz4tGr Hi Baptiste, On 5/5/24 03:26, Baptiste Daroussin wrote: > Why this is wrong and USE_LDCONFIG should not be used at all, it is > meant to be used via LD_PRELOAD > Why this is wrong because USE_LDCONFIG=yes adds $PREFIX/lib to ldconfig path, while this port installs shared libraries into a different directory. > USE_LDCONFIG should not be used at all, it is meant to be used via LD_PRELOAD It is mostly used via LD_PRELOAD, but dependent package developers can also decide to link to it permanently, for example for security reasons. So IMO USE_LDCONFIG should be present in this port. Thanks, Yuri