Re: git: d22f15315b93 - main - devel/gmake43: Corrections

On Fri, 29 Mar 2024 14:17:12 -0700 Yuri Victorovich wrote:
> On 3/29/24 13:56, Baptiste Daroussin wrote:
> > As I have been told by other this is not explicit enough, an explicit version of
> > this email is: please revert gmake43 addition we are not at a point where it is
> > actually required.  
> 
> 
> But should the users of science/nwchem do (at some point I was one of them)?
> 
> With gmake-4.4.1 it builds for 20+ hours and times out.
> 
> Try 'pkg search nwchem' - it isn't found.
> 
> They aren't going to quickly fix the build. It isn't slightly broken, it 
> is broken a lot, and has always been. With gmake-4.3 it is also 
> unnecessarily slow, but passable.
> 
> 
> Are you suggesting to just revert the change, and make NWChem broken again?
> 
> Could you please elaborate how is this going to make thing better?
> 
> Is it worse to have one extra devel/gmakeNN version used to work around 
> this problem and fix the failure, or to keep science/nwchem broken?
> 
> 
> Looking forward to see how is your suggestion beneficial.
> 
> 
> Thanks,
> 
> Yuri
> 

It looks like $(shell ...) is mostly used in one file, so maybe a patch
like this is enough?

diff --git a/science/nwchem/Makefile b/science/nwchem/Makefile
index 52d0da8cb865..51ea75251551 100644
--- a/science/nwchem/Makefile
+++ b/science/nwchem/Makefile
@@ -86,6 +86,9 @@ post-extract-LIBXC-on:
 	@${LN} -s ${DISTDIR}/${DIST_SUBDIR}/libxc-${LIBXC_VERSION}.tar.gz ${WRKSRC}/libext/libxc/
 
 post-patch:
+	@${REINPLACE_CMD} \
+		'/^[[:space:]]*[[:upper:]_]*[[:space:]]*=[[:space:]]*$$(shell/s/=/:=/' \
+		${WRKSRC}/config/makefile.h
 	@${REINPLACE_CMD} 's|nwchrc="/etc/nwchemrc"|nwchrc="${PREFIX}/etc/nwchemrc"|' ${WRKSRC}/util/util_nwchemrc.F
 
 pre-build: