Re: git: c89426b1f238 - main - security/nmap-devel: New port

From: Daniel Engberg <daniel.engberg.lists_at_pyret.net>
Date: Thu, 28 Mar 2024 21:10:01 UTC
On 2024-03-28T21:54:13.000+01:00, Cy Schubert <cy@FreeBSD.org> wrote:
>  The branch main has been updated by cy:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=c89426b1f238e3ad79444ac311cd9d11fd86ac5f
> 
> commit c89426b1f238e3ad79444ac311cd9d11fd86ac5f
> Author:     Cy Schubert <cy@FreeBSD.org>
> AuthorDate: 2024-03-28 20:23:34 +0000
> Commit:     Cy Schubert <cy@FreeBSD.org>
> CommitDate: 2024-03-28 20:53:59 +0000
> 
>     security/nmap-devel: New port
>     
>     Introduce nmap development port. The development branch includes
>     prerequisite updates including the pcre2 replacement of pcre.
>     This port tracks the nmap/nmap github repo.
...

Please, when committing new ports review Porters Handbook

Versioning should be reworked and please use the variables listed, 
Have look at Example 15 and/or 18 in the GITHUB section, https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github

USES=		tar:bzip2 
This is incorrect

At least use portlint (fails and has a lot of useful input), portfmt and/or portclippy ( ports-mgmt/portfmt ) can have good pointers too. https://docs.freebsd.org/en/books/porters-handbook/book/#porting-portlint

Best regards,
Daniel