From nobody Sun Mar 24 11:10:18 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V2YJN5SjJz5Fg17 for ; Sun, 24 Mar 2024 11:10:28 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-190f.mail.infomaniak.ch (smtp-190f.mail.infomaniak.ch [IPv6:2001:1600:7:10::190f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V2YJM2yhwz4cGw for ; Sun, 24 Mar 2024 11:10:27 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4V2YJC25PrzjH7; Sun, 24 Mar 2024 12:10:19 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4V2YJB65h4z3W; Sun, 24 Mar 2024 12:10:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pyret.net; s=20231006; t=1711278619; bh=R/px5HtXUGr8sOg0+rBMaoVK/DxCLTk7cqPGeiJ0ldg=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=eR55T3Ap1zVUAJ9UWS+9+/0RiBjz6etS8QAbSWNRuG+HQz15AUSq0LNKxaEOSLqT7 4f5aVs/iA4yskkzTug+bXPneI2Tr7hgwQfbVzPIGb0Af9ucddLcbuUNX7vr8clHYPX rkq5p4sTu7XNZrQdyXX3mT1/eav2DW7UYSldIJl7NZd4tLBUFN30q6z/8PtFXk4tb5 IO5UVd+Lk0tPVZN9/rctgAI0yhpEIg1qOCMNwn/s4EWUhV9L/2v+b6HtUvImB1To1/ tIt9bOlFBu+JDKJrDnIq3REnCOhyQtrzj4f84zLOUOLgWBOImzBW0ACkG9gecpDoGd jBs8OzOkpUvPA== Message-ID: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com> Date: Sun, 24 Mar 2024 12:10:18 +0100 Subject: Re: git: d79ba67c4595 - main - devel/phorgeit-arcanist-lib: New port From: Daniel Engberg Reply-To: Daniel Engberg To: Michael Gmelin Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-WS-User-Origin: eyJpdiI6ImVLaHFFNEM2dVo0K1lnN2FYQkxuS2c9PSIsInZhbHVlIjoiVDFwY0pXem5JYjFpSWlTRVJXb09UUT09IiwibWFjIjoiNGE0MDk2YWYxOTdjZjI0OTc3ZDNiMjZlYzQ3NDQxZGU4NmZkOTFlNGVhM2M2NjE5ZTY2YTU4OWM2OWNhODdlNSIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6Ikc5VlA1Uk9LWmNQZDhlbzhWb0M4REE9PSIsInZhbHVlIjoiRHZHTzZIY2ZjZHB1TTR1ZjRqRnhLUT09IiwibWFjIjoiYTFmNTRiNzc2ZGNiZDAzMzVlZTc5ZGRmYjk4NWJhNmQzYmJlNDkzZDZjMTFmZDZiZDA4MzFhMThhN2E1ODI3NyIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.660) References: <202403241025.42OAPS1P083257@gitrepo.freebsd.org> In-Reply-To: <202403241025.42OAPS1P083257@gitrepo.freebsd.org> X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] X-Rspamd-Queue-Id: 4V2YJM2yhwz4cGw Hi, Why did this remove "- SUBDIR +=3D php-Psr_Log" in devel/Makefile ? Please follow Porters Handbook when it comes to versioning and usage of var= iables. Commit refers to https://github.com/phorgeit/arcanist/commit/174bf094ef9fe2= 6770903c912cf29b6c78760b26 which was committed, Date: Wed, 28 Feb 2024 12:2= 9:14 +0100 Why does PORTVERSION say 20240304? Upstream uses tags so utilize those and do backports of needed unless you n= ever intend to follow upstream, in that case you should use commit date and= prefix g. See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-maste= r_sites-github Use DISTVERSION whenever possible as shown in examples. please use the same= length of commits when using GH_TAGNAME as shown in Porters Handbook. Best regards, Daniel