From nobody Sat Mar 23 16:52:52 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V24y32GWvz5FPcY for ; Sat, 23 Mar 2024 16:52:59 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V24y24fb0z4rKN; Sat, 23 Mar 2024 16:52:58 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-21-232.area1b.commufa.jp [123.1.21.232]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 42NGqrFR028630; Sun, 24 Mar 2024 01:52:53 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Sun, 24 Mar 2024 01:52:52 +0900 From: Tomoaki AOKI To: =?UTF-8?B?VMSzbA==?= Coosemans Cc: dev-commits-ports-main@freebsd.org Subject: Re: git: d7511b9d0074 - main - Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV Message-Id: <20240324015252.30aa8d04753ed1ae1d55a90a@dec.sakura.ne.jp> In-Reply-To: <20240323174553.3bd41424@hal.tijl.coosemans.org> References: <20240323225434.5a46725b8241f4aa13b3ff4a@dec.sakura.ne.jp> <20240323174553.3bd41424@hal.tijl.coosemans.org> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] X-Rspamd-Queue-Id: 4V24y24fb0z4rKN On Sat, 23 Mar 2024 17:45:53 +0100 Tijl Coosemans wrote: > On Sat, 23 Mar 2024 22:54:34 +0900 Tomoaki AOKI wrote: > > Just want to be 100% sure before updating ports tree to this commit and > > later. > > > > Does this mean something like "DEFAULT_VERSIONS+= ssl=base" > > in /etc/make.conf still work fine? > > (Means, does this change doesn't affect for ports tree, but affects > > only Makefile under ${WRKDIR}?) > > Yes. Thanks for clarification! Now I can go forward. > > If yes, no problem, maybe. > > If no, please revert this ASAP. It's too hazardous. > > > > Regards. > > > >> The branch main has been updated by tijl: > >> > >> URL: > > https://cgit.FreeBSD.org/ports/commit/?id=d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 > >> > >> commit d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 > >> Author: Tijl Coosemans > >> AuthorDate: 2024-02-29 21:11:00 +0000 > >> Commit: Tijl Coosemans > >> CommitDate: 2024-03-23 11:19:32 +0000 > >> > >> Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV > >> > >> And remove it from individual ports. Use WRK_ENV in custom build > >> commands where necessary. > >> > >> FreeBSD make(1) includes /usr/share/mk/sys.mk and that includes > >> /etc/make.conf if it exists. This happens when you run make in a > >> port directory but it also happens when the upstream build system uses > >> make. This commit disables make.conf inclusion in the latter case > >> because users can define variables like CFLAGS in make.conf that > >> override ports framework variables and this can cause problems that are > >> difficult to diagnose. > >> > >> If there are any build customisations made through make.conf that > >> stop working because of this commit then they should be made available > >> by the ports tree through some mechanism, e.g. an option in a port. > >> > >> Some ports were picking up variables from Poudriere make.conf and > >> required fixes: > >> > >> - astro/wmspaceweather x11-clocks/wmcalclock: Add OPSYS to MAKE_ENV. > >> - games/zhlt: Add ARCH to MAKE_ENV. > >> - graphics/tachyon: Upstream ARCH is not ports tree ARCH. > >> Set ALL_TARGET=bsd so upstream ARCH is defined correctly. > >> Enable multi-threading support while here. > >> > >> PR: 277455 > >> Exp-run by: antoine -- Tomoaki AOKI