From nobody Sat Mar 23 16:45:53 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V24ny41n8z5FPGJ for ; Sat, 23 Mar 2024 16:45:58 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V24ny3YYjz4qyR; Sat, 23 Mar 2024 16:45:58 +0000 (UTC) (envelope-from tijl@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711212358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdNLYeY5d+otielkHAtZuESzSNgXp6N8OXFK4fAdinI=; b=NDAO+V51LyxTBZAq6ADz7sRNwVlYB0Z5/xgxDgFfF2tQDgz79lH15FypYhHB3aVqsDWdZP x1p2pnxMYB5Xu7yaMx7UDLmvBh087m5aFm+l68PJVUbZN4ZGeGwGwPNJGsWbJUXAMuD8UP hd+UkRsw1rg9wyD85xtXK0HN2gF/fsCsyiYDUeAqztxRhYgY7fSL286yV9RaAR3jmfPjcq YEXMN271iKx1oYjVwdk1BcvJocMy0/9GEdkZZXKJ3NZNofLd6iCo3lgU7lwvz+Lx8a9HeM 0b8e7jpwYHaduir070uJtLbUB2xFVq7Onej4Pu6OgNwpHgtxzgrWq5NjJPmrow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711212358; a=rsa-sha256; cv=none; b=ti9nOj0j5WYWeufnXZSQbbycg/HwaIV+43aVKnsXsgN9eyDBtvT61w6duUyKDdjyDYwaRm YDWTQUIlTFR24YCFebD0TOB1fj/UqFxB/iL6eLNvjVpJB/kr+bywIaycEdhtGC8RxXnBB1 j05UuONEUBvwsi4tikP+XU4elHPnLr5iNnOLPBqFDs1oARNkHxLzZx8S2QLSbxS5y+vObo MRZaEVDB3T0sAbbsGilN0dxhYMUgOVy/HdRI1ZA7MrKfLyUoMt+uBJMKugGw73Xp4sQaEI OtC/NMsvpUjDtH5Cb9FOSaelUvWe7Jgel14apdFO6rWKzsT2cQyenQAR7oZSdA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711212358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sdNLYeY5d+otielkHAtZuESzSNgXp6N8OXFK4fAdinI=; b=McBlzoaFzc6s9Cv+NFA47qTwrqaC81J4KapyyyaenyLP9EYq2pLj7+TjOAPdrpC2elrCw7 YJds6cOkslmaBHZaOxWwp/nxGERpr/MqRo1xHxafyYlMLouKbi9gr41Q/liJOGG6SdJTi1 GhdbWbpXXLrBOUbHSNpi0Vw3evPs9PPz394gGgnZehWQi1ZJQzQJhr0gvT3IWL0lP7syCQ QqDqTLbkUUXVWN2Kw0zjTol2JBnmqbZWWhlz3faeF7rrElDZds3yxOp1TMuGYdggk6+8xV cfiQqQktiM5LxaREloKrLFvX4W5dS1HRzA87CNlftaso8yrM+fkaUE36nUUMIA== Received: from hal.tijl.coosemans.org (unknown [IPv6:2a02:a03f:994e:2800:1007:458f:499e:80a9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: tijl) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V24ny00C7zYbs; Sat, 23 Mar 2024 16:45:57 +0000 (UTC) (envelope-from tijl@FreeBSD.org) Date: Sat, 23 Mar 2024 17:45:53 +0100 From: =?UTF-8?B?VMSzbA==?= Coosemans To: Tomoaki AOKI Cc: dev-commits-ports-main@freebsd.org Subject: Re: git: d7511b9d0074 - main - Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV Message-ID: <20240323174553.3bd41424@hal.tijl.coosemans.org> In-Reply-To: <20240323225434.5a46725b8241f4aa13b3ff4a@dec.sakura.ne.jp> References: <20240323225434.5a46725b8241f4aa13b3ff4a@dec.sakura.ne.jp> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 23 Mar 2024 22:54:34 +0900 Tomoaki AOKI wrote: > Just want to be 100% sure before updating ports tree to this commit and > later. > > Does this mean something like "DEFAULT_VERSIONS+= ssl=base" > in /etc/make.conf still work fine? > (Means, does this change doesn't affect for ports tree, but affects > only Makefile under ${WRKDIR}?) Yes. > If yes, no problem, maybe. > If no, please revert this ASAP. It's too hazardous. > > Regards. > >> The branch main has been updated by tijl: >> >> URL: > https://cgit.FreeBSD.org/ports/commit/?id=d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 >> >> commit d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 >> Author: Tijl Coosemans >> AuthorDate: 2024-02-29 21:11:00 +0000 >> Commit: Tijl Coosemans >> CommitDate: 2024-03-23 11:19:32 +0000 >> >> Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV >> >> And remove it from individual ports. Use WRK_ENV in custom build >> commands where necessary. >> >> FreeBSD make(1) includes /usr/share/mk/sys.mk and that includes >> /etc/make.conf if it exists. This happens when you run make in a >> port directory but it also happens when the upstream build system uses >> make. This commit disables make.conf inclusion in the latter case >> because users can define variables like CFLAGS in make.conf that >> override ports framework variables and this can cause problems that are >> difficult to diagnose. >> >> If there are any build customisations made through make.conf that >> stop working because of this commit then they should be made available >> by the ports tree through some mechanism, e.g. an option in a port. >> >> Some ports were picking up variables from Poudriere make.conf and >> required fixes: >> >> - astro/wmspaceweather x11-clocks/wmcalclock: Add OPSYS to MAKE_ENV. >> - games/zhlt: Add ARCH to MAKE_ENV. >> - graphics/tachyon: Upstream ARCH is not ports tree ARCH. >> Set ALL_TARGET=bsd so upstream ARCH is defined correctly. >> Enable multi-threading support while here. >> >> PR: 277455 >> Exp-run by: antoine