From nobody Sat Mar 23 16:12:07 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V243f058Mz5FLG9 for ; Sat, 23 Mar 2024 16:12:46 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V243d6fWWz4n4H for ; Sat, 23 Mar 2024 16:12:45 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711210365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJxxelk+Jrvkw6VXE9gYtvb0kUY084PwE/2AUGrntPE=; b=TbVnWFV45y00HmYANtiFru1N/W0o/d8aXNaZcD2jgALYK+JKx/C8A2Cw1sBGY4kdw1f5wo DMC9XK0N/4d2ff0LmOKoas1AiIYKPw6MvC+6GfkVT+s076ab8GpX8bqc8FwBExXmnmyTAL efTgcNUumF1wz5xX+Melqm6E5qJoPCzl26G2DN9Ls5Ylh1br6i0Q+auBG9i7MW4d/jsa2d 4sUc0cFo3zKv7b4VSEP8M0aHBpIFrxHUdemkoJ4Z9RMlpTA+2qPOSa/PyblUKFjU/O/Kgq H5/IoFMJ+wKAlHtRQKW0/w0wXQg3y0jipEjaPCfaq3kEi+VV2zF8NIrtMITbIg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1711210365; a=rsa-sha256; cv=none; b=jfoER0E+BGEvfrV9YhDLT1onW4qvJbGKwOlE/9dhJcLaHtlsn/j/NdoY4v4+QkaqKU3Au+ 5lL1hJNryTIKwLEgah8vZ6LXqZMzmvOzGbwW8g4W9ybAuMmkq2AmaeM8yL8bYTBTs3ERg4 CesfF2dFOSpLA8lEQN2ZW/EkMpIMA1DJV7T8kbA+7vOULE4GvfKGf0fzxB8ewximVvzYAa 1xqdTTtQxQEvCdXMQ2jB39DpUiXfE7T90sOwPahvM7/eDxrkG8yneBB/N/fBw9EpAYk0mB jxJCw7xZaElbAXctBZG+CsnTr01N3Uv/6nESnD0L7PyDIcPzp4nuRAfxoECMyQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1711210365; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lJxxelk+Jrvkw6VXE9gYtvb0kUY084PwE/2AUGrntPE=; b=txEoQsvNPHsELgdvlBfkoVK3sC1rkcrPG1y0ZhfWwxagk1ejz1BY4S7EycZ32axqgrh44n AmqT2gyqn7LgJYMOzSgqNQrKoYBKHEldWW7tUSgGvaV4zTVpCPppObxOWoA3ANfS2DkwHl BbQtMwyf9YhYv2K6EEcvxhouOdORsVLTWcugwi2+R8zpNUf24vHC07eLyisN9nmJNPyWBp BzY6d7yDMmLVYIRzBqRYg7PMCjHh0n5SDrMkk+O5ylQu1IrxCreZ9QYJD+czI67IB8+0vK o/zzbb0DtATbx8FF211anFFeyxDQvS6BH3gd2/kgczDmYY2mSZDnSORPzfxIgA== Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4V243d6Fz0zYM1 for ; Sat, 23 Mar 2024 16:12:45 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a46a7208eedso429312866b.0 for ; Sat, 23 Mar 2024 09:12:45 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWlvqXm9H+5VKRRXqwTfzpdoPNVj5Zt9cOuvsBGtrPfTJAar/NGauduG0jdjlFauxxPL9mK41h2G+ps+xxqtMpMT6bAESBvkTuC1RukyKf4Qs6r X-Gm-Message-State: AOJu0YySoJMmMksMQexcjYA2fLu1coi5sTdpMjCEOuMWbiYJ5OOLKBPr +ku8EOBJAGvISU5WdFWBj6KcWbJjt1bqiqw4HPavE4cy5f1h0eYR0+XrzRUhDolTyllHSyF6Qqz sBGMUi7vY5ct4EP7VtCBDrQZa5xjDF/+UK/WVZw== X-Google-Smtp-Source: AGHT+IFTcXqoLYL1VjXtFRPi9wWJ2sEdGIi07oS+mRD5yzuHN+6Fa0vn+i3GvnaDJQPqixIHiRujJ0mVWjkYZj6moGE= X-Received: by 2002:a17:906:c106:b0:a47:4836:6609 with SMTP id do6-20020a170906c10600b00a4748366609mr1023340ejc.60.1711210364757; Sat, 23 Mar 2024 09:12:44 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202403231404.42NE4baU095633@gitrepo.freebsd.org> <2567403.0dHE6SNnxz@angua.firefly> In-Reply-To: <2567403.0dHE6SNnxz@angua.firefly> From: Po-Chuan Hsieh Date: Sun, 24 Mar 2024 00:12:07 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 28472e9722d8 - main - Revert "x11-fonts/noto*: Restructure and update" To: "Tobias C. Berner" , Gleb Popov Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000ed8b2306145635c9" --000000000000ed8b2306145635c9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM Tobias C. Berner wrote: > Am Samstag, 23. M=C3=A4rz 2024, 15:14:01 CET schrieb Gleb Popov: > > On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh > wrote: > > > The branch main has been updated by sunpoet: > > > > > > URL: > > > > https://cgit.FreeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803= a2 > > > b1b8f5f98 > > > > > > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98 > > > Author: Po-Chuan Hsieh > > > AuthorDate: 2024-03-23 14:01:07 +0000 > > > Commit: Po-Chuan Hsieh > > > CommitDate: 2024-03-23 14:01:07 +0000 > > > > > > Revert "x11-fonts/noto*: Restructure and update" > > > > > > This reverts commit 3b128ff9f74b28ada2f475f0b816480b1550e5b8. > > > > It is good manners to explain the reason for reverting when doing it. > > Even better to first talk to the original committer and ask him to the > > revert. > > Moin moin > > I completely agree. Given that there has been a phabricator review open > for > two months, with you, sunpoet@ as reviewer, this is looking like poor > judgement on your side. > > As arrowd@ points out, you should have commented on the reverted commit > first, > and elaborate your reasoning for a revert. > > Simply reverting the work of others may lead to fewer contributions. > Please > take this into consideration in the future. > > > mfg Tobias Hello, I'm sorry that I did not put enough information in this reverting commit because I need it to be done ASAP so that less users are affected. There are several reasons I reverted it by myself instead of requesting tijl@ to do so. First, I do not use phab review therefore I did not really review the patch which means it is committed without maintainer approval. Second, I already have my own work for noto updates which is totally in different direction with tijl@'s work. I cannot simply rebase my work onto it. Third, The problem mentioned in the PR is also handled in my own work. Regards, sunpoet --000000000000ed8b2306145635c9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Mar 23, 2024 at 11:38=E2=80=AFPM = Tobias C. Berner <tcberner@gmail.com> wrote:
Am Samstag, 23. M=C3=A4rz 20= 24, 15:14:01 CET schrieb Gleb Popov:
> On Sat, Mar 23, 2024 at 5:04=E2=80=AFPM Po-Chuan Hsieh <sunpoet@freebsd.org> w= rote:
> > The branch main has been updated by sunpoet:
> >
> > URL:
> > https://cgit.Fr= eeBSD.org/ports/commit/?id=3D28472e9722d808739a4d690f6d803a2
> > b1b8f5f98
> >
> > commit 28472e9722d808739a4d690f6d803a2b1b8f5f98
> > Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org= >
> > AuthorDate: 2024-03-23 14:01:07 +0000
> > Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org= >
> > CommitDate: 2024-03-23 14:01:07 +0000
> >
> >=C2=A0 =C2=A0 =C2=A0Revert "x11-fonts/noto*: Restructure and = update"
> >=C2=A0 =C2=A0 =C2=A0
> >=C2=A0 =C2=A0 =C2=A0This reverts commit 3b128ff9f74b28ada2f475f0b8= 16480b1550e5b8.
>
> It is good manners to explain the reason for reverting when doing it.<= br> > Even better to first talk to the original committer and ask him to the=
> revert.

Moin moin

I completely agree. Given that there has been a phabricator review open for=
two months, with you, sunpoet@ as reviewer, this is looking like poor
judgement on your side.

As arrowd@ points out, you should have commented on the reverted commit fir= st,
and elaborate your reasoning for a revert.

Simply reverting the work of others may lead to fewer contributions. Please=
take this into consideration in the future.


mfg Tobias

Hello,

= I'm sorry that I did not put enough information in this reverting commi= t because I need=C2=A0it to be done ASAP so that less users are affected.
There are several reasons I reverted it by=C2=A0myself instead of = requesting=C2=A0tijl@ to do=C2=A0so.
First, I do not use phab rev= iew therefore I did not really review the patch which means it is committed= without maintainer approval.
Second, I already have my own work = for noto updates which is totally in different=C2=A0direction with tijl@= 9;s work. I cannot simply rebase my work onto it.
Third, The prob= lem mentioned in the PR is also handled in my own work.

Regards,
sunpoet
--000000000000ed8b2306145635c9--