From nobody Sat Mar 23 13:54:34 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V228Q5H4Kz5F6tq for ; Sat, 23 Mar 2024 14:46:46 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4V228P1Q03z573N; Sat, 23 Mar 2024 14:46:44 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of junchoon@dec.sakura.ne.jp designates 153.125.133.21 as permitted sender) smtp.mailfrom=junchoon@dec.sakura.ne.jp Received: from kalamity.joker.local (123-1-21-232.area1b.commufa.jp [123.1.21.232]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 42NDsZAr007934; Sat, 23 Mar 2024 22:54:36 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Sat, 23 Mar 2024 22:54:34 +0900 From: Tomoaki AOKI To: Tijl Coosemans Cc: dev-commits-ports-main@freebsd.org Subject: Re: git: d7511b9d0074 - main - Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV Message-Id: <20240323225434.5a46725b8241f4aa13b3ff4a@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spamd-Bar: + X-Spamd-Result: default: False [1.52 / 15.00]; THREAD_HIJACKING_FROM_INJECTOR(2.00)[]; SUBJECT_HAS_CURRENCY(1.00)[]; FAKE_REPLY(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.78)[-0.782]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:153.125.133.16/28:c]; MIME_GOOD(-0.10)[text/plain]; ONCE_RECEIVED(0.10)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[sakura.ne.jp]; GREYLIST(0.00)[pass,body]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; HAS_ORG_HEADER(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP]; MIME_TRACE(0.00)[0:+]; MLMMJ_DEST(0.00)[dev-commits-ports-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_ONE(0.00)[1]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_SOME(0.00)[] X-Rspamd-Queue-Id: 4V228P1Q03z573N Just want to be 100% sure before updating ports tree to this commit and later. Does this mean something like "DEFAULT_VERSIONS+= ssl=base" in /etc/make.conf still work fine? (Means, does this change doesn't affect for ports tree, but affects only Makefile under ${WRKDIR}?) If yes, no problem, maybe. If no, please revert this ASAP. It's too hazardous. Regards. > The branch main has been updated by tijl: > > URL: https://cgit.FreeBSD.org/ports/commit/?id=d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 > > commit d7511b9d00742c3e2d57c6c03718c4a6f4cd3e72 > Author: Tijl Coosemans > AuthorDate: 2024-02-29 21:11:00 +0000 > Commit: Tijl Coosemans > CommitDate: 2024-03-23 11:19:32 +0000 > > Mk/bsd.port.mk: Add __MAKE_CONF=${NONEXISTENT} to WRK_ENV > > And remove it from individual ports. Use WRK_ENV in custom build > commands where necessary. > > FreeBSD make(1) includes /usr/share/mk/sys.mk and that includes > /etc/make.conf if it exists. This happens when you run make in a > port directory but it also happens when the upstream build system uses > make. This commit disables make.conf inclusion in the latter case > because users can define variables like CFLAGS in make.conf that > override ports framework variables and this can cause problems that are > difficult to diagnose. > > If there are any build customisations made through make.conf that > stop working because of this commit then they should be made available > by the ports tree through some mechanism, e.g. an option in a port. > > Some ports were picking up variables from Poudriere make.conf and > required fixes: > > - astro/wmspaceweather x11-clocks/wmcalclock: Add OPSYS to MAKE_ENV. > - games/zhlt: Add ARCH to MAKE_ENV. > - graphics/tachyon: Upstream ARCH is not ports tree ARCH. > Set ALL_TARGET=bsd so upstream ARCH is defined correctly. > Enable multi-threading support while here. > > PR: 277455 > Exp-run by: antoine > --- -- Tomoaki AOKI