From nobody Mon Mar 11 12:40:38 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ttbwf3Nrvz5CvR0; Mon, 11 Mar 2024 12:40:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ttbwf2yd7z4F7G; Mon, 11 Mar 2024 12:40:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710160850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C4a6IQpJ+HuCdGDDCL5WlrvAxBuJmt9aAgntWGuxHXU=; b=dK3vcDncKNQF7X3iHaHG2fa7l0xj6nqGCpmaMvbr9N4WqWEFF05eBNIPpqT4W95aWaF54m 2PtTWGio4MfxjFeojlYasmZc1z3ekv3SDTSprBistw1KDXKukCkWJSx4IuHvMSJ5I6vkj2 62LMLRVRrG19TbS09q2N7MouhH298MzJEVI2Fb3XlVFU4hdi21whPeHV1FU23EhMNDhIUL lNPQon1yiJVo1hAyyhlP2zV1BGiyAhRuU85y3vAUgaVr6CSUaAxA8rbgVfPU25CvwjUESb 73rSQaQpziljR/SgVjMpcrxscZw9qvQVVQcqgB36ExJ9gfQ9yPmzQi5Ic9mOFQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1710160850; a=rsa-sha256; cv=none; b=eG5suUpW7eH0fEvVcVhScPSyu/G/jigiP4F50MTTouzEx8LcsCO25cGUld4Ii2L+Bhqz5G UU5p6AV6xE691qcGVFp2sp38mvi2lZIMlh8F5j9xPI+rHJYNwqaI/sV3f2qy6kyaqNTXBY K/oo3WqhnVpa3Vsk1HXjPZmtC6Hy6EMn+oOH/xLEx0OWxD3slK88+Is/IzC3IIqcMRD/+5 nQXTGCeGMuRooT6VeJdDNSmjSbOvlDv2pr6p1a+tcH0mhyaKKBP+/S5K794OUYxs36IJAK XeIntnJj2CDogbv5bSybJ659MMrhwQAYS5olDP1APTqtdvC0q5Qpy0oI48o8bA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1710160850; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C4a6IQpJ+HuCdGDDCL5WlrvAxBuJmt9aAgntWGuxHXU=; b=d7L7rstM623YrfDr6F3u2oHdEX8Z1h/DrkyM9eMeCXb2qLg6hevcR6pYV90dEOVjaTW5B/ Z3FW7Z0BhgPFsFxyLABFYzecYftwCJECW+tOMGe592NhlVlRXJ6C0rD6RoefWK1qv5DSjU XaZONkeyqOQfRqIOC/UQvxeIPOtw8fciWmwyKEPuqeTAEn5NVU9rMrAoE6md4EVco/fgHL UL3UKkdrAzQQNZjLXaNRGozWs447Pgj1NryHJ6yH4C/8/TIZZ0ayE03NFAlKVbWUaTRZTY XHAMXUBA5u2Mn+8Dqa183D4muU20HWxDXyof3Sod2r+8wAVvax4wrQqcHS/QDw== Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Ttbwf29zFz13mR; Mon, 11 Mar 2024 12:40:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-42f1d354005so18756991cf.0; Mon, 11 Mar 2024 05:40:50 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXKpnagCSRznCLXnpdapoY3qGb0PI5GGASUz4gYnT/Rz4HnyxSnsBSrNhV97mColyv/XLoig3dzLjqaekdQlf+bvA32tlYfSz/1kZpRLUXzRZXvgSwTFQ8xVc2a315JQm5+lw/+M+ISrNUNWaY/ZDaMsKF1+cBmXn+836y7qWH9HQleKTxyS9aPt73rpRnlCjS73PA= X-Gm-Message-State: AOJu0YxXLnC8cJ9PaQ8AaEM414/DqbuRnUymvR77gPpaUqBn/gKWszWx BssUKC/5HkAWHqeCHd2vKdcvUNX7Cs7bE3bcY+LfOqlx7/278uS8dNSg/knnJ2usj8kDOk1xAcS TzISAwKzQ44KNvaYK2vIRl1wTNGE= X-Google-Smtp-Source: AGHT+IGnJ9EfEzyLXCoNq34wQ+hWqAgO79xpmOL0Sjh2XEotCPpAgXr/zX7lGwzSXqpd8PQQjZJ4sEuTgYQ05pDS2Nk= X-Received: by 2002:a05:622a:5cb:b0:42f:13ef:e8a3 with SMTP id d11-20020a05622a05cb00b0042f13efe8a3mr8177439qtb.60.1710160849841; Mon, 11 Mar 2024 05:40:49 -0700 (PDT) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 References: <202402161824.41GIOgvd075302@gitrepo.freebsd.org> <2911916.SSXfckUlLJ@mercury> In-Reply-To: <2911916.SSXfckUlLJ@mercury> From: Nuno Teixeira Date: Mon, 11 Mar 2024 12:40:38 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: ca21dddc0e31 - main - graphics/libnsgif: Update to 1.0.0 To: Max Brazhnikov Cc: Neel Chauhan , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Max, What about create a repo copy of libnsgit 0.2.1 and renamed it to libnsgit02 or libnsgit021. For what I know only graphics/imv fails to build with 1.0.0: NSGIF_BROKEN=3D fails to build with libnsgif 1.0.0, see also https://lists.sr.ht/~exec64/imv-devel/%3CCAFDf7UKQCAO5VXqykRCnpHG6u0owdXRnk= 5kt0S3b-aTkpuF66Q%40mail.gmail.com%3E NSGIF_LIB_DEPENDS=3D libnsgif.so:graphics/libnsgif NSGIF_MESON_ENABLED=3D libnsgif So I don't know if it is worthed to make this port. Also I didn't get any complains about imv broken option. Cheers, Max Brazhnikov escreveu (domingo, 18/02/2024 =C3=A0(s) 1= 2:01): > > Hi all, > > On Sat, 17 Feb 2024 07:26:22 +0000 Nuno Teixeira wrote: > > Did you do a consumers test? > > > > -include/libnsgif.h > > +include/nsgif.h > > > > graphics/imv: > > ../src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not foun= d > > 9 | #include > > > > Any clues on recomended way to fix? > > > > Neel Chauhan escreveu (sexta, 16/02/2024 =C3=A0(s) 18:= 24): > > > > > > The branch main has been updated by nc: > > > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dca21dddc0e31a6be1db1= f5966a283f52d89cddf5 > > > > > > commit ca21dddc0e31a6be1db1f5966a283f52d89cddf5 > > > Author: Neel Chauhan > > > AuthorDate: 2024-02-16 17:42:44 +0000 > > > Commit: Neel Chauhan > > > CommitDate: 2024-02-16 18:24:27 +0000 > > > > > > graphics/libnsgif: Update to 1.0.0 > > > --- > > > graphics/libnsgif/Makefile | 2 +- > > > graphics/libnsgif/distinfo | 6 +++--- > > > graphics/libnsgif/files/patch-Makefile | 10 ---------- > > > graphics/libnsgif/pkg-plist | 4 ++-- > > > 4 files changed, 6 insertions(+), 16 deletions(-) > > > > > > diff --git a/graphics/libnsgif/Makefile b/graphics/libnsgif/Makefile > > > index 09c07dda9f9a..7e0697f3b78c 100644 > > > --- a/graphics/libnsgif/Makefile > > > +++ b/graphics/libnsgif/Makefile > > > @@ -1,5 +1,5 @@ > > > PORTNAME=3D libnsgif > > > -PORTVERSION=3D 0.2.1 > > > +PORTVERSION=3D 1.0.0 > > > CATEGORIES=3D graphics > > > MASTER_SITES=3D http://download.netsurf-browser.org/libs/releases/ > > > EXTRACT_SUFX=3D -src.tar.gz > > skip > > > > diff --git a/graphics/libnsgif/pkg-plist b/graphics/libnsgif/pkg-plis= t > > > index 38365be87a3a..927929719b65 100644 > > > --- a/graphics/libnsgif/pkg-plist > > > +++ b/graphics/libnsgif/pkg-plist > > > @@ -1,5 +1,5 @@ > > > -include/libnsgif.h > > > +include/nsgif.h > > > lib/libnsgif.so > > > -lib/libnsgif.so.0 > > > +lib/libnsgif.so.1 > > > lib/libnsgif.so.%%VERSION%% > > > libdata/pkgconfig/libnsgif.pc > > What was the reason for this commit? > > Changes like this require from the maintainer to test consumer ports. Req= uest exp-run if you can't test all consumers locally, notify other maintain= ers about the change (exp-run won't catch all cases), ask for help if you n= eed it. To me committing untested stuff that breaks other ports is disrespe= ctful to fellow maintainers and users. > > Cheers, > Max > > > --=20 Nuno Teixeira FreeBSD Committer (ports)