Re: git: 79f8f9c8f54b - main - */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man"

On Mon, Mar 11, 2024 at 01:08:53PM +0300, Vladimir Druzenko wrote:
> 11.03.2024 10:42, Mathieu Arnold пишет:
> > On Sun, Mar 10, 2024 at 10:58:38PM +0000, Vladimir Druzenko wrote:
> > > The branch main has been updated by vvd:
> > > 
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=79f8f9c8f54b8de3d324d30ce9a19649bbe69e69
> > > 
> > > commit 79f8f9c8f54b8de3d324d30ce9a19649bbe69e69
> > > Author:     Vladimir Druzenko <vvd@FreeBSD.org>
> > > AuthorDate: 2024-03-10 22:49:41 +0000
> > > Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
> > > CommitDate: 2024-03-10 22:49:41 +0000
> > > 
> > >      */*: convert Makefile patches to MAKE_ARGS after "Move man pages to share/man"
> > >      Replaced patches for Makefiles with "MAKE_ARGS+=MANDIR=${PREFIX}/share/man"
> > Why += ? Is the variable defined before in the Makefile ? If it is, then
> > you should append to its previous value, if it is not, += will only
> > confuse people in the future, wondering why a non existing variable is
> > appended to instead of being set.
> > 
> I took other ports as examples, in particular sysutils/lmmon.

Looking for examples in the ports tree is not the best idea, people like
to be creative and try very hard to not learn how make works so they can
continue making creative things.

> 
> Also, AFAIU, "MAKE_ARGS+=" allow users add custom options via make.conf same
> as "CFLAGS+=".

MAKE_ARGS is not a user facing variable, so please, unless it is a
master port, and slave ports set MAKE_ARGS, do not use +=.

-- 
Mathieu Arnold