From nobody Sat Mar 09 12:35:20 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TsMvN3MpZz5D57t for ; Sat, 9 Mar 2024 12:35:28 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Received: from smtp-8fa8.mail.infomaniak.ch (smtp-8fa8.mail.infomaniak.ch [IPv6:2001:1600:4:17::8fa8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "relay.mail.infomaniak.ch", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TsMvN1HrNz4dY2 for ; Sat, 9 Mar 2024 12:35:28 +0000 (UTC) (envelope-from daniel.engberg.lists@pyret.net) Authentication-Results: mx1.freebsd.org; none Received: from smtp-3-0001.mail.infomaniak.ch (unknown [10.4.36.108]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4TsMvD58y5zMpncb; Sat, 9 Mar 2024 13:35:20 +0100 (CET) Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4TsMvD27T9zMpnPs; Sat, 9 Mar 2024 13:35:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=pyret.net; s=20231006; t=1709987720; bh=kFBfmay1nB/6Nq77jkw1e6+JCdinF6/WxgnzD2n3FIs=; h=Date:Subject:From:Reply-To:To:Cc:References:In-Reply-To:From; b=DWCw/9YMAZ953xgauuEBBbSZ/Qi6mfpjxy03CdmqYlM6wSIl4aNkhSMUtZfbx0FV7 MfX0YjsVCwbI/yBKk3/WSVgkPeCclv8NxBIzaqNdQmYvyn0tbABhL3tQZUISL5uqOH FAecEjDKTr1eRcYn+Col1BPdvqHtJ8oyHK2UzhDqCoB4H8EtPR1HSzHF4LDgZdxu4m YJdIIam6R1fqLezo0wpQcK9IL/qnZxSoKsppZQkNe9b84TmbYnHiTbCZA1/KzCu7wX YFpp/B18r1kAW0+79XV/3rlwTReAkAB2SuVkL0xdI/AR77D2szqdaTEx/RuhkqCdKk NcFleprY1T/kQ== Message-ID: Date: Sat, 09 Mar 2024 13:35:20 +0100 Subject: Re: git: 450aafcba559 - main - textproc/tinyxml2: Update to 10.0.0 From: Daniel Engberg Reply-To: Daniel Engberg To: Po-Chuan Hsieh Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-WS-User-Origin: eyJpdiI6IlpXY2M3anpmTFd2YWhmMHhCeUpSQnc9PSIsInZhbHVlIjoibUhIdmJzWmVWYkhkRFdtU2Vma0RPZz09IiwibWFjIjoiNjhkMTczYWI1YWJlZmY1MzdmZWU5ZTA1OGM5MDdmZjRjMDRjYzhiNzVlM2I0MDg0Y2Q2OTQyYzYxZmEwMWI5YyIsInRhZyI6IiJ9 X-WS-User-Mbox: eyJpdiI6InhybHZBdG9VZWZNYjJISTBGRlNKTVE9PSIsInZhbHVlIjoibm5SanduRk5oRTh6ZFZTNXE4c3B2Zz09IiwibWFjIjoiNjQ0NTNiMGY5Zjg5MzQyNDYwZTZjZTI0YWEzOTdlMTAwNTc1MmFiNThjZWRmZTI5NmE2OWY3M2Q5N2E2MjdhOCIsInRhZyI6IiJ9 X-WS-Location: eJxzKUpMKykGAAfpAmU- X-Mailer: Infomaniak Workspace (1.3.651) References: <202402211520.41LFK8mS022399@gitrepo.freebsd.org> <9ea613e41885bc4b8cab826a1d5508da@mail.infomaniak.com> In-Reply-To: X-Infomaniak-Routing: alpha X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29222, ipnet:2001:1600::/32, country:CH] X-Rspamd-Queue-Id: 4TsMvN1HrNz4dY2 On 2024-03-09T13:11:23.000+01:00, Po-Chuan Hsieh wrot= e: > On Fri, Feb 23, 2024 at 5:23=E2=80=AFAM Daniel Engberg < > daniel.engberg.lists@pyret.net> wrote: >=20 >=20 > > On 2024-02-21T16:20:08.000+01:00, Po-Chuan Hsieh > > wrote: > >=20 > > The branch main has been updated by sunpoet: > >=20 > > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D450aafcba559f95c94c5f= 195d83b5fe4fdc3748a > >=20 > > commit 450aafcba559f95c94c5f195d83b5fe4fdc3748a > > Author: Po-Chuan Hsieh > > AuthorDate: 2024-02-21 14:29:27 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2024-02-21 15:06:47 +0000 > >=20 > > textproc/tinyxml2: Update to 10.0.0 > >=20 > > - Convert to meson > > - Fix 0c022f0fc854184d95ff3303049a063a39b1f551 > > - Bump PORTREVISION for package change > > - Bump PORTREVISION of dependent ports for shlib change > > - Remove duplicate PORTREVISION from math/linbox > >=20 > > Changes: https://github.com/leethomason/tinyxml2/releases > > https://github.com/leethomason/tinyxml2/commits/ma= ster > > --- > >=20 > > Hi, > >=20 > > Please explain what you fixed as this change makes consumers utilizing > > CMake to find (lib)tinyxml2 now requiring patching when they worked fi= ne > > before your change? > >=20 > > Your patch for net/ecal is not a fix but a workaround for something th= at > > broke by this commit. > >=20 > > Here's a build log of said port and the PR related. > >=20 > > https://pdr2.bofh.network/data/132-diizzy/2024-01-01_11h58m45s/logs/ec= al-5.12.1_3.log > >=20 > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D277227 > >=20 > > Best regards, > > Daniel > >=20 > =20 > Hello, >=20 > Obviously you did not handle the dependent ports which encounter shlib > change. >=20 > Enforce port A to use cmake because port B uses cmake. > This behavior is toxic. It works like a virus. >=20 > Regarding net/ecal, please explicitly point out what is the broken > in net/ecal. > If you mean something like "(ecal-5.12.1_3) > /wrkdirs/usr/ports/net/ecal/work/stage//usr/local/bin/ecal_mon_gui-5.12.1= - > required shared library libCustomQt.so not found", I see nothing related > with tinyxml2's cmake script. > Not to mention that I see the same message when tinyxml2 is built with > cmake. >=20 > The cmake problem is misleading information. >=20 > Regards, sunpoet Hi, The issue is that you broke all projects utilizing CMake's find_package rou= tine to find libtinyxml2, https://cmake.org/cmake/help/latest/command/find_= package.html explains why this breaks projects. Your commit for net/ecal is= a hack to work around this issue not fixing it, instead submit a proper PR= upstream and/or at least create a meta PR in bugzilla. If you don't want to maintain projects utilizing a certain build framework = feel tree to returns these to the pool. Best regards, Daniel